From patchwork Thu Mar 9 20:04:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 661043 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp496438wrb; Thu, 9 Mar 2023 12:07:56 -0800 (PST) X-Google-Smtp-Source: AK7set/oJh5dGLMxJP5XUZwE7y26pliMFdcC3gqC/XEQtRChHKqKtRvcsNx/A5fUNthEgwUIE+aF X-Received: by 2002:a17:907:1ca3:b0:8ea:2055:4f1b with SMTP id nb35-20020a1709071ca300b008ea20554f1bmr29176281ejc.24.1678392476748; Thu, 09 Mar 2023 12:07:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678392476; cv=none; d=google.com; s=arc-20160816; b=yAdbwHxhUNXzE+u1YqdVAaG4XcqZAkLofhsKWiI+n8zdTS6CZ4qqCCwAZSF0c0HJyM S9vkPUjIzzxPLXvflxBQ/xdJdfn6HHu8kmMXI2hLjxts3EHlY0e9ah9ZWhHSdHh2pIsO ipWtVo7iCTbVBuDmPWjuc4bVn0wkI030Ty7Tz6GnLGG58qZilfTCAiF5MslslN/1LEDP yXOseI0Zd1+bTFHFAAcpg1ZewvnZoQvZZjFqpu3gcjIViLawy/YzTbnAU9tXPEq+QLBi WMlrvgIKM3TurWthP5WCdhxVtRfYTRzhbNtCPH/JevJtgngFnQfcXeMJcNd88KYAD1hI A4+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1NRwUghpZO73BVX8UYr3AFNQqLtG8WJKwj6F3WpUYAs=; b=v9L6PrsmYJzjr5AUo8LI5enjn+EZBuxvLsYdSfzk3csN5wPnpn/RzjYy6nrodfVIuU WQBKwcRwMOmREXKX95Q9CpTlYF0AkqGJGQ/pe0lwwNrC/g/++S6sc2Ipp+2Z4/bSrK1o rkchMaYQNlaPu8qC2vgJNVctYJCUgn8AEicM6sEFktBheTbsnDl3pFVybMWuysxfEOYW nhJ4AazYYksb4wOVmNffkcPb17Y/m0NZaCrMCD0lHIZ4UeWCMQZk7WAVkNdY25ZrRhPZ SZaBd+MKotjVkVW0SzIjL1oHtoY38gyMD7dVaj4XyqLxFGdWNSBiB6tAiAVJ7+D+ySOU M7FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OOLfdhE1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f22-20020a1709067f9600b008d10fe78243si13573095ejr.878.2023.03.09.12.07.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Mar 2023 12:07:56 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OOLfdhE1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paMWX-0003mv-QM; Thu, 09 Mar 2023 15:06:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paMWU-0003la-PA for qemu-devel@nongnu.org; Thu, 09 Mar 2023 15:05:59 -0500 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paMWT-0000gj-0C for qemu-devel@nongnu.org; Thu, 09 Mar 2023 15:05:58 -0500 Received: by mail-pl1-x62d.google.com with SMTP id u5so3197240plq.7 for ; Thu, 09 Mar 2023 12:05:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678392355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1NRwUghpZO73BVX8UYr3AFNQqLtG8WJKwj6F3WpUYAs=; b=OOLfdhE1DRwxZnO+yFvKxoXagENHxqHk0TUYhBWAhuMIyZnfi0/oYUhAQY9QJk83zS L5cHE30nBdJcoQV2dsgeV7UW8ZpGRBT0kI6xeFjKCJMRVUMVxr7U6VMtkFX0HxtJ+d67 MinRpQl8XW9TvUgx2aJpjTa8PiPTp8qYZz3y8b4XQ2/6UXJAaqAH5HLlQICBsitgU0s7 /lFzSKzIkjF9PWbxEnk/m0o2hT3bNNMxtqhzm/CjQSrcqpC8VLHu9Mbse2PvsUZIc/FU qZ6D7XNSCJngJOIdEcx6NWwUoS6jRkcN9Bc28vKU/rDJ5LDBcFTKt0BjT2MOunN1Ky/e 0YsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678392355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1NRwUghpZO73BVX8UYr3AFNQqLtG8WJKwj6F3WpUYAs=; b=zvyhH4zJzrJdMo6xEAkg3EoTXerAOSXMfaqouv+PLH+2GE9mEVqO6enZwL7Cf2o9dF Y//mYtMGS/sKM8a7GrZEWoCDCvoAenwpnOk5eZI8VRoa0P50Fx98NDPCHUXvLyivAbQT DM3HobMYWHWUGxok5ugeBjNi8t9lWxJBYaeeqVrUGXxgTedHueYq7Vp8g2/iGftR3OxC wZ8e+tfQghA4MHHAma4y6S93J8l8je4XROSH99kAsKwALnlxn0v2KGwrhE445NlWoFlV ZyNXyr0ig3h42ylJj3nJzru5mmPHwqtZDI0qa/RxM0m9+I1Kn62wT3maieC6EAoZj4cE 0W+A== X-Gm-Message-State: AO0yUKXUrJsGq0zQm0DCKh/FpC0UKRilG+JyNRFlu1WeAI5Fgkf57P5u r62+TNJOPG2Q4B1w3bcGOIWMl3MOOSXRn+VOOd0= X-Received: by 2002:a17:90b:1b05:b0:237:aa9f:968c with SMTP id nu5-20020a17090b1b0500b00237aa9f968cmr23648036pjb.34.1678392355409; Thu, 09 Mar 2023 12:05:55 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:bf7f:79a0:a976:bdaf]) by smtp.gmail.com with ESMTPSA id t20-20020a17090ad15400b002340f58e19bsm308083pjw.45.2023.03.09.12.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 12:05:55 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL v2 03/91] target/mips: Drop tcg_temp_free from mxu_translate.c Date: Thu, 9 Mar 2023 12:04:22 -0800 Message-Id: <20230309200550.3878088-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230309200550.3878088-1-richard.henderson@linaro.org> References: <20230309200550.3878088-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Translators are no longer required to free tcg temporaries. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/tcg/mxu_translate.c | 51 --------------------------------- 1 file changed, 51 deletions(-) diff --git a/target/mips/tcg/mxu_translate.c b/target/mips/tcg/mxu_translate.c index f52244e1b2..8703b0cef4 100644 --- a/target/mips/tcg/mxu_translate.c +++ b/target/mips/tcg/mxu_translate.c @@ -513,8 +513,6 @@ static void gen_mxu_s32i2m(DisasContext *ctx) } else if (XRa == 16) { gen_store_mxu_cr(t0); } - - tcg_temp_free(t0); } /* @@ -537,8 +535,6 @@ static void gen_mxu_s32m2i(DisasContext *ctx) } gen_store_gpr(t0, Rb); - - tcg_temp_free(t0); } /* @@ -613,9 +609,6 @@ static void gen_mxu_s8ldd(DisasContext *ctx) } gen_store_mxu_gpr(t0, XRa); - - tcg_temp_free(t0); - tcg_temp_free(t1); } /* @@ -664,11 +657,6 @@ static void gen_mxu_d16mul(DisasContext *ctx) } gen_store_mxu_gpr(t3, XRa); gen_store_mxu_gpr(t2, XRd); - - tcg_temp_free(t0); - tcg_temp_free(t1); - tcg_temp_free(t2); - tcg_temp_free(t3); } /* @@ -741,11 +729,6 @@ static void gen_mxu_d16mac(DisasContext *ctx) } gen_store_mxu_gpr(t3, XRa); gen_store_mxu_gpr(t2, XRd); - - tcg_temp_free(t0); - tcg_temp_free(t1); - tcg_temp_free(t2); - tcg_temp_free(t3); } /* @@ -821,15 +804,6 @@ static void gen_mxu_q8mul_q8mulsu(DisasContext *ctx) gen_store_mxu_gpr(t0, XRd); gen_store_mxu_gpr(t1, XRa); - - tcg_temp_free(t0); - tcg_temp_free(t1); - tcg_temp_free(t2); - tcg_temp_free(t3); - tcg_temp_free(t4); - tcg_temp_free(t5); - tcg_temp_free(t6); - tcg_temp_free(t7); } /* @@ -860,9 +834,6 @@ static void gen_mxu_s32ldd_s32lddr(DisasContext *ctx) tcg_gen_qemu_ld_tl(t1, t1, ctx->mem_idx, MO_TESL ^ (sel * MO_BSWAP)); gen_store_mxu_gpr(t1, XRa); - - tcg_temp_free(t0); - tcg_temp_free(t1); } @@ -1125,9 +1096,6 @@ static void gen_mxu_D16MAX_D16MIN(DisasContext *ctx) tcg_gen_shri_i32(t0, t0, 16); /* finally update the destination */ tcg_gen_or_i32(mxu_gpr[XRa - 1], mxu_gpr[XRa - 1], t0); - - tcg_temp_free(t1); - tcg_temp_free(t0); } else if (unlikely(XRb == XRc)) { /* both operands same -> just set destination to one of them */ tcg_gen_mov_i32(mxu_gpr[XRa - 1], mxu_gpr[XRb - 1]); @@ -1161,9 +1129,6 @@ static void gen_mxu_D16MAX_D16MIN(DisasContext *ctx) tcg_gen_shri_i32(t0, t0, 16); /* finally update the destination */ tcg_gen_or_i32(mxu_gpr[XRa - 1], mxu_gpr[XRa - 1], t0); - - tcg_temp_free(t1); - tcg_temp_free(t0); } } @@ -1226,9 +1191,6 @@ static void gen_mxu_Q8MAX_Q8MIN(DisasContext *ctx) /* finally update the destination */ tcg_gen_or_i32(mxu_gpr[XRa - 1], mxu_gpr[XRa - 1], t0); } - - tcg_temp_free(t1); - tcg_temp_free(t0); } else if (unlikely(XRb == XRc)) { /* both operands same -> just set destination to one of them */ tcg_gen_mov_i32(mxu_gpr[XRa - 1], mxu_gpr[XRb - 1]); @@ -1266,9 +1228,6 @@ static void gen_mxu_Q8MAX_Q8MIN(DisasContext *ctx) /* finally update the destination */ tcg_gen_or_i32(mxu_gpr[XRa - 1], mxu_gpr[XRa - 1], t0); } - - tcg_temp_free(t1); - tcg_temp_free(t0); } } @@ -1384,9 +1343,6 @@ static void gen_mxu_S32ALNI(DisasContext *ctx) tcg_gen_shri_i32(t1, t1, 24); tcg_gen_or_i32(mxu_gpr[XRa - 1], t0, t1); - - tcg_temp_free(t1); - tcg_temp_free(t0); } break; case MXU_OPTN3_PTN2: @@ -1410,9 +1366,6 @@ static void gen_mxu_S32ALNI(DisasContext *ctx) tcg_gen_shri_i32(t1, t1, 16); tcg_gen_or_i32(mxu_gpr[XRa - 1], t0, t1); - - tcg_temp_free(t1); - tcg_temp_free(t0); } break; case MXU_OPTN3_PTN3: @@ -1436,9 +1389,6 @@ static void gen_mxu_S32ALNI(DisasContext *ctx) tcg_gen_shri_i32(t1, t1, 8); tcg_gen_or_i32(mxu_gpr[XRa - 1], t0, t1); - - tcg_temp_free(t1); - tcg_temp_free(t0); } break; case MXU_OPTN3_PTN4: @@ -1598,7 +1548,6 @@ bool decode_ase_mxu(DisasContext *ctx, uint32_t insn) } gen_set_label(l_exit); - tcg_temp_free(t_mxu_cr); } return true;