From patchwork Mon Mar 20 13:42:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 665194 Delivered-To: patch@linaro.org Received: by 2002:a5d:5602:0:0:0:0:0 with SMTP id l2csp1130325wrv; Mon, 20 Mar 2023 06:43:00 -0700 (PDT) X-Google-Smtp-Source: AK7set9nram83D2hQUFoufelMWBR/7fnkpMRa88msL2GmnowzBm48He1Z2Z+sjNYz7l5eseJs0Bb X-Received: by 2002:a05:6214:48d:b0:5a2:d726:b84c with SMTP id pt13-20020a056214048d00b005a2d726b84cmr50866038qvb.19.1679319779993; Mon, 20 Mar 2023 06:42:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679319779; cv=none; d=google.com; s=arc-20160816; b=IqwAZSDhOs/ybUbPv5LLHS2lo1lyuJWDjIM+1G8GiFFxGp5bPxzmeW2CBaMJQv2gCw HX1fm9Z4cVqDiUCQBVOfpcD1JiJFp6DLXs441X+NTC/eguo5NP2h7UDCbebAKju8cC0p d5FFBpSOXYpllzt+pHySoAMDKNWAoaq5M+UjidoNKmVb9a6FiLRcwnFiISHlTEhfMhQ4 rZYR+aZSsDtumao/a8EhhFrUxNp4asEfQgIvewsdHhqFCswPsaQfCueNTKhhfW8JC351 N6/jdeYDeEh/l4MmOenhPo9iUrGLKn9LmP1Aur31PG7zOzIr1axkV06jBooN3jkZW7uO vccg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pdlASMT4jISCzMP7osi2/4IX99eROCkVPgjLB1OApxg=; b=HCKSJdilU8VTvyc8tTv8Jp3BJGxyXCsWoXdzMyWrgpJsMj3ll4yCvu12MB38rqJ26J NtbZK6GA3tn8dMIdcuh1JittsELVj0u5e2DLHn7e1L69GWsHjSd0wg7WvSdllg4qgxw3 vTV01ETntBaM62dwyxEIEXD4En8G3EO0yDAQyng8efVKLIf7Alnc90KexxuADg8UYxQP RQk/Y5fWK2fQVbNf8SlgqVFVh1aihAskubxIc8nSGeE2NyQ5pPSpfhGPAecr6OdEKGYr 85CPrYEhUHjA0ApjFaZTU1jC7DFdzyp+lj2MOeN/+sUs8apVZFy41zFCPOnbRmQjHWnZ mCpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=avX1Qg+h; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y195-20020a3764cc000000b007464c429026si5697121qkb.32.2023.03.20.06.42.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Mar 2023 06:42:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=avX1Qg+h; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peFmS-0006Wo-52; Mon, 20 Mar 2023 09:42:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peFmQ-0006W5-Ku for qemu-devel@nongnu.org; Mon, 20 Mar 2023 09:42:30 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peFmO-0001q3-5X for qemu-devel@nongnu.org; Mon, 20 Mar 2023 09:42:30 -0400 Received: by mail-wm1-x333.google.com with SMTP id o32so1146834wms.1 for ; Mon, 20 Mar 2023 06:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679319746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pdlASMT4jISCzMP7osi2/4IX99eROCkVPgjLB1OApxg=; b=avX1Qg+h2b0RZAo1ojnrb1iql8RIL2p0UrP8OWRglchnMWQxtbGI6+ENSfRPaCxAn8 fAcxbvUwuq5JPvE7a5T9GwanXT6u+fKnay0vDw8GbaMGJEvm1RqedetRhAtHYkUC1Tuq G79SHwnLtHFux/Z73+Xy4rheTmynHPh6sYSw+HRjkKwBnAkI0E5uL9ZmsRpMAM6OMQtT fs+EtkM316QNnbNpI7R665nVZGk94C7hbPJFHrtDk9wqveDApL97XQruhhTAocNhI/Qu JHPN8XuRu6YBJKbsODCCDpHrjuIMt0vNxbAI0jaz3GmPklnlQXmbncf50SJTHEVuczRP kHDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679319746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pdlASMT4jISCzMP7osi2/4IX99eROCkVPgjLB1OApxg=; b=iuadR0B5AnISsng0wn0cAuVRHNZc6vK68W/umDuG5+/5fgzOgVJ7cZzMLT/t+4CH7E 505i9ObVaPlb41oXMV4IQ5x+JmRj1CXgR5Y872JbFNB8wPCBh9kJpY8tjSiuffN1YjuN pEd9YDLB+mcNnxGIblFJNb2wesm2R5bfWOP64GqFX88g/oBT+D7qwXvzRuD/yHvHS2Gz FmGwLadvKyKgHoZ7hZHrvDgYPLlnj/6kIXWIb+g+ljKcPOl2YMYtMzDc14JeYcEPBXK3 mF6f3A2Bcg8HyKSh2SmQKUPmvxinLbf9XfiNwdH2bGzPD8uImopJaLmX4Sa0Q+D+RHgo A/fw== X-Gm-Message-State: AO0yUKXKSTeFX4ivH7GgXP+JKcXnoyVoi1vDibymUb2m+51IidpNtOMy PSFHQ9JuZJ+SB7Poei/G/mvFv0rjnjZfZFQxCrDpTA== X-Received: by 2002:a7b:c7cf:0:b0:3ed:dfd8:653d with SMTP id z15-20020a7bc7cf000000b003eddfd8653dmr4556198wmk.28.1679319746379; Mon, 20 Mar 2023 06:42:26 -0700 (PDT) Received: from localhost.localdomain ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id 16-20020a05600c025000b003ed1ff06faasm10524429wmj.19.2023.03.20.06.42.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 20 Mar 2023 06:42:26 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-block@nongnu.org, =?utf-8?q?Philippe_Mathieu-D?= =?utf-8?q?aud=C3=A9?= , =?utf-8?q?Simon_W=C3=B6rner?= Subject: [PATCH-for-8.1 1/5] qemu/osdep.h: Do not declare function prototypes using extern keyword Date: Mon, 20 Mar 2023 14:42:15 +0100 Message-Id: <20230320134219.22489-2-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230320134219.22489-1-philmd@linaro.org> References: <20230320134219.22489-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org By default, C function prototypes declared in headers are visible, so there is no need to declare them as 'extern' functions. Remove this redundancy. This also fixes when building under MSYS2: C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:1075:21: error: standard attributes in middle of decl-specifiers 1075 | # define G_NORETURN [[noreturn]] | ^ C:/msys64/code/qemu/src/include/qemu/osdep.h:240:8: note: in expansion of macro 'G_NORETURN' 240 | extern G_NORETURN | ^~~~~~~~~~ Reported-by: Simon Wörner Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1541 Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/osdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index f68b5d8708..79c26c748a 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -237,7 +237,7 @@ extern "C" { * supports QEMU_ERROR, this will be reported at compile time; otherwise * this will be reported at link time due to the missing symbol. */ -extern G_NORETURN +G_NORETURN void QEMU_ERROR("code path is reachable") qemu_build_not_reached_always(void); #if defined(__OPTIMIZE__) && !defined(__NO_INLINE__)