From patchwork Mon Apr 3 13:49:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 669770 Delivered-To: patch@linaro.org Received: by 2002:a5d:4d08:0:0:0:0:0 with SMTP id z8csp1894379wrt; Mon, 3 Apr 2023 06:50:07 -0700 (PDT) X-Google-Smtp-Source: AK7set8MTBjUxuHRPFN68+GSIqmudqVHUDVqFPDgY81t9rgLSW11ucbMpOoRhr5eTaB32xfVfy2I X-Received: by 2002:ac8:5702:0:b0:3bf:d35d:98bb with SMTP id 2-20020ac85702000000b003bfd35d98bbmr63735622qtw.56.1680529806879; Mon, 03 Apr 2023 06:50:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680529806; cv=none; d=google.com; s=arc-20160816; b=u4pVPhkP2CYux0XCmq4PJSDJlerk9PU2sFASGFVD5k35mww1HbqAMcI2X614F5siBt MVHcBHCWNyZnu4zECdkaCr2w7e9oZEtrANy4D7s9jDshnfvXpRhSBz7fy+9tKDVT0yKa Ak50dIonunWB+vHTy8+OrEg+aFSvyPykXiFNgLahnKyrwqUHehDMVbw9XPLiRAdPVBnN +L2e8nk6bYgE0ZNrhnJbviIGGAOLc9NEV+SR/FSAPwL73I8//KPJ5b93oq0HvQy1Ev2/ WiYgdLm8IyMI/GQGZ5VZByZFi2bQEh6BOkiP/KlQ9eOsUmz74TvZerj6Nm0bLZk5xkS1 W2Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dHHLYJ1Q7CDYpzOnQyJie+UJ0r74Mi54/+ouByLjk3E=; b=nDSaox5VIRaxBXs6Eq81feo257U+ldz2vl1tMMAluOrbCbzlGsMm3LIxeFgWDh6E3m KJCi4IJ79rkKLdCZKCRA+7JapTyT/7UNrzWkGYhoL7Xh5QkJDW/Gm9zc2VQaZJBqrB6n DUCTK/66166evMFOmJ8Hr+VRu55EpJIAPyM/mkzIkAowEGbo5YOPbW1aXNT42kYjbRGP i4O632XLJQAmfikszVlwWrdUN71zUtEDLOvePhIpopApeM+jN5Q0TYDno4Wpvocpxb/1 oeoNnKQ3lNz33s8+NgQV1ygLPaCUC7X06Sn+3V2iCNVER73kHFqK+T8hc6X3VdWog2Hz Fcdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CWzuya7J; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t10-20020a05622a148a00b003b9ec33eabesi6006076qtx.463.2023.04.03.06.50.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Apr 2023 06:50:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CWzuya7J; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjKYp-0002ty-Ma; Mon, 03 Apr 2023 09:49:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjKYo-0002t0-Lx for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:26 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjKYm-0004tX-6v for qemu-devel@nongnu.org; Mon, 03 Apr 2023 09:49:26 -0400 Received: by mail-wm1-x333.google.com with SMTP id hg25-20020a05600c539900b003f05a99a841so240162wmb.3 for ; Mon, 03 Apr 2023 06:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680529762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dHHLYJ1Q7CDYpzOnQyJie+UJ0r74Mi54/+ouByLjk3E=; b=CWzuya7JW2bY34opxAKYIrNfyS65J2Ve7Op8RUvVCTJWgo8mFVV0WttZ5XTBIOpOuw qEc0uVEkLj4BSXrkGYzQuo4l+mgtk1/Cg5F8oZdEugZIT790Y3kd7/R/ROH79z7UrZQ0 v3Sn6tKQEDY9L3zgiYs7vsdbe8VCOYPEkeTzMCKl6g63yKNr+tFOllZTZi0lmaKWowSm PARwtkZgJ1mpnizEjF6BHJMoGJzl5i5cHzOy7KasRbZka01wrMHVeI0zfyoEPcjqUfVu oF/kl0e4k2mu2v96VOyu3vif1056EhDnaETNYv0h58W43SS6YkTyw2bu6X5j4qNswFKj vOHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680529762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dHHLYJ1Q7CDYpzOnQyJie+UJ0r74Mi54/+ouByLjk3E=; b=I06xUuPu0UDUOxMDH3/LQDW17aYDXsYCcxJnqLpWgJo0/c9VWyRTxDibKOR2p2i7eU j8LfITFajPwYyFR6fOGZ4omLyNV2JGGivqr6R50O1hKTttK40UNn0I2W+flS5HvSACVW E4b24vt2nCAULWNca9JJ3RfX0PktsHXgswvdE+NNEMLkyiB9yVjVUWTBPo56Jr21LUKB KWyvaD82bTmMwKv4REF/uuxe36y8IumHyH3G3yxAIs5L6gHlzmzjawHuyvUEUEC5hS0V cMb73M37SK1kiAlj8cIbDoAvUIESSuUI9PQrOZEchvCU4Suw9IoniQumtNtbfa8jSP/4 u+Xw== X-Gm-Message-State: AO0yUKXdzopt+7xjQeXkmdEtGk106xpti100Y/j5/G3kfzUHbrZ1vHlI P4QQp2r1klSUj4mroTLiNbsONA== X-Received: by 2002:a05:600c:acb:b0:3ee:4f92:907b with SMTP id c11-20020a05600c0acb00b003ee4f92907bmr26589298wmr.14.1680529762237; Mon, 03 Apr 2023 06:49:22 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id iv19-20020a05600c549300b003ef69873cf1sm19941464wmb.40.2023.04.03.06.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 06:49:21 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 05D4F1FFBB; Mon, 3 Apr 2023 14:49:21 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Reinoud Zandijk , Ryo ONODERA , qemu-block@nongnu.org, Hanna Reitz , Warner Losh , Beraldo Leal , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Kyle Evans , kvm@vger.kernel.org, Wainer dos Santos Moschetta , =?utf-8?q?Alex_Benn?= =?utf-8?q?=C3=A9e?= , Cleber Rosa , Thomas Huth , Kevin Wolf Subject: [PATCH v2 03/11] gdbstub: don't report auxv feature unless on Linux Date: Mon, 3 Apr 2023 14:49:12 +0100 Message-Id: <20230403134920.2132362-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403134920.2132362-1-alex.bennee@linaro.org> References: <20230403134920.2132362-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The later handler if conditionally compiled only for Linux but we forgot to ensure we don't advertise it lest we confuse our BSD brethren. Signed-off-by: Alex Bennée Fixes: 51c623b0de ("gdbstub: add support to Xfer:auxv:read: packet") Reported-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Tested-by: Warner Losh Message-Id: <20230403120250.2071560-1-alex.bennee@linaro.org> --- gdbstub/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 2a66371aa5..0760d78685 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1468,7 +1468,7 @@ static void handle_query_supported(GArray *params, void *user_ctx) ";ReverseStep+;ReverseContinue+"); } -#ifdef CONFIG_USER_ONLY +#if defined(CONFIG_USER_ONLY) && defined(CONFIG_LINUX) if (gdbserver_state.c_cpu->opaque) { g_string_append(gdbserver_state.str_buf, ";qXfer:auxv:read+"); }