| Message ID | 20230418162140.373219-4-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | virtio: add vhost-user-generic and reduce copy and paste | expand |
On 18/04/2023 17:21, Alex Bennée wrote: > Fixes: 544f0278af (virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX) > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > hw/display/vhost-user-gpu.c | 4 ++-- > hw/net/virtio-net.c | 4 ++-- > hw/virtio/vhost-user-fs.c | 4 ++-- > hw/virtio/vhost-user-gpio.c | 2 +- > hw/virtio/vhost-vsock-common.c | 4 ++-- > hw/virtio/virtio-crypto.c | 4 ++-- > 6 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c > index 71dfd956b8..7c61a7c3ac 100644 > --- a/hw/display/vhost-user-gpu.c > +++ b/hw/display/vhost-user-gpu.c > @@ -489,7 +489,7 @@ vhost_user_gpu_guest_notifier_pending(VirtIODevice *vdev, int idx) > > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ > > @@ -506,7 +506,7 @@ vhost_user_gpu_guest_notifier_mask(VirtIODevice *vdev, int idx, bool mask) > > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 53e1c32643..c53616a080 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -3359,7 +3359,7 @@ static bool virtio_net_guest_notifier_pending(VirtIODevice *vdev, int idx) > } > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return false > */ > > @@ -3391,7 +3391,7 @@ static void virtio_net_guest_notifier_mask(VirtIODevice *vdev, int idx, > } > /* > *Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ > > diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c > index 83fc20e49e..49d699ffc2 100644 > --- a/hw/virtio/vhost-user-fs.c > +++ b/hw/virtio/vhost-user-fs.c > @@ -161,7 +161,7 @@ static void vuf_guest_notifier_mask(VirtIODevice *vdev, int idx, > > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ > > @@ -177,7 +177,7 @@ static bool vuf_guest_notifier_pending(VirtIODevice *vdev, int idx) > > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ > > diff --git a/hw/virtio/vhost-user-gpio.c b/hw/virtio/vhost-user-gpio.c > index d6927b610a..3b013f2d0f 100644 > --- a/hw/virtio/vhost-user-gpio.c > +++ b/hw/virtio/vhost-user-gpio.c > @@ -194,7 +194,7 @@ static void vu_gpio_guest_notifier_mask(VirtIODevice *vdev, int idx, bool mask) > > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ > > diff --git a/hw/virtio/vhost-vsock-common.c b/hw/virtio/vhost-vsock-common.c > index d2b5519d5a..623bdf91cc 100644 > --- a/hw/virtio/vhost-vsock-common.c > +++ b/hw/virtio/vhost-vsock-common.c > @@ -129,7 +129,7 @@ static void vhost_vsock_common_guest_notifier_mask(VirtIODevice *vdev, int idx, > > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ > > @@ -146,7 +146,7 @@ static bool vhost_vsock_common_guest_notifier_pending(VirtIODevice *vdev, > > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ > > diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c > index 802e1b9659..6b3e607329 100644 > --- a/hw/virtio/virtio-crypto.c > +++ b/hw/virtio/virtio-crypto.c > @@ -1208,7 +1208,7 @@ static void virtio_crypto_guest_notifier_mask(VirtIODevice *vdev, int idx, > > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ > > @@ -1227,7 +1227,7 @@ static bool virtio_crypto_guest_notifier_pending(VirtIODevice *vdev, int idx) > > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> ATB, Mark.
On Tue, Apr 18, 2023 at 05:21:30PM +0100, Alex Bennée wrote: > Fixes: 544f0278af (virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX) > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > hw/display/vhost-user-gpu.c | 4 ++-- > hw/net/virtio-net.c | 4 ++-- > hw/virtio/vhost-user-fs.c | 4 ++-- > hw/virtio/vhost-user-gpio.c | 2 +- > hw/virtio/vhost-vsock-common.c | 4 ++-- > hw/virtio/virtio-crypto.c | 4 ++-- > 6 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c > index 71dfd956b8..7c61a7c3ac 100644 > --- a/hw/display/vhost-user-gpu.c > +++ b/hw/display/vhost-user-gpu.c > @@ -489,7 +489,7 @@ vhost_user_gpu_guest_notifier_pending(VirtIODevice *vdev, int idx) > > /* > * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 > - * as the Marco of configure interrupt's IDX, If this driver does not > + * as the macro of configure interrupt's IDX, If this driver does not > * support, the function will return > */ The entire comment could be rewritten to make the punctuation and grammar correct, if you want. Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c index 71dfd956b8..7c61a7c3ac 100644 --- a/hw/display/vhost-user-gpu.c +++ b/hw/display/vhost-user-gpu.c @@ -489,7 +489,7 @@ vhost_user_gpu_guest_notifier_pending(VirtIODevice *vdev, int idx) /* * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return */ @@ -506,7 +506,7 @@ vhost_user_gpu_guest_notifier_mask(VirtIODevice *vdev, int idx, bool mask) /* * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return */ diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 53e1c32643..c53616a080 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -3359,7 +3359,7 @@ static bool virtio_net_guest_notifier_pending(VirtIODevice *vdev, int idx) } /* * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return false */ @@ -3391,7 +3391,7 @@ static void virtio_net_guest_notifier_mask(VirtIODevice *vdev, int idx, } /* *Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return */ diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c index 83fc20e49e..49d699ffc2 100644 --- a/hw/virtio/vhost-user-fs.c +++ b/hw/virtio/vhost-user-fs.c @@ -161,7 +161,7 @@ static void vuf_guest_notifier_mask(VirtIODevice *vdev, int idx, /* * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return */ @@ -177,7 +177,7 @@ static bool vuf_guest_notifier_pending(VirtIODevice *vdev, int idx) /* * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return */ diff --git a/hw/virtio/vhost-user-gpio.c b/hw/virtio/vhost-user-gpio.c index d6927b610a..3b013f2d0f 100644 --- a/hw/virtio/vhost-user-gpio.c +++ b/hw/virtio/vhost-user-gpio.c @@ -194,7 +194,7 @@ static void vu_gpio_guest_notifier_mask(VirtIODevice *vdev, int idx, bool mask) /* * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return */ diff --git a/hw/virtio/vhost-vsock-common.c b/hw/virtio/vhost-vsock-common.c index d2b5519d5a..623bdf91cc 100644 --- a/hw/virtio/vhost-vsock-common.c +++ b/hw/virtio/vhost-vsock-common.c @@ -129,7 +129,7 @@ static void vhost_vsock_common_guest_notifier_mask(VirtIODevice *vdev, int idx, /* * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return */ @@ -146,7 +146,7 @@ static bool vhost_vsock_common_guest_notifier_pending(VirtIODevice *vdev, /* * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return */ diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c index 802e1b9659..6b3e607329 100644 --- a/hw/virtio/virtio-crypto.c +++ b/hw/virtio/virtio-crypto.c @@ -1208,7 +1208,7 @@ static void virtio_crypto_guest_notifier_mask(VirtIODevice *vdev, int idx, /* * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return */ @@ -1227,7 +1227,7 @@ static bool virtio_crypto_guest_notifier_pending(VirtIODevice *vdev, int idx) /* * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1 - * as the Marco of configure interrupt's IDX, If this driver does not + * as the macro of configure interrupt's IDX, If this driver does not * support, the function will return */
Fixes: 544f0278af (virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX) Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- hw/display/vhost-user-gpu.c | 4 ++-- hw/net/virtio-net.c | 4 ++-- hw/virtio/vhost-user-fs.c | 4 ++-- hw/virtio/vhost-user-gpio.c | 2 +- hw/virtio/vhost-vsock-common.c | 4 ++-- hw/virtio/virtio-crypto.c | 4 ++-- 6 files changed, 11 insertions(+), 11 deletions(-)