| Message ID | 20230502135741.1158035-10-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tcg: Remove compatability helpers for qemu ld/st | expand |
> -----Original Message----- > From: Richard Henderson <richard.henderson@linaro.org> > Sent: Tuesday, May 2, 2023 8:58 AM > To: qemu-devel@nongnu.org > Cc: mrolnik@gmail.com; edgar.iglesias@gmail.com; Taylor Simpson > <tsimpson@quicinc.com>; ale@rev.ng; anjo@rev.ng; laurent@vivier.eu; > philmd@linaro.org; jiaxun.yang@flygoat.com; david@redhat.com; > iii@linux.ibm.com; thuth@redhat.com; mark.cave-ayland@ilande.co.uk; > atar4qemu@gmail.com; jcmvbkbc@gmail.com > Subject: [PATCH 9/9] tcg: Remove compatability helpers for qemu ld/st > > Remove the old interfaces with the implicit MemOp argument. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > include/tcg/tcg-op.h | 55 -------------------------------------------- > 1 file changed, 55 deletions(-) > > diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h index > dff17c7072..4401fa493c 100644 > --- a/include/tcg/tcg-op.h > +++ b/include/tcg/tcg-op.h > @@ -841,61 +841,6 @@ void tcg_gen_qemu_st_i64(TCGv_i64, TCGv, > TCGArg, MemOp); void tcg_gen_qemu_ld_i128(TCGv_i128, TCGv, TCGArg, > MemOp); void tcg_gen_qemu_st_i128(TCGv_i128, TCGv, TCGArg, MemOp); > > -static inline void tcg_gen_qemu_ld8u(TCGv ret, TCGv addr, int mem_index) > -{ > - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_UB); > -} > - > -static inline void tcg_gen_qemu_ld8s(TCGv ret, TCGv addr, int mem_index) > -{ > - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_SB); > -} > - > -static inline void tcg_gen_qemu_ld16u(TCGv ret, TCGv addr, int > mem_index) -{ > - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TEUW); > -} > - > -static inline void tcg_gen_qemu_ld16s(TCGv ret, TCGv addr, int mem_index) > -{ > - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TESW); > -} > - > -static inline void tcg_gen_qemu_ld32u(TCGv ret, TCGv addr, int > mem_index) -{ > - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TEUL); > -} > - > -static inline void tcg_gen_qemu_ld32s(TCGv ret, TCGv addr, int mem_index) > -{ > - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TESL); > -} > - > -static inline void tcg_gen_qemu_ld64(TCGv_i64 ret, TCGv addr, int > mem_index) -{ > - tcg_gen_qemu_ld_i64(ret, addr, mem_index, MO_TEUQ); > -} > - > -static inline void tcg_gen_qemu_st8(TCGv arg, TCGv addr, int mem_index) - > { > - tcg_gen_qemu_st_tl(arg, addr, mem_index, MO_UB); > -} > - > -static inline void tcg_gen_qemu_st16(TCGv arg, TCGv addr, int mem_index) > -{ > - tcg_gen_qemu_st_tl(arg, addr, mem_index, MO_TEUW); > -} > - > -static inline void tcg_gen_qemu_st32(TCGv arg, TCGv addr, int mem_index) > -{ > - tcg_gen_qemu_st_tl(arg, addr, mem_index, MO_TEUL); > -} > - > -static inline void tcg_gen_qemu_st64(TCGv_i64 arg, TCGv addr, int > mem_index) -{ > - tcg_gen_qemu_st_i64(arg, addr, mem_index, MO_TEUQ); > -} > - > void tcg_gen_atomic_cmpxchg_i32(TCGv_i32, TCGv, TCGv_i32, TCGv_i32, > TCGArg, MemOp); void > tcg_gen_atomic_cmpxchg_i64(TCGv_i64, TCGv, TCGv_i64, TCGv_i64, Is the intent that all loads use tcg_gen_qemu_ld_* and all stores use tcg_gen_qemu_st_*? If so, there are other helpers to remove. For example, tcg_gen_ld32u_i64 tcg_gen_st8_i64 Thanks, Taylor
On 02.05.23 17:39, Taylor Simpson wrote: > > >> -----Original Message----- >> From: Richard Henderson <richard.henderson@linaro.org> >> Sent: Tuesday, May 2, 2023 8:58 AM >> To: qemu-devel@nongnu.org >> Cc: mrolnik@gmail.com; edgar.iglesias@gmail.com; Taylor Simpson >> <tsimpson@quicinc.com>; ale@rev.ng; anjo@rev.ng; laurent@vivier.eu; >> philmd@linaro.org; jiaxun.yang@flygoat.com; david@redhat.com; >> iii@linux.ibm.com; thuth@redhat.com; mark.cave-ayland@ilande.co.uk; >> atar4qemu@gmail.com; jcmvbkbc@gmail.com >> Subject: [PATCH 9/9] tcg: Remove compatability helpers for qemu ld/st >> >> Remove the old interfaces with the implicit MemOp argument. >> >> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> >> --- >> include/tcg/tcg-op.h | 55 -------------------------------------------- >> 1 file changed, 55 deletions(-) >> >> diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h index >> dff17c7072..4401fa493c 100644 >> --- a/include/tcg/tcg-op.h >> +++ b/include/tcg/tcg-op.h >> @@ -841,61 +841,6 @@ void tcg_gen_qemu_st_i64(TCGv_i64, TCGv, >> TCGArg, MemOp); void tcg_gen_qemu_ld_i128(TCGv_i128, TCGv, TCGArg, >> MemOp); void tcg_gen_qemu_st_i128(TCGv_i128, TCGv, TCGArg, MemOp); >> >> -static inline void tcg_gen_qemu_ld8u(TCGv ret, TCGv addr, int mem_index) >> -{ >> - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_UB); >> -} >> - >> -static inline void tcg_gen_qemu_ld8s(TCGv ret, TCGv addr, int mem_index) >> -{ >> - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_SB); >> -} >> - >> -static inline void tcg_gen_qemu_ld16u(TCGv ret, TCGv addr, int >> mem_index) -{ >> - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TEUW); >> -} >> - >> -static inline void tcg_gen_qemu_ld16s(TCGv ret, TCGv addr, int mem_index) >> -{ >> - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TESW); >> -} >> - >> -static inline void tcg_gen_qemu_ld32u(TCGv ret, TCGv addr, int >> mem_index) -{ >> - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TEUL); >> -} >> - >> -static inline void tcg_gen_qemu_ld32s(TCGv ret, TCGv addr, int mem_index) >> -{ >> - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TESL); >> -} >> - >> -static inline void tcg_gen_qemu_ld64(TCGv_i64 ret, TCGv addr, int >> mem_index) -{ >> - tcg_gen_qemu_ld_i64(ret, addr, mem_index, MO_TEUQ); >> -} >> - >> -static inline void tcg_gen_qemu_st8(TCGv arg, TCGv addr, int mem_index) - >> { >> - tcg_gen_qemu_st_tl(arg, addr, mem_index, MO_UB); >> -} >> - >> -static inline void tcg_gen_qemu_st16(TCGv arg, TCGv addr, int mem_index) >> -{ >> - tcg_gen_qemu_st_tl(arg, addr, mem_index, MO_TEUW); >> -} >> - >> -static inline void tcg_gen_qemu_st32(TCGv arg, TCGv addr, int mem_index) >> -{ >> - tcg_gen_qemu_st_tl(arg, addr, mem_index, MO_TEUL); >> -} >> - >> -static inline void tcg_gen_qemu_st64(TCGv_i64 arg, TCGv addr, int >> mem_index) -{ >> - tcg_gen_qemu_st_i64(arg, addr, mem_index, MO_TEUQ); >> -} >> - >> void tcg_gen_atomic_cmpxchg_i32(TCGv_i32, TCGv, TCGv_i32, TCGv_i32, >> TCGArg, MemOp); void >> tcg_gen_atomic_cmpxchg_i64(TCGv_i64, TCGv, TCGv_i64, TCGv_i64, > > > Is the intent that all loads use tcg_gen_qemu_ld_* and all stores use tcg_gen_qemu_st_*? > > If so, there are other helpers to remove. For example, > tcg_gen_ld32u_i64 > tcg_gen_st8_i64 At least the patch description + cover letter talks about "helpers for qemu ld/st", so these two would not fall into the context of this patch (and series). Acked-by: David Hildenbrand <david@redhat.com>
diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h index dff17c7072..4401fa493c 100644 --- a/include/tcg/tcg-op.h +++ b/include/tcg/tcg-op.h @@ -841,61 +841,6 @@ void tcg_gen_qemu_st_i64(TCGv_i64, TCGv, TCGArg, MemOp); void tcg_gen_qemu_ld_i128(TCGv_i128, TCGv, TCGArg, MemOp); void tcg_gen_qemu_st_i128(TCGv_i128, TCGv, TCGArg, MemOp); -static inline void tcg_gen_qemu_ld8u(TCGv ret, TCGv addr, int mem_index) -{ - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_UB); -} - -static inline void tcg_gen_qemu_ld8s(TCGv ret, TCGv addr, int mem_index) -{ - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_SB); -} - -static inline void tcg_gen_qemu_ld16u(TCGv ret, TCGv addr, int mem_index) -{ - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TEUW); -} - -static inline void tcg_gen_qemu_ld16s(TCGv ret, TCGv addr, int mem_index) -{ - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TESW); -} - -static inline void tcg_gen_qemu_ld32u(TCGv ret, TCGv addr, int mem_index) -{ - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TEUL); -} - -static inline void tcg_gen_qemu_ld32s(TCGv ret, TCGv addr, int mem_index) -{ - tcg_gen_qemu_ld_tl(ret, addr, mem_index, MO_TESL); -} - -static inline void tcg_gen_qemu_ld64(TCGv_i64 ret, TCGv addr, int mem_index) -{ - tcg_gen_qemu_ld_i64(ret, addr, mem_index, MO_TEUQ); -} - -static inline void tcg_gen_qemu_st8(TCGv arg, TCGv addr, int mem_index) -{ - tcg_gen_qemu_st_tl(arg, addr, mem_index, MO_UB); -} - -static inline void tcg_gen_qemu_st16(TCGv arg, TCGv addr, int mem_index) -{ - tcg_gen_qemu_st_tl(arg, addr, mem_index, MO_TEUW); -} - -static inline void tcg_gen_qemu_st32(TCGv arg, TCGv addr, int mem_index) -{ - tcg_gen_qemu_st_tl(arg, addr, mem_index, MO_TEUL); -} - -static inline void tcg_gen_qemu_st64(TCGv_i64 arg, TCGv addr, int mem_index) -{ - tcg_gen_qemu_st_i64(arg, addr, mem_index, MO_TEUQ); -} - void tcg_gen_atomic_cmpxchg_i32(TCGv_i32, TCGv, TCGv_i32, TCGv_i32, TCGArg, MemOp); void tcg_gen_atomic_cmpxchg_i64(TCGv_i64, TCGv, TCGv_i64, TCGv_i64,
Remove the old interfaces with the implicit MemOp argument. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- include/tcg/tcg-op.h | 55 -------------------------------------------- 1 file changed, 55 deletions(-)