From patchwork Wed May 24 10:27:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Juszkiewicz X-Patchwork-Id: 685332 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp168862wrt; Wed, 24 May 2023 03:29:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Th/ziTwuaYWsNcqapKBSXpC9rS9vsLes2quCYM51czmpLkv2k2MC7aeF7rc1BpPPtG9qU X-Received: by 2002:a05:622a:44:b0:3f5:2788:8adb with SMTP id y4-20020a05622a004400b003f527888adbmr26109065qtw.7.1684924152129; Wed, 24 May 2023 03:29:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684924152; cv=none; d=google.com; s=arc-20160816; b=zkE2Su5er9jDa3BkIaHOTrkGfGH2nsARw1o1haL3qxgyE85mASY3C0yuk8JBENRSTB rCkZ8hbjitWBYF6bWcxmP07E6JGmxBdg4u82kx4YzdCB7tfobImy85oq/GdLUzDLEtp+ wQFW7Xw196QqPShshEGKMsqZgYQBXveG8qXCDYRTpTV+/xh4ibpWogLm2KTR4EI0Fr39 Znsu5CuvH1h4kEA3upwf0okgMWTG140o9zaW18j+JwA9kY1AaHDpEGHGD0g9eBIRx/wH YAfs2FFWJcMMmfTK26iPf+x4c9Q8H6K5ayPn3PreVKZ6GEOAtuJqjNoruUcQd13dOiO6 7B/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=RFl0lkku0rEx44cSL97n6ibaCEcLL6BIlhLypm/82Mw=; b=WgobBm5SsM+pdoHxC4L/TnKSb1fHopSBb/IIootivKKEDeJB4rb61lWFPbelAh+wPT 1XeHHhpMp3h2HgIPPN9pIAqbUyIqKZF/z+y8N+5fyUJj0Np2pZS7Ukdd3wbi+k3osptX 0mAn8h5Z3meQxnFtSwmcjOWEh0HFT/qeHpWz97B2VE3IDUMrEDvqsBqeT8yxAvS+mADG VvoiGnT2lTQ4Cck894lBLx/pdLaNGnq7H8NIMkRkp5xQ7K3EP+PH2BMUP2ZDps/b+NXJ ADx90m2oMTSD26Hg3xB5eKcUDRdZNYRZMpBQ/XlZUkgUotQJZNeXIYyUWT3irtu1xA0y 9NAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r11-20020ac85c8b000000b003f52d2f1237si6630536qta.520.2023.05.24.03.29.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 May 2023 03:29:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1lio-0007zd-Ce; Wed, 24 May 2023 06:27:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1lia-0007ro-Pd; Wed, 24 May 2023 06:27:46 -0400 Received: from muminek.juszkiewicz.com.pl ([213.251.184.221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1liX-0000Oy-RG; Wed, 24 May 2023 06:27:44 -0400 Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id 303072609C0; Wed, 24 May 2023 12:27:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at juszkiewicz.com.pl Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D3nAMwFrj-Jh; Wed, 24 May 2023 12:27:38 +0200 (CEST) Received: from applejack.lan (83.21.125.167.ipv4.supernova.orange.pl [83.21.125.167]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id 01221260BBC; Wed, 24 May 2023 12:27:35 +0200 (CEST) From: Marcin Juszkiewicz To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Leif Lindholm , Peter Maydell , Thomas Huth , Paolo Bonzini , Marcin Juszkiewicz Subject: [PATCH v3 4/5] hw/arm/sbsa-ref: add gfx card only if we have pci Date: Wed, 24 May 2023 12:27:28 +0200 Message-Id: <20230524102729.810892-5-marcin.juszkiewicz@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230524102729.810892-1-marcin.juszkiewicz@linaro.org> References: <20230524102729.810892-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Received-SPF: softfail client-ip=213.251.184.221; envelope-from=marcin.juszkiewicz@linaro.org; helo=muminek.juszkiewicz.com.pl X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Creation of network card is guarded with check do we have pci bus. Do the same with graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index c540b2f1ba..9a3d77d6b6 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-ref.c @@ -647,10 +647,10 @@ static void create_pcie(SBSAMachineState *sms) pci_nic_init_nofail(nd, pci->bus, nd->model, NULL); } - } - if (vga_interface_type != VGA_NONE) { - pci_create_simple(pci->bus, -1, "bochs-display"); + if (vga_interface_type != VGA_NONE) { + pci_create_simple(pci->bus, -1, "bochs-display"); + } } create_smmu(sms, pci->bus);