From patchwork Tue May 30 18:59:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 686899 Delivered-To: patch@linaro.org Received: by 2002:a5d:4d8a:0:0:0:0:0 with SMTP id b10csp894618wru; Tue, 30 May 2023 12:04:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ60dapqu5iTxFKj1yJz08C+B+fwO3ocG+DS8OPQ9KmAd8kO/RmQ+U5W6vygN6NVIrfE/buV X-Received: by 2002:a05:620a:8a8b:b0:75b:23a1:8e3f with SMTP id qu11-20020a05620a8a8b00b0075b23a18e3fmr2695998qkn.16.1685473469614; Tue, 30 May 2023 12:04:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685473469; cv=none; d=google.com; s=arc-20160816; b=bFtOynQ52Pl2+Am8XJmXwysoKoLmZyGBOCOne8pHzFUK9ttiMIhVj45gXK6yLBGQEd 4S6SazNGDpz9rYo5KRHb8pEFJtviVTqZT+socQ2N+A3UsuBDylz3SBVhMHLwllJ81i67 GA+MviBOT4BVIg/etuN6xtNID3EGdL0NvQ5ymUoGoedxvnipoX+NlHUVHa32bPXxqDcR rdB/9YJ6LUof920WGsHX5nd/lDNl3Em+KQF7s0KdlEJj2fKkK8S/K4/Ubjy2qor4aiM4 SI3UeNmWbx6Oa+J9kqlb439vWtQilX48Faj2pR1gRwlyYLcU0qic1XGKTkkrP0GKbngR pBHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cRUS/B+lej6ghv4TKHMjTIjQnBzjJiFZ+pCmPDNBTdA=; b=HPoANG8OfKNyH4DjmFvU+TBWQdSUC5NWeOOMYuuQuvuDpz5ePkBI+xE84zhkHDdrU1 TxTsr/m2pf68eNnza0CzCVeQsMTbHcyNBsAEuKL8/vtTEO2QCUh+VGYANSaoenJRR4Cz cJ6/0y+XzzXTTsVlwDY9ZS6Neu8t7r+5FUoeBc1Pxv+sG5/TlT4D75EIQqSf+mVw51BD 9tiuNBnlrwKMByG7C63Hj8+WWMxigGtNTE5ycxPT8V9FUk1ck5x+ygVanaS0VFseX17f B5CXgYk0aIfvxh0ouNJBhuVMqI0NGuEcSOCA2BQQNuTOEwYxaeD5Iigew555F0oZQWgO ZoNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mjhx9WFj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id dt52-20020a05620a47b400b007592f7bb31asi6712374qkb.275.2023.05.30.12.04.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 May 2023 12:04:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mjhx9WFj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q44Zq-0000s2-If; Tue, 30 May 2023 15:00:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q44ZW-0000kf-RM for qemu-devel@nongnu.org; Tue, 30 May 2023 14:59:54 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q44ZV-0000sH-D9 for qemu-devel@nongnu.org; Tue, 30 May 2023 14:59:54 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-64d577071a6so5632288b3a.1 for ; Tue, 30 May 2023 11:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685473192; x=1688065192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cRUS/B+lej6ghv4TKHMjTIjQnBzjJiFZ+pCmPDNBTdA=; b=mjhx9WFjfV5cNMTRqD6D84+JeNCnrRWJa9x5TCjd+UIXpM9XHWMsDuT87YDk7JOEhd DTfVI5KMBRJxzyXi6qRlLqkK+3e5VF4W2i/sKo6LOZ3u2Jl3/0Zcw8JfMPRrpbrU+n/o ao/qSv4hDiNV29fkQVqMCLQdi695tgZsd0iyDcMz0Q05NS0Pju8OF+kb+qEVUxusfJHV L2VIOmOeZlnWflkgEX6D1W3kNX+bPoYK2W4iHPoQSV2t1ptKjAg1ZCiIIP55kcK3ptFq bFFq7bY+k+bvZivW6WiVRg4ZM2uMKyClqeMDZcP2H38sad9XdohyiUwqJwTnlUJErkKm x5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685473192; x=1688065192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cRUS/B+lej6ghv4TKHMjTIjQnBzjJiFZ+pCmPDNBTdA=; b=I3Xe/rYtc7czTzQqV3+Ef4+9gEj9iCZGN5j6I7LIrPBSl7toR3/c4TLW8Dq+NY3bOt lTLZbXnTw7hwT0Xy4KQwyKZXAc2FFOhFAk9HIAOaib+96oFKW81V5lXf2Y7oZUgHNqj6 pgDBh7Jcziag2EdWwZMQTJicpwbHMaByRf0XGMhm6nxnAybamnx0jmIdJe4AL9AEdlhO 5QM3T63R3iXZx/4fgyRZyIrsJyKjOQoiSjFFMR986JJmTeivQLh158xZkbNRLfLzkwpz enj/KQe/Z63rV2XtNrUSOmk7uxqHjdCGEetSEJSe1+kuPQWjSHs+ekx881hgKGHWThnv T++g== X-Gm-Message-State: AC+VfDzrOJFB/H+wWf+k1yWraLysN44IMCvOPLFmXbF+wjrcFUmMekkE 3jRWPqyNDNHKu86xVmLFFFXEgyR6UMHPUq16e20= X-Received: by 2002:a05:6a20:a386:b0:10c:dd4f:faa9 with SMTP id w6-20020a056a20a38600b0010cdd4ffaa9mr2750980pzk.14.1685473191835; Tue, 30 May 2023 11:59:51 -0700 (PDT) Received: from stoup.. ([2602:ae:1598:4c01:35a2:c45d:7485:f488]) by smtp.gmail.com with ESMTPSA id g18-20020a63fa52000000b0051f14839bf3sm9128496pgk.34.2023.05.30.11.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 11:59:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Peter Maydell Subject: [PULL 01/27] tcg: Fix register move type in tcg_out_ld_helper_ret Date: Tue, 30 May 2023 11:59:23 -0700 Message-Id: <20230530185949.410208-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230530185949.410208-1-richard.henderson@linaro.org> References: <20230530185949.410208-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The first move was incorrectly using TCG_TYPE_I32 while the second move was correctly using TCG_TYPE_REG. This prevents a 64-bit host from moving all 128-bits of the return value. Fixes: ebebea53ef8 ("tcg: Support TCG_TYPE_I128 in tcg_out_{ld,st}_helper_{args,ret}") Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- tcg/tcg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index ac30d484f5..2352ca4ade 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -5736,8 +5736,8 @@ static void tcg_out_ld_helper_ret(TCGContext *s, const TCGLabelQemuLdst *ldst, mov[0].dst = ldst->datalo_reg; mov[0].src = tcg_target_call_oarg_reg(TCG_CALL_RET_NORMAL, HOST_BIG_ENDIAN); - mov[0].dst_type = TCG_TYPE_I32; - mov[0].src_type = TCG_TYPE_I32; + mov[0].dst_type = TCG_TYPE_REG; + mov[0].src_type = TCG_TYPE_REG; mov[0].src_ext = TCG_TARGET_REG_BITS == 32 ? MO_32 : MO_64; mov[1].dst = ldst->datahi_reg;