From patchwork Mon Jun 5 20:15:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 689228 Delivered-To: patch@linaro.org Received: by 2002:a5d:4d8a:0:0:0:0:0 with SMTP id b10csp2285405wru; Mon, 5 Jun 2023 13:17:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6BbYbmJlquoNe/isOWecBt1Eb9ey0G+wxsQ9x0q/m/HzPU9+e8qI52VaulsA9aaXzl0GV3 X-Received: by 2002:a05:6214:c88:b0:625:aa1a:937a with SMTP id r8-20020a0562140c8800b00625aa1a937amr8634986qvr.54.1685996242829; Mon, 05 Jun 2023 13:17:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685996242; cv=none; d=google.com; s=arc-20160816; b=S/HDoz9EYzvASP9ygE/c7oSi8Rl060OEyFaja2vOuIHG6TlNcafTNg0x4BHdUM5UFz TqAqSiG3FWm5O4H8oqt0rmp49ZVPOILtOyjGWO9knUstR2mrGpeiIlo2WA4PWdUC9rg4 hesJbW8WCil9wmR3uqpiacgSTFMsJPVcF4IaODRcudPLL4NkvfcbrzeR5yZw0DOQpztQ K5Q8grCyK5O5hII0aTNLoZjgFACi1sVq6YbCm1IoDQn6RmnFX+Sac65Wlx50KAMatyK/ hoR0TFpqBZ/JfUdzhjvcceJd4Kfvyybyt5Piq5oknUKunV9dRNtQuMFdQ+qX6lqIOCnY iwbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5rPTbSJPGH0y4Jg73winpnz5u/arUPeju4H53hE/UCY=; b=AWBIh5ZhGuKaDFbQOx1Ld5I8S4wj/kBXObjVmlPYwsNJmmX+YlWvoLwDZf+drw4nm6 XOGljzi+Mrww1bxKfAqDguUs6QeFF9CAC+vViRMPpEEus1JW2UyI+w1X7oHubYCxqLve i1VM1bo2ei3gZBNSKfGp067MeRMMMWXuAJL+J9DQZjbLRkr3S335AucbGXhe1DBXVDxR it2pj/vzb3MlTelSc5ekZVKmcx+TBqGlM4xbwaBwS99LDnJpPCjOnmUHjem6JfrOLTls Bz0RyC2k8AQi0DQWwp1xTte1CN3n54Buy7wYs1jZcEQ0pE57+tyGyiJEKmmvohYkY2D+ P9nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tIG85Yix; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id gs14-20020a056214226e00b005ef58991bebsi5182659qvb.530.2023.06.05.13.17.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Jun 2023 13:17:22 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tIG85Yix; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6Gd9-00029l-PV; Mon, 05 Jun 2023 16:16:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6Gcs-0001xk-Fw for qemu-devel@nongnu.org; Mon, 05 Jun 2023 16:16:26 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6Gcq-0003nm-LD for qemu-devel@nongnu.org; Mon, 05 Jun 2023 16:16:26 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-650c8cb68aeso3084716b3a.3 for ; Mon, 05 Jun 2023 13:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685996182; x=1688588182; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5rPTbSJPGH0y4Jg73winpnz5u/arUPeju4H53hE/UCY=; b=tIG85YixUtxsTJ/6bY1XfZ/jlwG1I2G6pBtjeUjgPfux6qxf0UfYMPfB8+bS7+j+cS er5TrZq9nLmieAM9/12Mhxbo3oLUzQBwnBoUzknbdE89OzQmYnNUZSKyoTsaEusqk1vE 3WUDiwleU6CRWiXaMOdo/kXvscrI123TSx+0BY+P0B1ZC4aJ8mZtCaaW3aI8mrIclRDG HHhyhJdGCqZz6mEnSKN2+8arVt4CU6+md/oWJCciIOwYwf5NnKcKui46XBlZ+w2XDK+/ zXBD1mb6ZFUnxvwKF1GkoD/VKVxJOlUYURyUcHUAYlb4QLXM7dEYLK1mq0GU7JfL++g+ tIzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685996182; x=1688588182; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5rPTbSJPGH0y4Jg73winpnz5u/arUPeju4H53hE/UCY=; b=RDFQI9pGMeIULGClxjQV0F9ufDHx67E/sJIrues7Azv0xfGqI5DnQRQ+1J8klx63nC 4t2u74+aAfKjyKX65bKEHLHWrBsRrauCy8vkpxq+i37ngi8t2Q8KtMwJbuKEI0sTYQtr Vn6aVV+kedGpTGNYMgoCAQQ/hpAFN8+WZW38dS9oO53mZuJunubTeplUe2HPbuY+FWGs +/Ja/QYiKpD0EpE+gXjbE8Bj4/RSIhqnpxTxaIanpsXwFvu5WmX4BTALJeSSHpTKL9UW AC2vEIAXNkpq3npEHQ5uv7twIF4Yuww0DaVMgO8pCYj4/nY2cyUz9ujVrXENewhVLUxQ Nsig== X-Gm-Message-State: AC+VfDzX90Uzywk25zP/Jfac/PS5U9puUKYGh6ojRcBRk2uV/h4OcB6z HXj+3uo/OsYnxw5vbltx54IftF2aqNsZJz92ujs= X-Received: by 2002:a05:6a20:e18f:b0:114:7236:9777 with SMTP id ks15-20020a056a20e18f00b0011472369777mr129779pzb.21.1685996182679; Mon, 05 Jun 2023 13:16:22 -0700 (PDT) Received: from stoup.. ([2602:ae:1598:4c01:3f85:a600:6a3e:e465]) by smtp.gmail.com with ESMTPSA id f18-20020aa78b12000000b0064d32771fa8sm5552924pfd.134.2023.06.05.13.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 13:16:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 38/52] accel/tcg: Move translator_fake_ldb out of line Date: Mon, 5 Jun 2023 13:15:34 -0700 Message-Id: <20230605201548.1596865-39-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230605201548.1596865-1-richard.henderson@linaro.org> References: <20230605201548.1596865-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This is used by exactly one host in extraordinary circumstances. This means that translator.h need not include plugin-gen.h; translator.c already includes plugin-gen.h. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/exec/translator.h | 8 +------- accel/tcg/translator.c | 5 +++++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/include/exec/translator.h b/include/exec/translator.h index c1a1203789..228002a623 100644 --- a/include/exec/translator.h +++ b/include/exec/translator.h @@ -22,7 +22,6 @@ #include "qemu/bswap.h" #include "exec/exec-all.h" #include "exec/cpu_ldst.h" -#include "exec/plugin-gen.h" #include "exec/translate-all.h" #include "tcg/tcg.h" @@ -229,12 +228,7 @@ translator_ldq_swap(CPUArchState *env, DisasContextBase *db, * re-synthesised for s390x "ex"). It ensures we update other areas of * the translator with details of the executed instruction. */ - -static inline void translator_fake_ldb(uint8_t insn8, abi_ptr pc) -{ - plugin_insn_append(pc, &insn8, sizeof(insn8)); -} - +void translator_fake_ldb(uint8_t insn8, abi_ptr pc); /* * Return whether addr is on the same page as where disassembly started. diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index 7a130e706e..60a613c99d 100644 --- a/accel/tcg/translator.c +++ b/accel/tcg/translator.c @@ -345,3 +345,8 @@ uint64_t translator_ldq(CPUArchState *env, DisasContextBase *db, abi_ptr pc) plugin_insn_append(pc, &plug, sizeof(ret)); return ret; } + +void translator_fake_ldb(uint8_t insn8, abi_ptr pc) +{ + plugin_insn_append(pc, &insn8, sizeof(insn8)); +}