From patchwork Fri Jun 23 12:20:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 695248 Delivered-To: patch@linaro.org Received: by 2002:adf:e885:0:0:0:0:0 with SMTP id d5csp1924002wrm; Fri, 23 Jun 2023 05:31:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ40hnXVGEXCr1ACrPQdPdRI9lXx39RBY/ExXFR4xj5PL5+PvY1kBCjh8f7VXt3738i/dNPV X-Received: by 2002:a05:620a:22e8:b0:762:4657:57a9 with SMTP id p8-20020a05620a22e800b00762465757a9mr15577652qki.1.1687523510705; Fri, 23 Jun 2023 05:31:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687523510; cv=none; d=google.com; s=arc-20160816; b=xMCNMdYJqrp+UUEaNViu21gR8yTYC+OaDJcOrsG//PPLnnqa+M/UNGxHl0oIwRSBTG dQs5iY/mzNCcPVEZi+P58WIxXkr3Jhuv7WXuZcs/woWAVFWSa+0FBL4eFY9Mq/Exvt5s FUIu9PVBLCrXtpeo0rNG9KV/LU6CwxX8k15JOpDwL1vusqS5NQdQj93kBYQ9UaVqHqRZ rs9F/Qgpgmztdp8evSkkiaC6Xv+YvLFpre0CcayEP1pjimavePbVAbNI09vQou3Apz/P WQeTI1Fc3JTuZvO2as1KVvjKOSSclfcbjm12bVAY9KlHJXFpfccAYSSFbjVaVi0+2w17 9Rww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/lZ58MHVs7VVcDhLDA+codKww1SNsRkU8Vn2ofdw4A8=; b=AxeNK+LVYEfEC9S9S91g1/RSYBeecwNpkr6QHTYe7r3IqZ6KDCz9lyFeVgHC1Qxvr0 +YUe9IEcXToa1DHd5A48YLHROqj44jqsC70c4xxWCEE6I5zTc/zRcZsQDXsapY+E6dPy RUGLh/rX4es+N1Exr7VZIWZ6McJC7ml/SZIQfT5+layrbaR4b6ZNrPGzYThrr6T6RDfy +grMABiq3KHYoExD8c2bKR4SNhdryIxO/BILm45Ed+2mwNrs8TZt9zFKUTLi7N0xq6Xo DqkjFjb+vNF7w0TfjezDWRFbZUIhwy/V5EaRnq5BstYtUlaKG2iGSh8CdT8BL7BZ+Q/4 tRpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XSqIJteZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j12-20020a05620a000c00b00763dd7ab3d1si1934476qki.471.2023.06.23.05.31.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Jun 2023 05:31:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XSqIJteZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCfwU-0001Cp-Dp; Fri, 23 Jun 2023 08:31:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCfwE-00018v-5s for qemu-devel@nongnu.org; Fri, 23 Jun 2023 08:30:55 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCfwB-0000Sw-3u for qemu-devel@nongnu.org; Fri, 23 Jun 2023 08:30:53 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-31129591288so571631f8f.1 for ; Fri, 23 Jun 2023 05:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687523449; x=1690115449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/lZ58MHVs7VVcDhLDA+codKww1SNsRkU8Vn2ofdw4A8=; b=XSqIJteZOMQV1Jwrm7ChEhfzxCaxgq+bxtHm2yPKMUz3H34yqD887cwrFG1szKNQsl CANqxVPCUDqHZGfIX8xGZKnm5IjCLHpj9ykq5aNqyPU945dlm15J0Cp5+Bxnv/5/UVTE l8TRtY2viRzxV7qyZ5lVKirMTRWSR4gD0Eb9Rymuiazv1k6VKtDI0ngzPB+vzwdGHOin 3G+j1IOG4tXHAnTY3iQfqo6I50pOf+DegwVWlfC9YZ99dhSHttNTybsjgqGN4BNWAJYQ BFu5577xL1hSN2kDfeHlSgnwkhfe/6Pc59hnLbHWNwulQMFteNjSRJAkDJzu/pJF9OSn Rxpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687523449; x=1690115449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/lZ58MHVs7VVcDhLDA+codKww1SNsRkU8Vn2ofdw4A8=; b=f0ciuWperg1bWAK57M6/1EusLbkXeBDb04Yf/utUBIvye+hlV5dYVZqNSSUmcpROAD YHLzBdkM6nWE/YEyIzoIr+hHvVB2fCBV15SXvzUFNLsBlDD5b3wHlj/0V5FjlvecQFmK 2aDVN1qrba5+UQPGGneb52GYHSxSN7ObGEQXhhQp4n6u7z/geEI9k4DDgNJdziCxk4kW wUtJDWMgX0hfQZa+HR+OSJO/f3W2PBh6j+UoM93M6dopbd9zOda9xOTS6fGUmt0rIakS /Nko44UTdyu3ZpsyNxvPyFgD6NTxQf0qbrGfacJ5FtcRQnu+daiCZzA3GkO2PvVYj/KI MNqw== X-Gm-Message-State: AC+VfDxO6/qVkzQMYn+TFCGxztWqV787lOrKi+Z/rvNveZb3esPv/uDD 241fPehKDxWHp7sTPx3I2TJf0g== X-Received: by 2002:adf:ee4e:0:b0:309:49e3:efb4 with SMTP id w14-20020adfee4e000000b0030949e3efb4mr14037477wro.63.1687523449292; Fri, 23 Jun 2023 05:30:49 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id j18-20020adff012000000b0030e56a9ff25sm9484366wro.31.2023.06.23.05.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 05:30:49 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 34A091FFCC; Fri, 23 Jun 2023 13:21:03 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Juan Quintela , Peter Maydell , Cleber Rosa , Darren Kenny , Alexandre Iooss , Peter Xu , qemu-arm@nongnu.org, Eduardo Habkost , Riku Voipio , Mahmoud Mandour , =?utf-8?q?Daniel_P=2E_Berrang?= =?utf-8?q?=C3=A9?= , Paolo Bonzini , Bandan Das , Marcin Juszkiewicz , Radoslaw Biernacki , Alexander Bulekov , Leif Lindholm , Qiuhao Li , Wainer dos Santos Moschetta , Marcel Apfelbaum , Leonardo Bras , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Bin Meng , Thomas Huth , Beraldo Leal , Laurent Vivier , Yanan Wang , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH 22/26] include/migration: mark vmstate_register() as a legacy function Date: Fri, 23 Jun 2023 13:20:56 +0100 Message-Id: <20230623122100.1640995-23-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230623122100.1640995-1-alex.bennee@linaro.org> References: <20230623122100.1640995-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Mention that QOM-ified devices already have support for registering the description. Reviewed-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Acked-by: Peter Xu Signed-off-by: Alex Bennée Message-Id: <20230619171437.357374-3-alex.bennee@linaro.org> --- include/migration/vmstate.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 084f5e784a..35579b2c1f 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -1209,7 +1209,14 @@ int vmstate_register_with_alias_id(VMStateIf *obj, uint32_t instance_id, int required_for_version, Error **errp); -/* Returns: 0 on success, -1 on failure */ +/** + * vmstate_register() - legacy function to register state serialisation description + * + * New code shouldn't be using this function as QOM-ified devices have + * dc->vmsd to store the serialisation description. + * + * Returns: 0 on success, -1 on failure + */ static inline int vmstate_register(VMStateIf *obj, int instance_id, const VMStateDescription *vmsd, void *opaque)