From patchwork Mon Jul 31 14:15:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 708411 Delivered-To: patch@linaro.org Received: by 2002:a5d:6787:0:b0:317:2194:b2bc with SMTP id v7csp2330173wru; Mon, 31 Jul 2023 07:16:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlHJfVUgSVLpELjbqEc2mO/YVxkK2y9nDSONuLaynC3ZQVEhq9/IZt48BRxvilYcGCSrn/3K X-Received: by 2002:a0c:aa17:0:b0:632:30e:314 with SMTP id d23-20020a0caa17000000b00632030e0314mr9387532qvb.44.1690812986150; Mon, 31 Jul 2023 07:16:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690812986; cv=none; d=google.com; s=arc-20160816; b=jW7lHCznMMqW3pKyGwvUKdLvjThjRQ4W2OfhLItc90dhNWihICAQlOfisZtgig1yUq xvd7LYvfRMlfXrq661bKVSVHbsWKXHbDqx7HdO/btecD+ErERwAwFQ46cvvqn0hVkCZr g2r/tZPBTh5oKms1qbC3G/QP6K4/j6j06H13yLWXeyAeoez352i0bcxSCdEwA4Z7RG4A JvUdy8uGFxuAIskByWsPE22WSdsZKlYb4M5NFBwVonL+OA1XGv0/gTQU7OXDDrmMb1Uq kOG34MDtYndgkcdgDdMnDZ91rfO6weCLptPAHOokeqHdGGWiM7AyXyesp23m5yTP0owA GHtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=IRJJsXiQGVscOzwBrvnsqBjJfHH56GzCgg2J9O7gwx0=; fh=bFDrUYhlTVi/QyetgXx/byg2+yO/22Hp9SjwoefyKLk=; b=CQ4kxVFw7Id3xW2lqjMKCOpQ2IMKTUAH4l7rEg4Pobms8/BbZd2OsgUxunTzcFT32R cSaxA0Hm56RAG5EIjNH7GASUnxWN2cqJgPT7oyAUULQqkniaEOuvtfSbILrOGuP3JVvq To78MYC2bX+R9qEBlZMwEy2iUNm0DZQU/dXmEar0P8AN8udUPEVDt+OjjrKjpijiMBK4 8LJtJ9WU+zP2RPyikn/wyRv8tzEhZWpcq5SzXlk+/5ah3Ky+7uExLqLHRdXfNObxOIQ3 4K6bovNvvypAfWaNOr4yWZh3fOEnjTcs0UmLU7mqgz68x2eHCLdMIKNsLtH8jG80bk2U z4AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uxeB1Zzk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o2-20020a375a02000000b0076ca1b8aaf6si2684903qkb.634.2023.07.31.07.16.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 31 Jul 2023 07:16:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uxeB1Zzk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQTgY-0005a3-7V; Mon, 31 Jul 2023 10:15:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQTgS-0005WX-Go for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:40 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQTgP-0007eT-Pi for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:40 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fbc5d5746cso49716645e9.2 for ; Mon, 31 Jul 2023 07:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690812936; x=1691417736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=IRJJsXiQGVscOzwBrvnsqBjJfHH56GzCgg2J9O7gwx0=; b=uxeB1ZzkopKK73UMeuz+c3AxaygULbEBZEGT7Pyfuwmdu+TqS/mtrbPzKjBJKpuBHG IUI9y6oQw3z08sgSqf1tfMJ3QPNq+yagO18HhLWSWcdprtedSLqTm4oy2WCiAEUSsPEv FHa+gGBRR1c08SqV6WdqnMXoY3X84x4OIQx9ijKMJV3hDs3cizqOAptu0BpMU8vsuIaU ZoxWX0VUMFkCkwXGk6b+X2YqlT8eQTR5RnuNhb7FXGZmtVEq1chCyKWYgmqJC6F4d6Dy 8oiZ4KV3tBrMkAikbidCcbkB7GZ8iLI6cDmjB6xBVv3tgzeoPsu6kEmTH10YXJFKHvTZ 5B1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690812936; x=1691417736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IRJJsXiQGVscOzwBrvnsqBjJfHH56GzCgg2J9O7gwx0=; b=MhR//X9ntfC2YuvnbC5zxadsua7qNJAXYPHmhxm3/6uVTRgCkjBxiJg4s2/fPQQgpc OEexS4I9Zo5BOzjIwffcAl+KZEwBXv4DSRz0EP6chPVAFeoSSRu1Wz8bc1rInZnvvin+ ekdEj8xcD3uXSypPEa+lG/CfvX3HsXY985c/18JA7g5CnSUsXsH3+7JBp3VK4uAWN2KV NrAH6FjGhBLhxtNdKw4p805dnrCYeIdbZd/Kox+/R3ZeIMsoU1LS4INW7CkEvKlZfDjx fjc7ShlUldN/LzwkveqyD4CIkdbomc583KRFiNaKpdHCd1kK8Q3WQj7YltdT8sc3whLD Hh5w== X-Gm-Message-State: ABy/qLb2fXz6dUNb5IaF2wLcsXa8ubDKtFsf3Q/xe3mTijl6FfxYuJ3c wsfLB6AEWmkTHCvYTzaNjxGlqllqTLgG+UmwKto= X-Received: by 2002:a7b:cb86:0:b0:3fa:9538:963e with SMTP id m6-20020a7bcb86000000b003fa9538963emr37649wmi.36.1690812936227; Mon, 31 Jul 2023 07:15:36 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id z15-20020a05600c114f00b003fbb5506e54sm11450675wmz.29.2023.07.31.07.15.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 07:15:36 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 2/6] elf2dmp: Don't abandon when Prcb is set to 0 Date: Mon, 31 Jul 2023 15:15:29 +0100 Message-Id: <20230731141533.3303894-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230731141533.3303894-1-peter.maydell@linaro.org> References: <20230731141533.3303894-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Akihiko Odaki Prcb may be set to 0 for some CPUs if the dump was taken before they start. The dump may still contain valuable information for started CPUs so don't abandon conversion in such a case. Signed-off-by: Akihiko Odaki Reviewed-by: Viktor Prutyanov Message-id: 20230611033434.14659-1-akihiko.odaki@daynix.com Signed-off-by: Peter Maydell --- contrib/elf2dmp/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c index 89f0c69ab0f..6d4d18501a3 100644 --- a/contrib/elf2dmp/main.c +++ b/contrib/elf2dmp/main.c @@ -316,6 +316,11 @@ static int fill_context(KDDEBUGGER_DATA64 *kdbg, return 1; } + if (!Prcb) { + eprintf("Context for CPU #%d is missing\n", i); + continue; + } + if (va_space_rw(vs, Prcb + kdbg->OffsetPrcbContext, &Context, sizeof(Context), 0)) { eprintf("Failed to read CPU #%d ContextFrame location\n", i);