From patchwork Fri Aug 4 18:53:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 710228 Delivered-To: patch@linaro.org Received: by 2002:a05:6359:d30:b0:129:c516:61db with SMTP id gp48csp150245rwb; Fri, 4 Aug 2023 11:55:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYklT1wdtOkvcgOnDEtipOm3sNgzfQfhi+Zzd7xlQxwNCycLsDgxssbmUjRlRezVZOAkze X-Received: by 2002:a05:620a:2908:b0:767:3a10:d6de with SMTP id m8-20020a05620a290800b007673a10d6demr3902381qkp.58.1691175309401; Fri, 04 Aug 2023 11:55:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691175309; cv=none; d=google.com; s=arc-20160816; b=PJEVfZVQooPuL0X7n7fGRgmq/dmy1KTL+QZkKzQ9MT07OWGsGiec46uaJoPyTHjJsr 08d1TEdPi0IgdEguuGod1gglNq1I0sVM0RLzpWOrEZPyVE0LC1Q6u4R6EngtqNG9+hoQ li7vQK1UjkTmCWq/7dQs0kgYJeM8wvWdjpal+BeoHh4xmjcynoBFLNjLecBRMFFt9tQw +T+B/o2nQXtOTNzzZtR12dPJdTSpuGOeu+iOA4dJHyLf3J1RGfkdwMJdlzntaL+aYgQ3 9waZWFYKNefHtVIZmgEPmsNIsv8c6MmQ6G+kJjmLk62Nk58PYedXUa+ClMl07R6a29i4 R7jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=9fiCF5UaU6EI/8JS6k4doJY/R5/IwkT4vbtxTGm9W9s=; fh=N0pzpkMrBzgxwu1Zqyrxxf8KeOW94Gy2VyKYyB2OHBY=; b=mHlouDTe1I2kHmqJihoM2L3LerZ1/GSvsQ0NX37nPQI6x4Rqlq+Q6UwwrMu4FnNO2g rj3mdFxgLko/Q+wUPcHfM6+iTtBCQWvHXL+n1mm0KnQFS9kcxRZGqSdAfH2RlEVRaueC DNopN3q+nuahqfaQsmEf41Rg3OEULRTVXxhes/wpC/z/WuN4Rjd6ewVIsFV1GPxkSWmB 4TJ7jcT/+OWK1THQh4YN4/7DpsUZuQQ+kqUzbvEmH80RgbxfZzzmi+I6L5nwUvbofOCO LT3EdpEJ9pDZtnQ/aDhtCrfoLO10ihK8xUTABk3PIN8+HX9/fNFlzjnuR9H7+nQok/2r CbiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j14-20020a05622a038e00b0040399b08195si1661382qtx.738.2023.08.04.11.55.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Aug 2023 11:55:09 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRzwl-0002Pz-Da; Fri, 04 Aug 2023 14:54:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRzwi-0002PI-BY; Fri, 04 Aug 2023 14:54:44 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRzwg-0008AS-RV; Fri, 04 Aug 2023 14:54:44 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id A47AC18410; Fri, 4 Aug 2023 21:54:19 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 3CF781B887; Fri, 4 Aug 2023 21:53:59 +0300 (MSK) Received: (nullmailer pid 1874230 invoked by uid 1000); Fri, 04 Aug 2023 18:53:56 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Michael Tokarev Subject: [Stable-7.2.5 26/36] target/m68k: Fix semihost lseek offset computation Date: Fri, 4 Aug 2023 21:53:39 +0300 Message-Id: <20230804185350.1874133-13-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Cc: qemu-stable@nongnu.org Fixes: 950272506d ("target/m68k: Use semihosting/syscalls.h") Reported-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230801154519.3505531-1-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé (cherry picked from commit 8caaae7319a5f7ca449900c0e6bfcaed78fa3ae2) Signed-off-by: Michael Tokarev diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c index 87b1314925..7a88205ce7 100644 --- a/target/m68k/m68k-semi.c +++ b/target/m68k/m68k-semi.c @@ -165,7 +165,7 @@ void do_m68k_semihosting(CPUM68KState *env, int nr) GET_ARG64(2); GET_ARG64(3); semihost_sys_lseek(cs, m68k_semi_u64_cb, arg0, - deposit64(arg2, arg1, 32, 32), arg3); + deposit64(arg2, 32, 32, arg1), arg3); break; case HOSTED_RENAME: