Message ID | 20230904161235.84651-14-philmd@linaro.org |
---|---|
State | New |
Headers | show
Delivered-To: patch@linaro.org Received: by 2002:adf:d08b:0:b0:31d:da82:a3b4 with SMTP id y11csp1688102wrh; Mon, 4 Sep 2023 09:17:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTbbYwmb2QNOrpXlpnRErJSeGIo/+iJLpw/7kYEM4AT+uwQGbOmeGa7rLD6MPBnnLS1+Zv X-Received: by 2002:a0c:aad4:0:b0:655:87a1:49c4 with SMTP id g20-20020a0caad4000000b0065587a149c4mr934764qvb.39.1693844277220; Mon, 04 Sep 2023 09:17:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693844277; cv=none; d=google.com; s=arc-20160816; b=BjtbasguWFH0MgifpNdn0urjuSJ8ulJ3MC+jzppKgm2waSJXNVqA0hf9PKEu9gNEjf VmQyP1ZOyEqlhte06jam6v9iYCNKN433mabp+v9l4AOkJY/d1cAXrKHWaQ6J+M8PIn6p pvXRswa/csq+01dd4uaX0F7lYED8/WdEE2gUyVpOjrLdcX3EtsxTq7g6PIEx5RvjEdtx az5qijVQXe37NQs9jaEMJHiJ5hE0FeObDRN3FnpQnNnrfSlriLXrSpE484YvqXD2CkE2 2t9qlPoRfqAmZxSpy7c+774Ki4z64rdP5wDGnP29JfTWVSCkQ6MXs19uzHbhuxhjx+Bt 6Wyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fhyPLNQFlPI2Qtv/db+V50enbSRfShGobOGuQ5IYsJA=; fh=HvdrSrphu1ODNkbTjx5P6GZ6fTRKOIOyTadJ3yf+IkA=; b=x+OOr+K6Z9yfHozKp33PCQZm0XykZ5bldrUhN3mMKZLwJjNjt8ENuQmIcpUF/7Yzuj AS4EU7vZWbN9UZtEbSOQMuABtXHzhIA3+SgAaZbNkQO7hynBt2/1EAjT4wS5z8a3u8at Xkxz+5p6su7MLcYWh1SCNFET1RWcylHfYs+3BCFTaUnPbpEoOrbM2C1+r5cQ5vWkb3hq RKwGhNqSY7jjdwXfJPsY9Qh1YJOGWu9pMmzPrPfee5Gv3OCqYc3VHAwbDhH1BECRnZNv 9kl/fSJlfHIiJ9Ud1wPQsJTaxAWiYd6rrso9EkgUPcNeB9AMDZxM42H+kivAv4+Bfmln jeDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nVskmaef; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: <qemu-devel-bounces+patch=linaro.org@nongnu.org> Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y5-20020a0cf145000000b0064ca647d174si6726353qvl.88.2023.09.04.09.17.57 for <patch@linaro.org> (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Sep 2023 09:17:57 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nVskmaef; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces@nongnu.org>) id 1qdCDL-0004E8-Gy; Mon, 04 Sep 2023 12:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1qdCD8-0003QY-6I for qemu-devel@nongnu.org; Mon, 04 Sep 2023 12:13:59 -0400 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1qdCD3-0007eN-EA for qemu-devel@nongnu.org; Mon, 04 Sep 2023 12:13:57 -0400 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2bcb89b4767so24278021fa.3 for <qemu-devel@nongnu.org>; Mon, 04 Sep 2023 09:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693844031; x=1694448831; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fhyPLNQFlPI2Qtv/db+V50enbSRfShGobOGuQ5IYsJA=; b=nVskmaef1b2JOZgy+xR/QQJh0wkByhD7E4tPhNfHMFqevZlZ3dHa+8eZ0LV3PVqEaX NhGS0st3wk4Fj42IX4pIIzBYwZJgM6hCus2fEy5TO7UC+UkQv+t3NLxA6TDcpGgWHtZr IT48+2kBUn4FxQCDTWdQxFUDkfu+u9S5QJAM+GxVoIJnh02egOKkEBhbzGtsnvMTs5fK hIxMs5mkSFM8u770IyIldClz5+UmAJZi94soayyTcHFq4gFsmCLCXJwJsNk5LnmpE7x4 xkGzbvQIHOprvtB7LiMcUG3fQGIGCpaOSS1kfGKBKIvLxogAhNt9J3lIvYAiaPPgD9pl yoOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693844031; x=1694448831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fhyPLNQFlPI2Qtv/db+V50enbSRfShGobOGuQ5IYsJA=; b=SX8nuiHHWH9nSblxyyJWLUCd+YguGJFxhJws+xB9hT9R0Osla0DFvP5vXzDWYiU50F rRFuxZa0Ru+RK6ebugFr+9rrWwY8ItfnX0BXhxWyjv6RjE81ghXlX8rgQ7wjnLRdcT3n FfwZdJlMt5JFMBjDVH0t0R7Cqu80YV4d/Xn2WJ/BWPP8tV1lUISX27bH2Qrafg9HoOPw oJWvvZ5CF78AzYsHXgXCM5oS1YifNC7mpgtr2umvmigxQW9LBMUgYR4VrqaTkzH5cl7s JXtH1SEeRxrTEaeoOPo9sWv9HzuQepxCSi5GKx/WVkvmVnCJjBZNHD6pn53HkYh2sCCq 3Zkg== X-Gm-Message-State: AOJu0YxXRrbMuHStc2QNZEnu9mDAUf4IlowHA+cgeZYIXNTVEsSwi1/E zSzOpr49r/hO19K3pO7lZ0AqeQ== X-Received: by 2002:a2e:864a:0:b0:2bc:c846:aa17 with SMTP id i10-20020a2e864a000000b002bcc846aa17mr7888614ljj.41.1693844031798; Mon, 04 Sep 2023 09:13:51 -0700 (PDT) Received: from m1x-phil.lan ([176.187.209.227]) by smtp.gmail.com with ESMTPSA id r10-20020a170906c28a00b0099297782aa9sm6318128ejz.49.2023.09.04.09.13.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 04 Sep 2023 09:13:51 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org> To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-D?= =?utf-8?q?aud=C3=A9?= <philmd@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com> Subject: [PATCH v2 13/22] hw/microblaze: Clean up local variable shadowing Date: Mon, 4 Sep 2023 18:12:25 +0200 Message-ID: <20230904161235.84651-14-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230904161235.84651-1-philmd@linaro.org> References: <20230904161235.84651-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::236; envelope-from=philmd@linaro.org; helo=mail-lj1-x236.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org |
Series |
(few more) Steps towards enabling -Wshadow
|
expand
|
diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c index babb053035..445509f699 100644 --- a/hw/microblaze/petalogix_ml605_mmu.c +++ b/hw/microblaze/petalogix_ml605_mmu.c @@ -183,7 +183,7 @@ petalogix_ml605_init(MachineState *machine) spi = (SSIBus *)qdev_get_child_bus(dev, "spi"); for (i = 0; i < NUM_SPI_FLASHES; i++) { - DriveInfo *dinfo = drive_get(IF_MTD, 0, i); + dinfo = drive_get(IF_MTD, 0, i); qemu_irq cs_line; dev = qdev_new("n25q128");
Fix: hw/microblaze/petalogix_ml605_mmu.c: In function ‘petalogix_ml605_init’: hw/microblaze/petalogix_ml605_mmu.c:186:24: warning: declaration of ‘dinfo’ shadows a previous local [-Wshadow=compatible-local] 186 | DriveInfo *dinfo = drive_get(IF_MTD, 0, i); | ^~~~~ hw/microblaze/petalogix_ml605_mmu.c:78:16: note: shadowed declaration is here 78 | DriveInfo *dinfo; | ^~~~~ Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/microblaze/petalogix_ml605_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)