From patchwork Sat Sep 9 10:27:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 721080 Delivered-To: patch@linaro.org Received: by 2002:adf:f64d:0:b0:31d:da82:a3b4 with SMTP id x13csp200409wrp; Sat, 9 Sep 2023 03:29:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJIKHwpcfKZKZQJJVYjh3gRLL8HEwebPY5Prv7edpArXrh+sOjXz+sz6CGPstkZGuJbsYj X-Received: by 2002:a05:620a:2ac6:b0:76c:b682:f503 with SMTP id bn6-20020a05620a2ac600b0076cb682f503mr4745098qkb.60.1694255377407; Sat, 09 Sep 2023 03:29:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694255377; cv=none; d=google.com; s=arc-20160816; b=gFawOXgCO6ZsoN9EMCZAKojhJOxbAcF9SjBZs1R5tcbdfqm19uqO8KU318XMHSXZKa wn5UCdfyZPdaUy3gKWt45fW3bMWKewlTCS9UWbEfGJNj2EaejeSHgSrqWd95SpdKX3kt lA/wHjXSrW+h34ISvkEznrO8ruDUg77wAenrdql2IWXCq0wZWiWF/5GqGHdlyLTRq6WU yA4HeXZXEwwMGRFNz0FSIOPkIVqFfM0ezZty5Xj724i2o2xZeg+iL9KV5kMsTW2zv0SB QKHj+j485l8s4e3KuBLODZSyz+xGoK6/NYV4A660vuT9JeYW+aU5aX2Nd9T4W9lOar8j reAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=jfo8XNb8dVSi5eCHx8YeIoql8qfLwykXpyHr9mObziU=; fh=NYFo6XPkT4DRoX4o4xQY3FwVA26uVrJ9W3vyWAc1lUw=; b=QNauCswG+e1R/9u5Ob4sCX3B5FJ+dwbv5RBDmQx//17oOeEUSRI1ChEXwS3E+EnWFg iDGsHVsecbnwh9LWtqiko/uRLlhXjNdzhYw5LL/WvDeXd2XvLYv7dsbS0CJ4xyP43Nx4 /wJuoj5VChokHAJng/+MsicB4CYmA08EM1j8E4EacUcJLDu3N9bVFstzM+S6BuP0CPGS /htuPn/3/Lkf+NRx1v5eh/QmS4huBSgC0V7iRqx3PETsB+hNUKNfl4jSFgHbTPVL8cVj gJjvZIFcWsFL7FoCT0YEYRJoVu9u43b5PA1xBd5ThSHgsKQhKNgK9YphWJNwcI/Uwg5I S8yQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id dv12-20020a05620a1b8c00b0076787a8a594si2192693qkb.205.2023.09.09.03.29.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Sep 2023 03:29:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qevCn-0007Qk-6M; Sat, 09 Sep 2023 06:28:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qevCl-0007OT-1V; Sat, 09 Sep 2023 06:28:43 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qevCi-0004Vb-Or; Sat, 09 Sep 2023 06:28:42 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id D8264204A1; Sat, 9 Sep 2023 13:28:49 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id C80F526CFF; Sat, 9 Sep 2023 13:27:58 +0300 (MSK) Received: (nullmailer pid 346664 invoked by uid 1000); Sat, 09 Sep 2023 10:27:57 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= , Peter Maydell , Michael Tokarev Subject: [Stable-8.1.1 14/34] target/arm: properly document FEAT_CRC32 Date: Sat, 9 Sep 2023 13:27:07 +0300 Message-Id: <20230909102747.346522-14-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Alex Bennée This is a mandatory feature for Armv8.1 architectures but we don't state the feature clearly in our emulation list. Also include FEAT_CRC32 comment in aarch64_max_tcg_initfn for ease of grepping. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-id: 20230824075406.1515566-1-alex.bennee@linaro.org Cc: qemu-stable@nongnu.org Message-Id: <20230222110104.3996971-1-alex.bennee@linaro.org> [PMM: pluralize 'instructions' in docs] Signed-off-by: Peter Maydell (cherry picked from commit 9e771a2fc68d98c5719b877e008d1dca64e6896e) Signed-off-by: Michael Tokarev diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst index bdafc68819..d47b78eca9 100644 --- a/docs/system/arm/emulation.rst +++ b/docs/system/arm/emulation.rst @@ -14,6 +14,7 @@ the following architecture extensions: - FEAT_BBM at level 2 (Translation table break-before-make levels) - FEAT_BF16 (AArch64 BFloat16 instructions) - FEAT_BTI (Branch Target Identification) +- FEAT_CRC32 (CRC32 instructions) - FEAT_CSV2 (Cache speculation variant 2) - FEAT_CSV2_1p1 (Cache speculation variant 2, version 1.1) - FEAT_CSV2_1p2 (Cache speculation variant 2, version 1.2) diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c index 8019f00bc3..1975253dea 100644 --- a/target/arm/tcg/cpu64.c +++ b/target/arm/tcg/cpu64.c @@ -743,7 +743,7 @@ void aarch64_max_tcg_initfn(Object *obj) t = FIELD_DP64(t, ID_AA64ISAR0, AES, 2); /* FEAT_PMULL */ t = FIELD_DP64(t, ID_AA64ISAR0, SHA1, 1); /* FEAT_SHA1 */ t = FIELD_DP64(t, ID_AA64ISAR0, SHA2, 2); /* FEAT_SHA512 */ - t = FIELD_DP64(t, ID_AA64ISAR0, CRC32, 1); + t = FIELD_DP64(t, ID_AA64ISAR0, CRC32, 1); /* FEAT_CRC32 */ t = FIELD_DP64(t, ID_AA64ISAR0, ATOMIC, 2); /* FEAT_LSE */ t = FIELD_DP64(t, ID_AA64ISAR0, RDM, 1); /* FEAT_RDM */ t = FIELD_DP64(t, ID_AA64ISAR0, SHA3, 1); /* FEAT_SHA3 */