| Message ID | 20231013140116.255-3-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target: Make 'cpu-qom.h' really target agnostic | expand |
Hi Philippe, On Fri, Oct 13, 2023 at 04:01:01PM +0200, Philippe Mathieu-Daudé wrote: > Date: Fri, 13 Oct 2023 16:01:01 +0200 > From: Philippe Mathieu-Daudé <philmd@linaro.org> > Subject: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic > X-Mailer: git-send-email 2.41.0 > > "target/foo/cpu-qom.h" is supposed to be target agnostic > (include-able by any target). Add such mention in the > header. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/cpu-qom.h | 2 +- > target/hppa/cpu-qom.h | 2 +- > target/microblaze/cpu-qom.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Why not mention this description for other qom-cpu.h in this series, e.g., target/i386/cpu-qom.h. Otherwise, Reviewed-by: Zhao Liu <zhao1.liu@intel.com> > > diff --git a/target/arm/cpu-qom.h b/target/arm/cpu-qom.h > index 153865d1bb..dfb9d5b827 100644 > --- a/target/arm/cpu-qom.h > +++ b/target/arm/cpu-qom.h > @@ -1,5 +1,5 @@ > /* > - * QEMU ARM CPU > + * QEMU ARM CPU QOM header (target agnostic) > * > * Copyright (c) 2012 SUSE LINUX Products GmbH > * > diff --git a/target/hppa/cpu-qom.h b/target/hppa/cpu-qom.h > index 67f12422c4..4b1d48f7ca 100644 > --- a/target/hppa/cpu-qom.h > +++ b/target/hppa/cpu-qom.h > @@ -1,5 +1,5 @@ > /* > - * QEMU HPPA CPU > + * QEMU HPPA CPU QOM header (target agnostic) > * > * Copyright (c) 2016 Richard Henderson <rth@twiddle.net> > * > diff --git a/target/microblaze/cpu-qom.h b/target/microblaze/cpu-qom.h > index 2a734e644d..78f549b57d 100644 > --- a/target/microblaze/cpu-qom.h > +++ b/target/microblaze/cpu-qom.h > @@ -1,5 +1,5 @@ > /* > - * QEMU MicroBlaze CPU > + * QEMU MicroBlaze CPU QOM header (target agnostic) > * > * Copyright (c) 2012 SUSE LINUX Products GmbH > * > -- > 2.41.0 > > >
On 20/10/23 09:14, Zhao Liu wrote: > Hi Philippe, > > On Fri, Oct 13, 2023 at 04:01:01PM +0200, Philippe Mathieu-Daudé wrote: >> Date: Fri, 13 Oct 2023 16:01:01 +0200 >> From: Philippe Mathieu-Daudé <philmd@linaro.org> >> Subject: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic >> X-Mailer: git-send-email 2.41.0 >> >> "target/foo/cpu-qom.h" is supposed to be target agnostic >> (include-able by any target). Add such mention in the >> header. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> >> --- >> target/arm/cpu-qom.h | 2 +- >> target/hppa/cpu-qom.h | 2 +- >> target/microblaze/cpu-qom.h | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) > > Why not mention this description for other qom-cpu.h in this series, > e.g., target/i386/cpu-qom.h. OK, will add a comment in each patch. > Otherwise, > > Reviewed-by: Zhao Liu <zhao1.liu@intel.com> Thanks!
diff --git a/target/arm/cpu-qom.h b/target/arm/cpu-qom.h index 153865d1bb..dfb9d5b827 100644 --- a/target/arm/cpu-qom.h +++ b/target/arm/cpu-qom.h @@ -1,5 +1,5 @@ /* - * QEMU ARM CPU + * QEMU ARM CPU QOM header (target agnostic) * * Copyright (c) 2012 SUSE LINUX Products GmbH * diff --git a/target/hppa/cpu-qom.h b/target/hppa/cpu-qom.h index 67f12422c4..4b1d48f7ca 100644 --- a/target/hppa/cpu-qom.h +++ b/target/hppa/cpu-qom.h @@ -1,5 +1,5 @@ /* - * QEMU HPPA CPU + * QEMU HPPA CPU QOM header (target agnostic) * * Copyright (c) 2016 Richard Henderson <rth@twiddle.net> * diff --git a/target/microblaze/cpu-qom.h b/target/microblaze/cpu-qom.h index 2a734e644d..78f549b57d 100644 --- a/target/microblaze/cpu-qom.h +++ b/target/microblaze/cpu-qom.h @@ -1,5 +1,5 @@ /* - * QEMU MicroBlaze CPU + * QEMU MicroBlaze CPU QOM header (target agnostic) * * Copyright (c) 2012 SUSE LINUX Products GmbH *