From patchwork Wed Oct 18 23:31:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 735173 Delivered-To: patch@linaro.org Received: by 2002:adf:f0cd:0:b0:32d:baff:b0ca with SMTP id x13csp1258549wro; Wed, 18 Oct 2023 16:33:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9cI/UF6wD8ZzK3Ka9L6QQTmXk+hQvZrHlUWvWn95q5aw2JCRI1qqCvwJ6qQEglswfIstK X-Received: by 2002:a05:6214:e8c:b0:65a:f332:10f6 with SMTP id hf12-20020a0562140e8c00b0065af33210f6mr959256qvb.35.1697672010220; Wed, 18 Oct 2023 16:33:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697672010; cv=none; d=google.com; s=arc-20160816; b=bN2W6ksVtt4a4DHLU76K21He8rYcn8FZX+ZiLJr4trk5br2126pF2FqjSywGz9C/WP umtSrlgBD8+9FkzYIkXoWIs1Nz/Xa4Ip2C742hZ8sYJM+he4zXmM8C5fvPZBM8BYaGzy RUtt7Rb8yHyKCRyTBia783ByUrzyMNOFus14HYRT9RMLMuWye/DVUusTdRlFU2MdL0U7 qDhFRVx/00fg9Y4bFC5OR492QWDp+KCCjqDbdeawbho67kXPJlrNfRKa+R9n22kb14SU mQXYrGy4rSwBPLPRQv1G789SqW+VhwSvewfgUfNYv6KIxqrRlhvPD9zM3hbfOGPtMbFe LGlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XDEeeYBNH4kaMPDKd2bpL06m4MGoDecFzYDq6oXSWUM=; fh=3//KcqJEsa04kIBt5Nb/DJuP+2GuH1NwDRxnSl44zdw=; b=j6frtWp5A5W8cNpRl1DP1KRIWWM7p8Zu3pWgsd46b42eCP8/fX1/54cFjP+5tN0ecf 4/BAXV2jc836KUD5OhBNMe+uqp5U18k+6iyvDLSjl45MwtBsaPPZiPHPrTVfWkK8At+o c3+hX/l41IqbYNjS1NNDVTCRjxdviee2l2kpahIHOOUgUP4GV/RO83a1F2eZ8hwkz/TL Xze8365oC7zf9tcIRcbCMKIxJ2le0sppnLatQcl3kmf+EbHKkfI4EBXk33ccjjBTeKqs jdAQOmdk8qMYhA8WbuqEZRI/go1XYJUxPIn/YSITL9s9FY2G4lSYcw1N+6LYlBu1MeRs ZoZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E5bVMljh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v2-20020a0ccd82000000b0065b2cca41a2si737390qvm.110.2023.10.18.16.33.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Oct 2023 16:33:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E5bVMljh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtG0v-0003yg-SW; Wed, 18 Oct 2023 19:31:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtG0u-0003vt-3a for qemu-devel@nongnu.org; Wed, 18 Oct 2023 19:31:44 -0400 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtG0s-0000KC-Ig for qemu-devel@nongnu.org; Wed, 18 Oct 2023 19:31:43 -0400 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6b1e46ca282so5808204b3a.2 for ; Wed, 18 Oct 2023 16:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697671901; x=1698276701; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XDEeeYBNH4kaMPDKd2bpL06m4MGoDecFzYDq6oXSWUM=; b=E5bVMljhVaac6oapoai8D5VZEBpg26aWN1S68fE3yZUQ0RD+n1Bf9iMc1dvGu7qV8l gu1u39Wv2w/DtUPYs+LqpvvNq57ITlRX3zHU9P54F3TcYm02C5wNURCYc/RN89MlKsIk cg/CBqfwl1V9bqG8qM0u4+DNpYc+0m3Bnd29FZuRIG5St8FXkDjD51lYCYPYezSvXFJ4 UqiRbN6tpI8tNnmGhp+enM84QnW1PY8uC0B/S8xGW1hniJQ8nbMtwa7PdbtLK+Ka07l3 4gZdqhsbsjgNXy+KD8pyKtvwls/Cq87fTuicF4X7NycNE8Y60FzFF7bzveWH6UBKleiF 66gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697671901; x=1698276701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XDEeeYBNH4kaMPDKd2bpL06m4MGoDecFzYDq6oXSWUM=; b=I902sHxOSE6o3rIU/vgEutM/lZ7Wvhy3ZyJQFNfJcn1j0pUJrxfPW1eTrMd7qgTlq6 2boNkShJRgltEO/LDTqUwBSioW0nrwn2kW0uLONiIiEXuW8+LAcFibArr0U234u/niBC bVmlj7kMHEe8hMe00g22kP6MjlgQKV2dx1bTVosMTWT3l1N2pdh9ZTjZ6j4Xcmv17MpQ Kwx1l2KXktdmCqisX3O2XBMBC/xmkvhVyGuV4uGoNEYQ+riINfm4TpQdAyBteQPC8oWK bB7r17M2lQzr9nkIjhQ0pfCGKar84KLkyhr29GphRzoW3VP8OzdGc+6evC0hjthaH/qr lkLQ== X-Gm-Message-State: AOJu0YxGncnMAdGveoWyhbxdwVZsJUVmcVbQZWyRcRSqeSCspJNE3twX Eg3ojonoGfBkBrGzLmKSKKRnpjSymcovKwxiH3w= X-Received: by 2002:a05:6a00:189f:b0:68f:c7c5:a73a with SMTP id x31-20020a056a00189f00b0068fc7c5a73amr655931pfh.16.1697671901235; Wed, 18 Oct 2023 16:31:41 -0700 (PDT) Received: from stoup.. ([71.212.149.95]) by smtp.gmail.com with ESMTPSA id g9-20020aa796a9000000b006be5af77f06sm3881690pfk.2.2023.10.18.16.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 16:31:40 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Helge Deller , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 07/14] linux-user: Exit not abort in die_with_backtrace Date: Wed, 18 Oct 2023 16:31:27 -0700 Message-Id: <20231018233134.1594292-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231018233134.1594292-1-richard.henderson@linaro.org> References: <20231018233134.1594292-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This line is supposed to be unreachable, but if we're going to have it at all, SIGABRT via abort() is subject to the same signal peril that created this function in the first place. We can _exit immediately without peril. Acked-by: Helge Deller Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index b7a2c47837..84a56b76cc 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -713,7 +713,7 @@ void die_with_signal(int host_sig) sigsuspend(&act.sa_mask); /* unreachable */ - abort(); + _exit(EXIT_FAILURE); } static G_NORETURN