From patchwork Thu Oct 19 13:12:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 735551 Delivered-To: patch@linaro.org Received: by 2002:adf:f0cd:0:b0:32d:baff:b0ca with SMTP id x13csp1509099wro; Thu, 19 Oct 2023 06:15:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwDI4Gl66zTLcnGJea0iRCOBDHkUH2W5ZuMGwyora+LuBe+DMU4AD7OQeBB89mfqWGevyQ X-Received: by 2002:adf:ea8f:0:b0:32d:9755:44ec with SMTP id s15-20020adfea8f000000b0032d975544ecmr1348750wrm.41.1697721305515; Thu, 19 Oct 2023 06:15:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697721305; cv=none; d=google.com; s=arc-20160816; b=zk/WrSsB666YaC+6HpwLQ9+WhsM6HUe2lLMTancphZdxjVA8JFCudP3TkrQfigFmqP sdN3eLtAvCDOSEuyKaLYtyzzEHpsjywu6H+natwxaF7+586MMz91pPpcmFpjtQEiWLG/ 3WSr0LsKddUyW/DhjhMnSem0fCBnCR5+6kbHx7P+RoeUONZ+sskg5ls4AuYkgwU7c/2u dEf4qxvMNNLIQGSToh+YTIzgZR4I9ngovuqzlcJwE58R6JAQqeVZSMxYGJEd7ZEUBDsO 7tlRz0WK3XSYerL3M1j/EKwHh/dBqzHOBPLGNcD/S0jxjWqcK3iiz0XqnDT3oen/i0Fa Pr9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8v7QjsFI/UQ66aMELorogiH5Qo/GKGcFOriZN36zvBM=; fh=pKSa3NIqn0GzXJAy/2EwD+riYoiBTvQWIw5svo/o4rg=; b=hKE2xXx2OQE1DTA85fp9aEo+K+JIp42R+PDHwI5Qr/n2O7wy/dPFczSY1Vv2dEDJCg HgK1P80R53QHfnyDFg/kB+kQ494pvzbCCIe5EjnvQ5THZj737QUOxRQadHpR2rmQep/E 7h8moQNzW7HSjzl1wV73I+g5BujVBw864jT6iKfKweJn6VVS2g3Vqalb2z1drvn4b0bk JiH5Xea5yNWmD6wsI3SZsaI4zm6p6b5Z18gGaL8aeB4a7v2TvgxcOZHfTNkuQ+gBU372 PtEQRo+AUEflRFzi0u3txgSgjYM9CIEOyDJiE3rz41qW1aEFmSm8fnzEyy/UMNaqZ5A+ w/Gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="nRu+Gnd/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m18-20020adffa12000000b0032d91a4fd20si2538323wrr.46.2023.10.19.06.15.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Oct 2023 06:15:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="nRu+Gnd/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtSqt-0000Hp-T4; Thu, 19 Oct 2023 09:14:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtSpz-0007GG-LB for qemu-devel@nongnu.org; Thu, 19 Oct 2023 09:13:23 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtSpx-0002SR-8K for qemu-devel@nongnu.org; Thu, 19 Oct 2023 09:13:19 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b9d07a8d84so100502601fa.3 for ; Thu, 19 Oct 2023 06:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697721195; x=1698325995; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8v7QjsFI/UQ66aMELorogiH5Qo/GKGcFOriZN36zvBM=; b=nRu+Gnd/gciYPITH+dTK5fS+368XivaJf6t7hGwXTq+NBfbzy+hFDVfHZx2v8CMdFf fNezw5ed0lZqiY8F8pIV7iwb9XGbqI+fiBNm4ubokNys44ffExuRnfAYE9l8q6TsQYog FsQYR1Eq3byBDDwzdZFYaIbnCo31YdmjIn/ZoE9xkxad4in2P7Q+ZQRNKM+HwpOIsYU/ eyIqYqZVyuUPIQbsEamfzG8Lp6N8Y158Yyf9YWOdpfvPwY1/4LeRa7FcnBjCx4yp1daH sex32oWkijOhlJe+WbRrd4gxT63ff27JhR1ihluaTwXuSqjNb98+qjFyzZhRzl/W3fYS 55Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697721195; x=1698325995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8v7QjsFI/UQ66aMELorogiH5Qo/GKGcFOriZN36zvBM=; b=pqa/iQv7bhlDacvq4YpVOT9Efv4WNINy0MnZ63KrwA6z669Jd0AcokGN5uk+0cwGjx iXQIm5t+MzQNnIbGLZ/eF11zbJrS+Hf79155ULjVSoLRMRbmmO9ZzfBqcA7Ft7kAIZmL UfK6iMcL2zD4PptzrMUra6MIhdiyR9iyECbSDSSLUbHV35ECSei4la3lHn2/Y1N4/XGj 6vVME3QnAthLVH6/x4IH7+P+4XSbbQu9j5JaUAGUIy17pVWZouZQIE+rzrZw4F6SHtvy 0l8ydeys/TwpVdXoq3yb6HS/kdD51cWGvDZ1BzDCAJOpzDtBgva4VG56VfdYuWxSqoTM gdIA== X-Gm-Message-State: AOJu0YyIn84KuWILsIBOt/kPD0inT+giLfiZW8HzU2lutk9B+HJVEGL4 RYSctSyz7eCJBvw7jX5FVhtiemVbvlXjN9C87TpAQA== X-Received: by 2002:a2e:9b0a:0:b0:2c4:feef:852 with SMTP id u10-20020a2e9b0a000000b002c4feef0852mr1254865lji.32.1697721194948; Thu, 19 Oct 2023 06:13:14 -0700 (PDT) Received: from m1x-phil.lan (176-131-216-177.abo.bbox.fr. [176.131.216.177]) by smtp.gmail.com with ESMTPSA id m16-20020a7bca50000000b00405d9a950a2sm4335932wml.28.2023.10.19.06.13.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Oct 2023 06:13:14 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Richard Henderson , =?utf-8?b?RnLDqWTDqXJpYyBCYXJyYXQ=?= , Harsh Prateek Bora , David Gibson , Nicholas Piggin , =?utf-8?q?C=C3=A9dric_Le_Goater?= , LIU Zhiwei , Daniel Henrique Barboza , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/7] hw/ppc/spapr_vio: Realize SPAPR_VIO_BRIDGE device before accessing it Date: Thu, 19 Oct 2023 15:12:59 +0200 Message-ID: <20231019131305.19157-2-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231019131305.19157-1-philmd@linaro.org> References: <20231019131305.19157-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=philmd@linaro.org; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org qbus_new() should not be called on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/ppc/spapr_vio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_vio.c b/hw/ppc/spapr_vio.c index 9d4fec2c04..f8ef2b6fa8 100644 --- a/hw/ppc/spapr_vio.c +++ b/hw/ppc/spapr_vio.c @@ -574,13 +574,14 @@ SpaprVioBus *spapr_vio_bus_init(void) /* Create bridge device */ dev = qdev_new(TYPE_SPAPR_VIO_BRIDGE); - sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); /* Create bus on bridge device */ qbus = qbus_new(TYPE_SPAPR_VIO_BUS, dev, "spapr-vio"); bus = SPAPR_VIO_BUS(qbus); bus->next_reg = SPAPR_VIO_REG_BASE; + sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); + /* hcall-vio */ spapr_register_hypercall(H_VIO_SIGNAL, h_vio_signal);