From patchwork Sun Nov 5 20:12:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 741063 Delivered-To: patch@linaro.org Received: by 2002:adf:fd90:0:b0:32d:baff:b0ca with SMTP id d16csp793521wrr; Sun, 5 Nov 2023 12:15:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IHZ3JoGkj36LiJ3dzdxTWXQ0zODDxgE0CoB2KuvHn5IdeP49+2IWsZi0YqoyE4EcEFcgpbE X-Received: by 2002:a05:622a:1a04:b0:41c:c3ad:922f with SMTP id f4-20020a05622a1a0400b0041cc3ad922fmr32598038qtb.42.1699215319847; Sun, 05 Nov 2023 12:15:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699215319; cv=none; d=google.com; s=arc-20160816; b=qjnpqb9VCRtH6QYKDVooLd/e8EUdoIjvLxqgNh3gtxmXJnhPPSYqOB1P2J9gNv+nz7 yGdLb8pi0g5mM+zjgiKftTDjobC1h2Smx6CSwgGSkX5GYQtm8Zz5zTd8I5ynrdTQpMem 3PJ9JK7MRT7/wvCnJ5ZJyKXOLLVWgNyFTaTnrCnBr6CbFL8hAmnk7l3QEBDzB3pFel+A FQtXxQBZ1hbLHs3G5wjJNWAIL3zKpozoAAvhFCCu/pHlmolkRZKUGy//T27OMR079iM2 KMHSgwHxRj3aNWGPLpRvRIbD9gTL8Prmr2P+WBT5dW6KtZvoYh6PZ7RVPf5/UAFZflMV LhGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=g/veF9kIVEae0GlpFh27Byc+ihsa92GV+L/1WPN7Szs=; fh=rYI8DiHAAFX3O5g969KmOAQ7d45Sb8OxQX1+DywGDk4=; b=QGBJqATFNbdH6lidbrUEWT2Z4BwIcIP5fMSH0Ji5ZEmBGpSv8mkOfgSbicIi6eU0l/ kqB1oQXQYRcBC6fDQF63FY2YscDW6LERUK6JDMGXY0tKN4+s3QZ3q4rXVGhe3hF0V+HF qKp9gvW3IxQnnd+w8SWD09DQqoyObzjuaoOg1u8mYxiWF9XwnymaZ9ykVOz3yHz1JS3e OrCH625nkGKRyrLlEGhPbL0XadJFeszBr9LJbfXr5YKfr5XqKci5Z0Klgami8dV8OWoP pwnp/JoxB8lWItBgMvqx9hUNCgjUy/oB2KOw72QKyXdJA+3cHultejwNG94e34zt0SaM tvFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cHEwTVF5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j4-20020ac85f84000000b00417f817da78si4655165qta.565.2023.11.05.12.15.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Nov 2023 12:15:19 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cHEwTVF5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzjUA-0003Qu-M7; Sun, 05 Nov 2023 15:12:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzjU9-0003PS-3y for qemu-devel@nongnu.org; Sun, 05 Nov 2023 15:12:41 -0500 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzjU7-0002AU-MG for qemu-devel@nongnu.org; Sun, 05 Nov 2023 15:12:40 -0500 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-1ef370c2e1aso2353653fac.2 for ; Sun, 05 Nov 2023 12:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699215157; x=1699819957; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g/veF9kIVEae0GlpFh27Byc+ihsa92GV+L/1WPN7Szs=; b=cHEwTVF5cmJ690lmkpolzTYKO1BnlD4HzGOoGnySyXVy4hqy/FgJQbsDdhmv4tSKmJ 11zt8BaLMUmQleBcDkRtq5symkRJzpv6c4jSDp3d1TfBjr5cjLGsx9wU8ZKYrByatw5N XEBPqoPnMVBGDgosrsLfFSPcXqv+PRC/MctDHnPV3PqVYaIT/cvZblpuI1hoOv4Tz5w1 6yskb6WJRHOATlO/c29H8wuPjpYLxX2x+D6LdtGVbBvdRTQuG68mldSR91nWZaGuAkiN rQv8Wrt8EPV1BQtf28iYAU+t2+DRCV7mE/c6KjxAFLGthVxooqCojjwGOHyTBrMjN1lK LI1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699215157; x=1699819957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g/veF9kIVEae0GlpFh27Byc+ihsa92GV+L/1WPN7Szs=; b=StPRiGMe/3vqVsR6dFLQbH+NVLl7OSYFejml4TlZAdN9ND8XgDb95SiGYrTH8wmfum zS2oUdxIIipoqrvc5kDFXTRMezPVMn6tIa4eUEmoCycOI6+RhJX3C6Lm/2sEp49PxdBT DlODAfRtmMxKWx+rr1kOm4bFjqdz1ySJt88ymMfE/mLWi+tZ/Lzjk4gC4yMiKR3vbynY a2ao5ip48f5YsmdCOzU/9oR0iPObq2lKo4hNYBGQJStaSqtSUbnBjdC94bA08kz9k8wT iH4cf8MUN9927qMI6QmHLneiDHY8eWDqY9wZ5BfAsH5JPB6Hf/XKCATZ+2q63rg64oJT +ppA== X-Gm-Message-State: AOJu0Yy1hjBBeCXdreZhVLwIszLn4pympSmaxwbjxrJGf4XM3gAslP2O r93rVVHYkpUKz55niTLNgZ12QXufREFgkM6ilXU= X-Received: by 2002:a05:6870:ac87:b0:1d6:3d31:fb4b with SMTP id ns7-20020a056870ac8700b001d63d31fb4bmr34645116oab.24.1699215157632; Sun, 05 Nov 2023 12:12:37 -0800 (PST) Received: from stoup.. ([71.212.149.95]) by smtp.gmail.com with ESMTPSA id u23-20020a056a00099700b006884549adc8sm4359777pfg.29.2023.11.05.12.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 12:12:37 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland Subject: [PULL 16/21] target/sparc: Merge gen_op_next_insn into only caller Date: Sun, 5 Nov 2023 12:12:17 -0800 Message-Id: <20231105201222.202395-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231105201222.202395-1-richard.henderson@linaro.org> References: <20231105201222.202395-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2001:4860:4864:20::2d; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Tested-by: Mark Cave-Ayland Acked-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/translate.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 1233911b69..0bbe4cff3b 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -1015,12 +1015,6 @@ static void gen_mov_pc_npc(DisasContext *dc) } } -static void gen_op_next_insn(void) -{ - tcg_gen_mov_tl(cpu_pc, cpu_npc); - tcg_gen_addi_tl(cpu_npc, cpu_npc, 4); -} - static void gen_compare(DisasCompare *cmp, bool xcc, unsigned int cond, DisasContext *dc) { @@ -2346,7 +2340,8 @@ static bool advance_pc(DisasContext *dc) case DYNAMIC_PC: case DYNAMIC_PC_LOOKUP: dc->pc = dc->npc; - gen_op_next_insn(); + tcg_gen_mov_tl(cpu_pc, cpu_npc); + tcg_gen_addi_tl(cpu_npc, cpu_npc, 4); break; case JUMP_PC: