diff mbox series

[PULL,31/60] target/mips: Fix TX79 LQ/SQ opcodes

Message ID	20231106110336.358-32-philmd@linaro.org
State	New
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org> To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, qemu-s390x@nongnu.org, qemu-block@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, qemu-stable@nongnu.org, Richard Henderson <richard.henderson@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> Subject: [PULL 31/60] target/mips: Fix TX79 LQ/SQ opcodes Date: Mon, 6 Nov 2023 12:03:03 +0100 Message-ID: <20231106110336.358-32-philmd@linaro.org> In-Reply-To: <20231106110336.358-1-philmd@linaro.org> References: <20231106110336.358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org
Series	[PULL,01/60] vl: Free machine list \| expand [PULL,01/60] vl: Free machine list [PULL,02/60] vl: constify default_list [PULL,03/60] tests/vm/ubuntu.aarch64: Correct comment about TCG specific delay [PULL,04/60] tests/unit/test-seccomp: Remove mentions of softmmu in test names [PULL,05/60] accel/tcg: Declare tcg_flush_jmp_cache() in 'exec/tb-flush.h' [PULL,06/60] accel: Introduce cpu_exec_reset_hold() [PULL,07/60] accel/tcg: Factor tcg_cpu_reset_hold() out [PULL,08/60] target: Unify QOM style [PULL,09/60] target: Mention 'cpu-qom.h' is target agnostic [PULL,10/60] target/arm: Move internal declarations from 'cpu-qom.h' to 'cpu.h' [PULL,11/60] target/ppc: Remove CPU_RESOLVING_TYPE from 'cpu-qom.h' [PULL,12/60] target/riscv: Remove CPU_RESOLVING_TYPE from 'cpu-qom.h' [PULL,13/60] target: Declare FOO_CPU_TYPE_NAME/SUFFIX in 'cpu-qom.h' [PULL,14/60] target/hexagon: Declare QOM definitions in 'cpu-qom.h' [PULL,15/60] target/loongarch: Declare QOM definitions in 'cpu-qom.h' [PULL,16/60] target/nios2: Declare QOM definitions in 'cpu-qom.h' [PULL,17/60] target/openrisc: Declare QOM definitions in 'cpu-qom.h' [PULL,18/60] target/riscv: Move TYPE_RISCV_CPU_BASE definition to 'cpu.h' [PULL,19/60] target/ppc: Use env_archcpu() in helper_book3s_msgsndp() [PULL,20/60] target/riscv: Use env_archcpu() in [check_]nanbox() [PULL,21/60] target/s390x: Use env_archcpu() in handle_diag_308() [PULL,22/60] target/xtensa: Use env_archcpu() in update_c[compare\|count]() [PULL,23/60] target/i386/hvf: Use x86_cpu in simulate_[rdmsr\|wrmsr]() [PULL,24/60] target/i386/hvf: Use env_archcpu() in simulate_[rdmsr/wrmsr]() [PULL,25/60] target/i386/hvf: Use CPUState typedef [PULL,26/60] target/i386/hvf: Rename 'CPUState cpu' variable as 'cs' [PULL,27/60] target/i386/hvf: Rename 'X86CPU x86_cpu' variable as 'cpu' [PULL,28/60] target/i386/kvm: Correct comment in kvm_cpu_realize() [PULL,29/60] target/i386/monitor: synchronize cpu state for lapic info [PULL,30/60] target/mips: Fix MSA BZ/BNZ opcodes displacement [PULL,31/60] target/mips: Fix TX79 LQ/SQ opcodes [PULL,32/60] sysemu/kvm: Restrict kvmppc_get_radix_page_info() to ppc targets [PULL,33/60] hw/ppc/e500: Restrict ppce500_init_mpic_kvm() to KVM [PULL,34/60] target/ppc: Restrict KVM objects to system emulation [PULL,35/60] target/ppc: Prohibit target specific KVM prototypes on user emulation [PULL,36/60] target/nios2: Create IRQs after accelerator vCPU is realized [PULL,37/60] target/alpha: Tidy up alpha_cpu_class_by_name() [PULL,38/60] hw/cpu: Call object_class_is_abstract() once in cpu_class_by_name() [PULL,39/60] exec/cpu: Have cpu_exec_realize() return a boolean [PULL,40/60] hw/cpu: Clean up global variable shadowing [PULL,41/60] hw/loader: Clean up global variable shadowing in rom_add_file() [PULL,42/60] hw/isa/i82378: Propagate error if PC_SPEAKER device creation failed [PULL,43/60] hw/i386: Fix comment style in topology.h [PULL,44/60] tests/unit: Rename test-x86-cpuid.c to test-x86-topo.c [PULL,45/60] system/cpus: Fix CPUState.nr_cores' calculation [PULL,46/60] hw/cpu: Update the comments of nr_cores and nr_dies [PULL,47/60] hw/ide: reset: cancel async DMA operation before resetting state [PULL,48/60] tests/qtest: ahci-test: add test exposing reset issue with pending callback [PULL,49/60] hw/i2c: pmbus add support for block receive [PULL,50/60] hw/i2c: pmbus: add vout mode bitfields [PULL,51/60] hw/i2c: pmbus: add fan support [PULL,52/60] hw/i2c: pmbus: add VCAP register [PULL,53/60] hw/sensor: add ADM1266 device model [PULL,54/60] tests/qtest: add tests for ADM1266 [PULL,55/60] hw/i2c: pmbus: immediately clear faults on request [PULL,56/60] hw/i2c: pmbus: reset page register for out of range reads [PULL,57/60] MAINTAINERS: Add include/hw/timer/tmu012.h to the SH4 R2D section [PULL,58/60] MAINTAINERS: Add the CAN documentation file to the CAN section [PULL,59/60] MAINTAINERS: update libvirt devel mailing list address [PULL,60/60] ui/sdl2: use correct key names in win title on mac

Commit Message

Philippe Mathieu-Daudé Nov. 6, 2023, 11:03 a.m. UTC

The base register address offset is *signed*.

Cc: qemu-stable@nongnu.org
Fixes: aaaa82a9f9 ("target/mips/tx79: Introduce LQ opcode (Load Quadword)")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230914090447.12557-1-philmd@linaro.org>
---
 target/mips/tcg/tx79.decode | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/target/mips/tcg/tx79.decode b/target/mips/tcg/tx79.decode
index 57d87a2076..578b8c54c0 100644
--- a/target/mips/tcg/tx79.decode
+++ b/target/mips/tcg/tx79.decode
@@ -24,7 +24,7 @@ 
 @rs             ...... rs:5  ..... ..........  ......   &r sa=0      rt=0 rd=0
 @rd             ...... ..........  rd:5  ..... ......   &r sa=0 rs=0 rt=0
 
-@ldst            ...... base:5 rt:5 offset:16           &i
+@ldst            ...... base:5 rt:5 offset:s16          &i
 
 ###########################################################################