From patchwork Mon Nov 20 15:08:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 745368 Delivered-To: patch@linaro.org Received: by 2002:a5d:5052:0:b0:32d:baff:b0ca with SMTP id h18csp1345194wrt; Mon, 20 Nov 2023 07:11:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+AU1Gd8jl/nzLIBddBigEg1L/8RC1wsyYVbZfHvwvT3dUCxMHS17hWRo4PzsqOKnW1Uqd X-Received: by 2002:a5d:6052:0:b0:32d:aa11:221d with SMTP id j18-20020a5d6052000000b0032daa11221dmr5142567wrt.27.1700493080546; Mon, 20 Nov 2023 07:11:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700493080; cv=none; d=google.com; s=arc-20160816; b=Gq7Wek9OW6YV6yfEe5+vu6tEBdMkZXLwRj/NUWM4m5nrdgrbpsEx3Xpr+0dowY/QQN 8o6OW/UFpqU/ArFX0S66cPNhEbm5CgeJKBN3vB1Wqli0PBOggz7Kq4XBO6no0jN3QIB+ mTh1aXKlVc8t9Uf4nucEOZEURbPt/+hG0MiF4Cdz3owHUl+zuO9yKCetQ9ViFcOMMVNa I0wv/SS8UwTGHexZy0zfoKAa/FeZAamxc0hoSA8PFPguXDxHvAKXIYPP35gz0Kuo0DrM LjLfAsMXrKqQgvu2pL6wf7PDR82ZImIGJejnSf7tcqeK5W9JAa5pG2n71BkI0Ub+Ietj Q7Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MdYIuvPCwbs1/SkyidzDPaAAsnYLQJ1SQQvqDWTDjY4=; fh=L8gboe2BpnMHPozXPXZ1zwcw4kd4+Ep8z61Ccww9Lhk=; b=LYJaEGvRfYA8GoFaIvkg8AhjPt9i3wH9Rjonz00WX1JqNLPwN8aNO6xa82zN9/l9UM HBrgbx4Pwnb620Ft1Ca9tGmQwDQZvJ+yGqvwpm6N1+AQXD6sU4VzQSbl2nxRw/PCW150 wsXWOK7HTxxDMRqKBl02u+I9Li1Qj0IdRxu8iyApkmFHkzdd/A6lMtSLxvYCGhpCEH5L h0SMWlEY6FUOzPVyQIfGVMGLFY8rubE5KncE1tb5zepdXmfHcxdfmrH1U43VV5FKyJer 9Kk2i/UEiWtJZ6WBWbzfFdtdTORR8EHgksl0zWtGskMD55tXk9qtSLtUGCUvQfsa5Utq VEng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m6JTyB23; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g11-20020adfa48b000000b0032daa5adfdfsi5006467wrb.138.2023.11.20.07.11.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Nov 2023 07:11:20 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m6JTyB23; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r55tf-0006LZ-LN; Mon, 20 Nov 2023 10:09:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r55tR-0005tj-Ho for qemu-devel@nongnu.org; Mon, 20 Nov 2023 10:09:00 -0500 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r55tG-0001Hr-8n for qemu-devel@nongnu.org; Mon, 20 Nov 2023 10:08:54 -0500 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-50943ccbbaeso6230384e87.2 for ; Mon, 20 Nov 2023 07:08:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700492922; x=1701097722; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MdYIuvPCwbs1/SkyidzDPaAAsnYLQJ1SQQvqDWTDjY4=; b=m6JTyB23Uz+26G2fTIGU0iRylMm+0RbjDkZiSu4MHuUs4PEPVq6/AF1fo/17ljRStr /+feY3oSx9RMbbT1U7eYjWKZp15GSilihxT+tSdlTo4UmiCQRdnGYpPR7fZGSW38z17n ldEoR3IAZ+rsTjFUkSikOJKGDvNyaAA2ZkeY9otPRMjbWk/xBtxbDKCmZ0LdXLk67UlL 5sf+5wVJfrqkkL+15p/2CLA9pfgBYtoLmmva/mkkjigI+EgyAYTkIFpZPSfTsS2Cw4Hh dImMv+qDYL+lSKVBlMN5EITeqnVzHp7tCVqZdqGcT70LF9fqw/W1BM/j2flIbMmD7YSo aUyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700492922; x=1701097722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MdYIuvPCwbs1/SkyidzDPaAAsnYLQJ1SQQvqDWTDjY4=; b=M2XZTvNk2pfO0AllhUfNEG47fGfb0Z2qyE9FXPDQGq/L2UvYu3rHLnTkH+YH4isQlt 9G4uDpKKN3I/Rm/5HCRe7tCJi3dEu10NMikAT4puYxboUdBXcMJ/EpYE03434wd+Nuvu cRWfcb7Bzu8DANjqY/WgPozaTtrmZc/K7wLnq2tDXUYMGcdehQ6PszB3/b5ztQIKQwGy 1VRoQTNfWKBoOXHHFJEtmmzTSG0UxuVrx2MRU1xtAisZM0s4b+4trnS3Pdc03Mt+UdG0 mj8JO8mLHAAT8AxgRZVdonWtcBkpt03DstU6ycRoxVlfhW7tlGuL2MDX7UntCwK5Mh1a jB0g== X-Gm-Message-State: AOJu0YzTnXwUeBijo6Bi3AA/ePOsn72uuzRg4KKwE/U82x4KYRO9HzSt sZqmjPpy+l6/bMjruan7yEkqig== X-Received: by 2002:ac2:4469:0:b0:509:e5a4:2b03 with SMTP id y9-20020ac24469000000b00509e5a42b03mr5760174lfl.13.1700492922721; Mon, 20 Nov 2023 07:08:42 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id e29-20020adfa45d000000b0033169451a84sm11501414wra.29.2023.11.20.07.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 07:08:38 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id CD30865777; Mon, 20 Nov 2023 15:08:34 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , =?utf-8?q?C=C3=A9dric?= =?utf-8?q?_Le_Goater?= , Mahmoud Mandour , Peter Maydell , David Hildenbrand , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-s390x@nongnu.org, Beraldo Leal , qemu-arm@nongnu.org, devel@lists.libvirt.org, qemu-ppc@nongnu.org, Daniel Henrique Barboza , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Alexandre Iooss , Marek Vasut , Thomas Huth , Chris Wulff , Ilya Leoshkevich , Richard Henderson , Nicholas Piggin Subject: [PATCH v2 09/14] hw/core: skip loading debug on all failures Date: Mon, 20 Nov 2023 15:08:28 +0000 Message-Id: <20231120150833.2552739-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231120150833.2552739-1-alex.bennee@linaro.org> References: <20231120150833.2552739-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=alex.bennee@linaro.org; helo=mail-lf1-x136.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org ELF_LOAD_FAILED is one of many negative return codes we can have. Lets treat any positive size_t as a success for loading. Message-Id: <20231115205542.3092038-8-alex.bennee@linaro.org> Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- hw/core/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 3c79283777..e7a9b3775b 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -505,7 +505,7 @@ ssize_t load_elf_ram_sym(const char *filename, clear_lsb, data_swab, as, load_rom, sym_cb); } - if (ret != ELF_LOAD_FAILED) { + if (ret > 0) { debuginfo_report_elf(filename, fd, 0); }