From patchwork Tue Dec 12 16:29:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 753088 Delivered-To: patch@linaro.org Received: by 2002:a5d:4c83:0:b0:333:3a04:f257 with SMTP id z3csp2010208wrs; Tue, 12 Dec 2023 08:31:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGSY6jQYDRHKNQ6QCI+zy3r/2rJ0jrEdmrYFRnDsT70fp7XE35xD8JmuV62gud5i0aoZVVL X-Received: by 2002:ac8:5d8f:0:b0:423:75bb:f78b with SMTP id d15-20020ac85d8f000000b0042375bbf78bmr10470674qtx.46.1702398678216; Tue, 12 Dec 2023 08:31:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702398678; cv=none; d=google.com; s=arc-20160816; b=Z10iKY9P8p+CKCpn/zj85Wn4X7yysDWaWOzw44Kf/VuG0MA8oVktMJqF5FggLVb81w qgyMD7EUxIo+p+2TVYPdIeXOgj6j8MzcaTPdKrMrLCKds56nwRL6FVSRyAMFuSBmu6Ht OiQPYQiW6891wMweXAiTbM7raRe5fIDQcz6NVS7KtH9puiEdZMIhAIT4mq3D2kW1cTAU 8DKtmYPgsMQ4XtaNTHA2XdOHnGmxpmF/gLicAvNGhHeeYFHSGoaUwdLxvNbK6Wy5tsGg K+6LFmcqMN1uSEHaTlDl6VVPox4/N7UT1z716zyabHqQ6vJ5f/XtgA/iw7ODoQ+Vsx/u 2XXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q6IQU5ROwUn//RvfuUSFoOspGxqF5s4e8MRFf4fb5zU=; fh=CkupYgn1Qmdh7jizui9HJgGegpqbRR5NXz1VyjRE1Hs=; b=Y5bU014hTfPBnfRmRmHTmHV9hyDd6KgeD224XNCF7SR4mlmrGbYqe357YUSiI8xaG9 9MYt4einbMIEHwh/c6hfN0lgkkQnEo4q98jcKHGN0XjgOTLJut6MFGgvE7VHdxYmO0jZ PSz1Ex1thv7oMSbvgwn2BTVVdxQCHgX/WzHgANLvK/VsHKJWssCegZcfmXrptFnu4zGb LSxvucj4ysbOQtW6E3hO+MhNCU03TV6fB3mg9bD2oI5AYOa/XiXOti8fpKkoFIIw3lEt p98xGfl//BgDp3w/9/wt8Z3dm7z0sTAlxHzcBDz/UMRC+3skyU3nweKV+z5hH6Jx/b0I olqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Qq9XPdd9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z15-20020ac8454f000000b00423a136751esi9938650qtn.40.2023.12.12.08.31.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Dec 2023 08:31:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Qq9XPdd9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rD5eH-0000we-JZ; Tue, 12 Dec 2023 11:30:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rD5e9-0000ur-Vy for qemu-devel@nongnu.org; Tue, 12 Dec 2023 11:30:15 -0500 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rD5e1-000763-89 for qemu-devel@nongnu.org; Tue, 12 Dec 2023 11:30:12 -0500 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a1f37fd4b53so715760866b.1 for ; Tue, 12 Dec 2023 08:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702398602; x=1703003402; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q6IQU5ROwUn//RvfuUSFoOspGxqF5s4e8MRFf4fb5zU=; b=Qq9XPdd9PYGPPwPnNA9KES6D/81hx0i0lMrs0A2M4praZ8A5/sFcQha4PST+TO8JYg +VoROb4TMiMuuMagnGrxw6SWT7rzRljPwnBZiIH0BaPOGmq1yPJ++v7U4x9fYQZwQcS1 dkI+SDVMIIhd54e3DCC8KP8F1TdgImnhrXdvKKcPgwNfQ1alYI/zeV0om5XYp8hg6Y1W +HH90oJ0q2NxmW53SY6hi1ftAXxB4wWBuzj+wz7x3X78zvFe+oSd1G/G+NpoHH+ayJa3 mqOdfb7JYWp8c9SbTdJa7TpvUXFK+VKzpIGJhGdgM7RoUC/Y1hCVjX5YtGE2Dt5ppwCj L2oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702398602; x=1703003402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q6IQU5ROwUn//RvfuUSFoOspGxqF5s4e8MRFf4fb5zU=; b=gMowKGbyiGYHpczZ+YlJ+FMd2W9kjwHnku/mNpXvR5MEvuOhpL0hEPxDeMUvAZ98Mz pRYEnCWM8deWovqjMs/bZqgdWe/j5gIGgYT19UNiDAIIa76r8FWirlqObamjZ6nokdZS OlC2LAtPJ1LeY9gUiS0vkTzyhLSzYsUSQlHKpDOlywWJ6l11XP2F79ULF8QF0mGzSyzZ yRUDuNqoaX7lER5lceDvuBBWCfaImwAgYRlednEa/we5kW4QlKjOEhLxusu2g/enbbW7 S6lwYaWpWznbV6YuaNHEB0DfTXXb9RCwDxWMix52IVX+Aa2EiuHMUtHBFynivUxCgQf4 plYg== X-Gm-Message-State: AOJu0YwOCmxPgldaiawe3PR3mR9iTS5+OLIFaWg+3v4wzi+HVSmcNsN/ 37vJHZoSq/XsgoqRSMqvdVEa7HlHEuzCp+MdFxE= X-Received: by 2002:a17:906:c112:b0:9d3:f436:61e5 with SMTP id do18-20020a170906c11200b009d3f43661e5mr3884569ejc.29.1702398602437; Tue, 12 Dec 2023 08:30:02 -0800 (PST) Received: from m1x-phil.lan ([176.176.175.193]) by smtp.gmail.com with ESMTPSA id rd12-20020a170907a28c00b00a097c5162b0sm6421593ejc.87.2023.12.12.08.30.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 08:30:02 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Tyrone Ting , =?utf-8?q?Alex_Benn=C3=A9e?= , Manos Pitsidianakis , Eduardo Habkost , Joel Stanley , Alistair Francis , Anton Johansson , Andrey Smirnov , Peter Maydell , Hao Wu , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Jean-Christophe Dubois , Igor Mitsyanko , "Edgar E. Iglesias" , Andrew Jeffery , Rob Herring , qemu-arm@nongnu.org, Mark Cave-Ayland , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH 03/33] hw/arm/fsl-imx6ul: Add a local 'gic' variable Date: Tue, 12 Dec 2023 17:29:03 +0100 Message-ID: <20231212162935.42910-4-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231212162935.42910-1-philmd@linaro.org> References: <20231212162935.42910-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::631; envelope-from=philmd@linaro.org; helo=mail-ej1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The A7MPCore forward the IRQs from its internal GIC. To make the code clearer, add a 'gic' variable. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater --- hw/arm/fsl-imx6ul.c | 38 ++++++++++++++------------------------ 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/hw/arm/fsl-imx6ul.c b/hw/arm/fsl-imx6ul.c index e37b69a5e1..59032263cf 100644 --- a/hw/arm/fsl-imx6ul.c +++ b/hw/arm/fsl-imx6ul.c @@ -156,6 +156,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) { MachineState *ms = MACHINE(qdev_get_machine()); FslIMX6ULState *s = FSL_IMX6UL(dev); + DeviceState *gic; int i; char name[NAME_SIZE]; SysBusDevice *sbd; @@ -177,6 +178,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) FSL_IMX6UL_MAX_IRQ + GIC_INTERNAL, &error_abort); sysbus_realize(SYS_BUS_DEVICE(&s->a7mpcore), &error_abort); sysbus_mmio_map(SYS_BUS_DEVICE(&s->a7mpcore), 0, FSL_IMX6UL_A7MPCORE_ADDR); + gic = DEVICE(&s->a7mpcore); sbd = SYS_BUS_DEVICE(&s->a7mpcore); d = DEVICE(&s->cpu); @@ -213,8 +215,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) FSL_IMX6UL_GPTn_ADDR[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpt[i]), 0, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_GPTn_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_GPTn_IRQ[i])); } /* @@ -238,8 +239,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) FSL_IMX6UL_EPITn_ADDR[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->epit[i]), 0, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_EPITn_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_EPITn_IRQ[i])); } /* @@ -276,12 +276,10 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) FSL_IMX6UL_GPIOn_ADDR[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio[i]), 0, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_GPIOn_LOW_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_GPIOn_LOW_IRQ[i])); sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio[i]), 1, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_GPIOn_HIGH_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_GPIOn_HIGH_IRQ[i])); } /* @@ -335,8 +333,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) FSL_IMX6UL_SPIn_ADDR[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->spi[i]), 0, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_SPIn_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_SPIn_IRQ[i])); } /* @@ -361,8 +358,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) sysbus_mmio_map(SYS_BUS_DEVICE(&s->i2c[i]), 0, FSL_IMX6UL_I2Cn_ADDR[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->i2c[i]), 0, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_I2Cn_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_I2Cn_IRQ[i])); } /* @@ -399,8 +395,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) FSL_IMX6UL_UARTn_ADDR[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->uart[i]), 0, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_UARTn_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_UARTn_IRQ[i])); } /* @@ -449,12 +444,10 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) FSL_IMX6UL_ENETn_ADDR[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->eth[i]), 0, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_ENETn_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_ENETn_IRQ[i])); sysbus_connect_irq(SYS_BUS_DEVICE(&s->eth[i]), 1, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_ENETn_TIMER_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_ENETn_TIMER_IRQ[i])); } /* @@ -490,8 +483,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) sysbus_mmio_map(SYS_BUS_DEVICE(&s->usb[i]), 0, FSL_IMX6UL_USB02_USBn_ADDR[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->usb[i]), 0, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_USBn_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_USBn_IRQ[i])); } /* @@ -516,8 +508,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) FSL_IMX6UL_USDHCn_ADDR[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->usdhc[i]), 0, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_USDHCn_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_USDHCn_IRQ[i])); } /* @@ -549,8 +540,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) sysbus_mmio_map(SYS_BUS_DEVICE(&s->wdt[i]), 0, FSL_IMX6UL_WDOGn_ADDR[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->wdt[i]), 0, - qdev_get_gpio_in(DEVICE(&s->a7mpcore), - FSL_IMX6UL_WDOGn_IRQ[i])); + qdev_get_gpio_in(gic, FSL_IMX6UL_WDOGn_IRQ[i])); } /*