From patchwork Wed Jan 10 19:53:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 761448 Delivered-To: patch@linaro.org Received: by 2002:a5d:6e02:0:b0:337:62d3:c6d5 with SMTP id h2csp2053026wrz; Wed, 10 Jan 2024 11:54:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsOdZ2GEckVrOphmehgdZ1x/a9JCqJqLGwqsBZpZSPRY702rdjp5MY7WTLwEH9pdagggul X-Received: by 2002:a05:622a:1742:b0:429:9e14:2402 with SMTP id l2-20020a05622a174200b004299e142402mr97932qtk.41.1704916486908; Wed, 10 Jan 2024 11:54:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704916486; cv=none; d=google.com; s=arc-20160816; b=bDOx1rBeM8VpxFnmRkWeJXTXZNkmuzNsB390iSXuhMfLPnq45Kc/2T0KuPpAeK7wOg vVKeDKib5uNXfdlSIkuuTIu35jU7VyPPuKxexCEdz+OxCH7So19dxp7rlcl+8R+78FYU KrWcZWuwXy19QqKKkKvfoUASfzz3kKcNw/ylvnStMBVtcFySBhwDXMsHxvZi0b+ctLGB mWgLmmoEFD0FPCikViQggZOphssMF+2WN7sKydfK0FxrP1u9G1wviefdMAvI/OEe803v CkMaafstNn6aMaMeo//Qca0ZdCUkCgDq2hyUhC3MlSX1wtXEkHWcHhPF5fduki/TDggh N1IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5n6b/Kfb2q1nuszk7kQnrf8+ZzcUeVpd0islGk5jF8M=; fh=0Bn9ysFO5uhdOoEvdDNDnkwY7yFMuDt2XLw3k0zcWt8=; b=Fy5Joqz65OS7vn7AsBMEERzY4/Wse960rqH/bX0YoO4HJcKiUWUZDz+N7pFnaQ+/un R7CB3Rp4P1oofzxKSeo8bFRe+M4ua68Ifffcqu+E+f7IFwOJHro+KYi9n1TQbmibNEY5 rR4NRHfbObc3PuMllZv7NThHGjQSMhWUDOCr3eGuc+X0oM0O6tF4A5J/eTcOtYCcLs3k C3CL3TRderfguKtrFwuOVH01GxFiqNnJhgzgxDRxC+JEGSZFn72rcjBnPy5lhb0sVl+I no5Yx6FPnEPXycSwaYzp7n3QQ5Rty0hY7s+54z7xwN9VN+r2SLbcnL49TQIPzw3tPx/U 5QzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P8u2pkKU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g9-20020ac85d49000000b00429836a9ca8si4739108qtx.453.2024.01.10.11.54.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Jan 2024 11:54:46 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P8u2pkKU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNeeh-0007Ml-JS; Wed, 10 Jan 2024 14:54:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNeeb-0007La-Hr for qemu-devel@nongnu.org; Wed, 10 Jan 2024 14:54:22 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNeeX-0002Dr-Ei for qemu-devel@nongnu.org; Wed, 10 Jan 2024 14:54:20 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40d87df95ddso47091045e9.0 for ; Wed, 10 Jan 2024 11:54:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704916455; x=1705521255; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5n6b/Kfb2q1nuszk7kQnrf8+ZzcUeVpd0islGk5jF8M=; b=P8u2pkKUDm9qusYFB0hPOw9BNkL0Mjmv/0Ha9QvvByjTVDjXCg1ziuVuDb6Ritcrj9 y+iZv87SxJgQ+iIbLPazwTsDCUKLnNGHkKkPNFVn673fkaWvsKxAGqeVPTQ9E2TdcLR6 fEFhUcfo1dIZS0sfjeIrRsb1EUYHqlrkLhsu6ycoCmQumFDSeGdoZExWhjjXpzuvZ4m4 nBImjFNrpMZASrMAfHn4MueLbFEIkzBiyXogKtfyCSe56jB44wUO9pQ6/BJnrfCipYIM ZNp8tS5ZLMtV9YwEQ0811Hgqjj2GIDefLVsyHfdwoav6JfuhnuhLiUP3QH4bYSUf+G7c LFGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704916455; x=1705521255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5n6b/Kfb2q1nuszk7kQnrf8+ZzcUeVpd0islGk5jF8M=; b=wkuKAIIgKMpo/PTPOPsJdYNtZsZQKR7c9KAzAzvFYPqaHtgYp6h32qZXfwBqYBIDPp 23UXShk8nhV8qT/kM8Ghh6opv6/nXaobLU5czeH0yt9LJrwyrsYwvQKdU76TbVhrOH5f VouzXNN3lPNUPuivbYFpR+h3L59CGFFhkeH01OC9ooQ+O1SVr81cHq6nd58YKbC6zMCW qgj/PSHcATqXnRCMwHridI8I77e5Zif7JsDTNBqKNtreTN63Ay0Cs6sveBEnGCRmxkHe uwH2jBPtgDItS8VOsZ1lJeTrGe96/HHnjgacjpFus1esatYTSMwGmfobqoTS/BgCg+u3 +JeQ== X-Gm-Message-State: AOJu0YwJ3Y7A4RUJvHeJg07t3mAIzN1DLh4OZIx2wCB7f6Pm8nlnm2gg FM09U01hWU744c43mZT2yJ6zBmITIk2gvryl66h9x4Pv+c8= X-Received: by 2002:a05:600c:538e:b0:40e:5cf9:9826 with SMTP id hg14-20020a05600c538e00b0040e5cf99826mr4786wmb.127.1704916455452; Wed, 10 Jan 2024 11:54:15 -0800 (PST) Received: from m1x-phil.lan (vau06-h02-176-184-43-236.dsl.sta.abo.bbox.fr. [176.184.43.236]) by smtp.gmail.com with ESMTPSA id z6-20020a05600c0a0600b0040e49045e0asm3209717wmp.48.2024.01.10.11.54.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 10 Jan 2024 11:54:15 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcin Juszkiewicz , qemu-arm@nongnu.org, Kevin Wolf , Igor Mitsyanko , =?utf-8?q?Alex_Benn=C3=A9e?= , Radoslaw Biernacki , "Edgar E. Iglesias" , Leif Lindholm , Rob Herring , Markus Armbruster , Alistair Francis , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PATCH v3 06/14] hw/arm: Prefer arm_feature(THUMB_DSP) over object_property_find(dsp) Date: Wed, 10 Jan 2024 20:53:20 +0100 Message-ID: <20240110195329.3995-7-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240110195329.3995-1-philmd@linaro.org> References: <20240110195329.3995-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The "dsp" property is added to ARMCPU when the ARM_FEATURE_THUMB_DSP feature is available. Rather than checking whether the QOM property is present, directly check the feature. Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/armv7m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 8350267d96..0a7ad2b762 100644 --- a/hw/arm/armv7m.c +++ b/hw/arm/armv7m.c @@ -321,7 +321,7 @@ static void armv7m_realize(DeviceState *dev, Error **errp) return; } } - if (object_property_find(OBJECT(s->cpu), "dsp")) { + if (arm_feature(&s->cpu->env, ARM_FEATURE_THUMB_DSP)) { if (!object_property_set_bool(OBJECT(s->cpu), "dsp", s->dsp, errp)) { return; }