From patchwork Tue Jan 23 10:28:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 765196 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:10c4:b0:337:62d3:c6d5 with SMTP id b4csp1530124wrx; Tue, 23 Jan 2024 02:30:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IH9cOgYNc6qmPHgN9mV0YfSqubzHh6atjETAgHdDbw7+ufD+K/NgNi3VG/bZKEz2S9ffDaS X-Received: by 2002:ac8:5f50:0:b0:42a:3c4e:a83f with SMTP id y16-20020ac85f50000000b0042a3c4ea83fmr866767qta.48.1706005815157; Tue, 23 Jan 2024 02:30:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706005815; cv=none; d=google.com; s=arc-20160816; b=cHgeWr6+kaPke2TqjpU7MLh5xt7JF3CmItIli1RCnxR1RYo3xCm0nVa34IefuEXTRA 8QEdPj6sH9qVMfzgNzbcal8659unU03pFRnDfbaplYB2PUHhqrSDp3B+Yb6IMbXj9MX3 rQL2APGeqZvUs7BIvpXo7H3x45S3WWuO4Kg7k7nO8r7ZD9xfSv6sKJiK0i0d0o64bYTh yUHIeiZh0sqPSEPz+REoIeDWDO4f4FeDurN4DjY7HDKYy/YORI8bVtdJwHoDY0KkUB+g FayQtzkIMW7EL0Cu/7Lrpu8xaCY/J2Ja5B/qj3QT1pmT757xti1bR23y3HglywXBT/tr ThIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=pkacqps7XAM7VdNrBLyfQpzFUHSUbjLgE/bn70yRv7k=; fh=vovulKOOEPtEUAefIa3xLdy/8Z9sLGgqEgHHDpSzEaU=; b=fy+DoQZQo3FRdj63uUr9hC8vTQe3J1rKVHxZ0vwoQWfRNSSMtdA7rmXJYecZJNVd4b XhlEpJaeFE0zXbWn9iYsnbpJ/i8uwlKiVkrhOCMQ/dIZXY6z9mcTC101fExsZWJ1f9Zx BcR1Q1pQcE+AmnMqPgu9F4RmgS53OCZyCY09LSkn86QKum200BylcmcJS6ZhII9jz7gu kSFcDx4AIgHEVR5OfhMEnJVJiHpNUXtqMr+LboSoGENwBZZA0tJpv70rbjer0YVWkjQm po54xu4k8B9TM4HmITdWHEXF8dujYR1TgJ9o3o1MWHz5MJlYqJeYDenaFqEMbcNsOSoz F/MQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d18-20020a05622a05d200b0042a2b9c0addsi7672037qtb.207.2024.01.23.02.30.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jan 2024 02:30:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSE1g-0006pV-UG; Tue, 23 Jan 2024 05:29:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSE1e-0006nz-R4; Tue, 23 Jan 2024 05:29:02 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSE1d-0005M2-6I; Tue, 23 Jan 2024 05:29:02 -0500 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 5CFF14674F; Tue, 23 Jan 2024 13:29:24 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id EE82E69AEB; Tue, 23 Jan 2024 13:28:43 +0300 (MSK) Received: (nullmailer pid 3831716 invoked by uid 1000); Tue, 23 Jan 2024 10:28:43 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , zhenwei pi , Gonglei , Markus Armbruster , Michael Tokarev Subject: [Stable-8.1.5 16/24] backends/cryptodev: Do not ignore throttle/backends Errors Date: Tue, 23 Jan 2024 13:28:30 +0300 Message-Id: <20240123102843.3831660-5-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Both cryptodev_backend_set_throttle() and CryptoDevBackendClass::init() can set their Error** argument. Do not ignore them, return early on failure. Without that, running into another failure trips error_setv()'s assertion. Use the ERRP_GUARD() macro as suggested in commit ae7c80a7bd ("error: New macro ERRP_GUARD()"). Cc: qemu-stable@nongnu.org Fixes: e7a775fd9f ("cryptodev: Account statistics") Fixes: 2580b452ff ("cryptodev: support QoS") Reviewed-by: zhenwei pi Reviewed-by: Gonglei Reviewed-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20231120150418.93443-1-philmd@linaro.org> (cherry picked from commit 484aecf2d3a75251b63481be2a0c3aef635002af) Signed-off-by: Michael Tokarev diff --git a/backends/cryptodev.c b/backends/cryptodev.c index 4d183f7237..236c407ad0 100644 --- a/backends/cryptodev.c +++ b/backends/cryptodev.c @@ -398,6 +398,7 @@ static void cryptodev_backend_set_ops(Object *obj, Visitor *v, static void cryptodev_backend_complete(UserCreatable *uc, Error **errp) { + ERRP_GUARD(); CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc); CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc); uint32_t services; @@ -406,11 +407,20 @@ cryptodev_backend_complete(UserCreatable *uc, Error **errp) QTAILQ_INIT(&backend->opinfos); value = backend->tc.buckets[THROTTLE_OPS_TOTAL].avg; cryptodev_backend_set_throttle(backend, THROTTLE_OPS_TOTAL, value, errp); + if (*errp) { + return; + } value = backend->tc.buckets[THROTTLE_BPS_TOTAL].avg; cryptodev_backend_set_throttle(backend, THROTTLE_BPS_TOTAL, value, errp); + if (*errp) { + return; + } if (bc->init) { bc->init(backend, errp); + if (*errp) { + return; + } } services = backend->conf.crypto_services;