From patchwork Tue Feb 13 13:03:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 772308 Delivered-To: patch@linaro.org Received: by 2002:adf:9dc2:0:b0:33b:4db1:f5b3 with SMTP id q2csp241993wre; Tue, 13 Feb 2024 05:06:00 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXHJzVxINvva6VlRznPC2WYIWC4oPlSmZY3DelF/UFMuE6qNM/6Q5TMqyS6hgLzxzr+l0uQf3JfEmqjgZInalZK X-Google-Smtp-Source: AGHT+IEg6S7k3nXCVWCdEb2KzRxhgYSgWUvfGFjfyZX3H3TBxjh/d7Om9+9vo8DXWzjXXUnY6I0Y X-Received: by 2002:a67:fd87:0:b0:46d:3e3e:c71f with SMTP id k7-20020a67fd87000000b0046d3e3ec71fmr7910427vsq.4.1707829559948; Tue, 13 Feb 2024 05:05:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1707829559; cv=none; d=google.com; s=arc-20160816; b=xSLJCiHiiKge5riPkYGPt4lP6lTs+TUat3CSIJo3FJoeddHcaAAOFm5VwOTYZgNsRw Z2OAa3Uz3tekd4Z53S5hXDJL4JVmiL5NT5FMKmAgqd+85VHD/3r9C0pg2488p4MeNgpM pbpNItU568MTscdcMuo4Djwv/9z6pI/ii3XQOayGKMAluAJlxb0SLkGkyl7V5+Av2H0j kYvfz7qi5cPzVWYyprEUUa+ioXjszrjY4lkzAIdSt87BJL5tEYnLruePrcZLw35uIWq2 /OSkNBQQ8AE5iVcFVZZHtuqEubSsyiBCqfBOizoHCAPwNLKRNb+xgUazV7scdr3CVHt1 XxrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=O7zS4al2xd0Nh3hgWRIRyTwhfz5nLFlDSJ2u8jBzRpc=; fh=GwMoGFNbbKjxtur+XEdW6BGj2snBYtnWOYKACNhO/UQ=; b=YE4hWDIy9zNepA8Cw3uwft8yrnV6WnSxF+76En3Bhcyvk/Z0CpgBKe0WiCui5Vd9On Dc/pAg4CKzSJ8SycqOSYf49qavB6b9N7QnKyLgvKzBeqlmL4LopsX2PI8ysc/62o3iLN jWHVFcTZ4wRqaPQ44AaW9JgQ8OkDKfWnBlMIhLvtVhDFQlfDB01OkxQUuLIm8Ag25RwH qtybEygoIlxV2FdANIawjXpyNACDzZZf3Ntikj+pcyMXXXr2ZaRzLpu+Cph8FKj0eWTm JA+haAfSkEepX4c7o29HuuqVDQ8X2oGa0XzmIwuBTZw4DzHgiZC1L26r2scsOVubpBUt FT6Q==; darn=linaro.org ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pfFhyoS8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=1; AJvYcCXezHQsOy90vt7NhIA968EMuu+8WssrP5y490UtvcAoty6AObqN5dtR0PnrrkVaD+HieWKDyxlOoMUrTkxsDgiT Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k3-20020a056102082300b0046afbbbd4ccsi971890vsb.34.2024.02.13.05.05.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Feb 2024 05:05:59 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pfFhyoS8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZsTl-0002dY-Bj; Tue, 13 Feb 2024 08:05:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZsSd-00020H-QT for qemu-devel@nongnu.org; Tue, 13 Feb 2024 08:04:32 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZsSZ-000658-QA for qemu-devel@nongnu.org; Tue, 13 Feb 2024 08:04:31 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3394bec856fso3155776f8f.0 for ; Tue, 13 Feb 2024 05:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707829459; x=1708434259; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O7zS4al2xd0Nh3hgWRIRyTwhfz5nLFlDSJ2u8jBzRpc=; b=pfFhyoS8RBCBOz+qNft59s7Rj1NCwwvIZOxPlQH5hJPfp2ViXevRuFmvYgXzUBgiwK +BLRDe/2KysYGQnpg+kHqEFgNXPeuaGhmofOXt8lryAirax9YechQ4fBY/LJFoRxKo6b mfnTCAP7Bz7XIMfrTh6GEQYAcC4jJPMdKBURlt2EPaWZtbcPXHVHRDrFvhsxLvrBddd9 mlIUi7F08GxDVpTyz3Ptyjf7LtCfPrxbglpk3obFasve0zR2fuvsGTBxsD8SKQN7am80 dOf2F7VtDkfmMvyzIGd8nVKqtPyKG+qUYsuckeIuog8nwTQUOy9Xh6p6HchiWYoSIYHN 09CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707829459; x=1708434259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O7zS4al2xd0Nh3hgWRIRyTwhfz5nLFlDSJ2u8jBzRpc=; b=m5SuRt+DqvoLSKaCHi98lTKX2WsfbMKUZ261D/PMeDWD4Trxx4655i1Yl1l6FXnnMU tWM++exigEAdGpUUt+PYSGdtHutM7Z//CSENO6CJxU8R4kfGKiQyBvLpZdThZXZHy3wV UIBZWhDGE1dUVOFvRNAE3f9fw/HO87w9wAGYXhfVbd1S3A7/2pnVOQ0IfdlZhHdsm7FR L28uRlfZvRoh4o9FjZWthfujP7i8ozlPDv9P6TbaWgBWsVqFtX76Leej1/ZQfuLKaNvw 7CIhy698mUA7T3un7oRS7LKEDlsfKCxQLfa+DaTNg3wZmX10Wtu821JGYF6BFsw0RL+k 3OuA== X-Gm-Message-State: AOJu0YwlBvCWlKoA3ev16K0UkPku8WopT0QmiGxuEFLpkZIdOX/bD/Yq kmTv/oSgErOoUTEei7yZEAVOXC8JP3imIcDV2iiKGlium09UpBbMXbGlMFNsZRy9wwgvZDdFNpC c X-Received: by 2002:adf:f546:0:b0:33c:d852:8e50 with SMTP id j6-20020adff546000000b0033cd8528e50mr1575682wrp.6.1707829458921; Tue, 13 Feb 2024 05:04:18 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXZDPnYR47Ipvqgf5m3G/oOa0hCnEnYFyBtQ+VtnT3GFQRxp8s4QVzZNacjJdQ3pCTbza38kssUxzg+11QrvQCLNzVw0yQbtKYVWNXuDlL9s+W6TTn45FA32DooHtDvv2GxmHOBuUrdp8sn2XBO4YftlhVwhL1htVzAaT+jMAc+5+tgymwwW3BUxmlRmj9yv1FLP0ZIZy5Syz0mJqMC0ezOJu1ACKKaxVtHfp6hm4HvWH3h4+bR8nEfjAPQDBpxadkhHIxa91h/i8a4IEaIWz7Gl1v7QQNi5cSxWveCK7HTDnn6JbLIrT4V+cs2v+FOK3woNsph/e3LahuGkAWty5xQL5fINpOMotMi0fgYZ3s2KukEZUcU0bKXTmpbxn0CFlIUCJoC02A= Received: from m1x-phil.lan ([176.176.128.243]) by smtp.gmail.com with ESMTPSA id bj8-20020a0560001e0800b0033b3ca3a255sm9529863wrb.19.2024.02.13.05.04.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 13 Feb 2024 05:04:18 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Bernhard Beschow , Paolo Bonzini , Mark Cave-Ayland , Richard Henderson , BALATON Zoltan , "Michael S. Tsirkin" , qemu-block@nongnu.org, qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Peter Maydell , =?utf-8?q?Herv=C3=A9_Poussineau?= Subject: [PATCH v4 05/12] hw/ppc/prep: Realize ISA bridge before accessing it Date: Tue, 13 Feb 2024 14:03:34 +0100 Message-ID: <20240213130341.1793-6-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240213130341.1793-1-philmd@linaro.org> References: <20240213130341.1793-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Mark Cave-Ayland --- hw/ppc/prep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index 1a6cd05c61..4eb5477069 100644 --- a/hw/ppc/prep.c +++ b/hw/ppc/prep.c @@ -278,9 +278,9 @@ static void ibm_40p_init(MachineState *machine) /* PCI -> ISA bridge */ i82378_dev = DEVICE(pci_new(PCI_DEVFN(11, 0), "i82378")); + qdev_realize_and_unref(i82378_dev, BUS(pci_bus), &error_fatal); qdev_connect_gpio_out(i82378_dev, 0, qdev_get_gpio_in(DEVICE(cpu), PPC6xx_INPUT_INT)); - qdev_realize_and_unref(i82378_dev, BUS(pci_bus), &error_fatal); sysbus_connect_irq(pcihost, 0, qdev_get_gpio_in(i82378_dev, 15)); isa_bus = ISA_BUS(qdev_get_child_bus(i82378_dev, "isa.0"));