From patchwork Thu Feb 15 10:50:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 772890 Delivered-To: patch@linaro.org Received: by 2002:adf:9dc2:0:b0:33b:4db1:f5b3 with SMTP id q2csp761314wre; Thu, 15 Feb 2024 02:51:29 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWNA7RuXmguPORhpd9NSIR884InyOt7OnwS1e8L2L1WpkkcP67JrmZrrLohDjHjMWhlpHo1enr0J3Gx6tVgbznW X-Google-Smtp-Source: AGHT+IFNYfVzb4hbsxG+6yie/FSKwLIWVB5IRUSEkFetB7Z7SJ0hsCG1m6ErsWnmqk8CT4C+6Tcv X-Received: by 2002:a05:6102:2924:b0:46d:6dfb:bfc4 with SMTP id cz36-20020a056102292400b0046d6dfbbfc4mr1884078vsb.6.1707994289003; Thu, 15 Feb 2024 02:51:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1707994288; cv=none; d=google.com; s=arc-20160816; b=yqjk7t/JPcHT0w501D13ON/j5JscySo12L0McYVptOUhu52PpUGd/ltkikQAMXaiEr 2RzjQiSeoXIdQ9pvrwn5o428Atf+iPR2wsQIC3+NxRn7xyFplfJ5WVKi/gS94rH2IBLc YyX6DCIknoIL4fa8sQGFwT+m4x5a2LrC6LH0AFNSec8+YSToU6oRJyQPAKI1g4pGSAQB R+6xYieKnBWUB2i3POTAsNNx7n2KnkFSzV7Px3LGO4QpWBZ0KFKrnzmjE0kht7DRhdsm NJJ+wtmsrWQvvUrOKdw+FmPyUnKc/9MVQ0HggrFymTPnKhul4brhehVXSIqNTYmm09lO RkYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rih3/8Q+RSzgWPVyG4FhwvSTAtV5rhc3hhCf8/R/bOI=; fh=A+lY13+jFVcdA8ecQ4hcAHs/x8ylQFF0oU/oe2DVPZ8=; b=DtBBX+egur2Xh5tw7YZa92qo6bAaRndsxtKTuIcIDnaWEExz940m+Rle6LAHsIY+nG vQSpq6iBx645T0hG7GQyDs4OHFGP0Io7IVyVSjjML/FZzL5kF2Rg/B3vWbp00zsN8ggU DwbpSfJqinc9QkXD4tI7jf7SpCVeUZvZibhlM8Jxk4awRzIzSR7PBrpFzXwz0q4ZVS34 uYvJehUh/zJSMQWqaa5EX8mQOO7rmbnvhs0uyyLDlp6o0WlySFrtyH2iwTgl0eQPq1EY O5S/NxnWufxP9/2uydYqYLkI3X2L1AI5VIHijgBsC3q6N4AfY7iF7r2oCBG3jF42y6fv +9jw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xxYhAtXy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w2-20020ac857c2000000b0042c7737be89si1119547qta.580.2024.02.15.02.51.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Feb 2024 02:51:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xxYhAtXy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raZKV-00024J-R4; Thu, 15 Feb 2024 05:51:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raZKL-0001zP-0k for qemu-devel@nongnu.org; Thu, 15 Feb 2024 05:50:49 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raZKJ-0007eP-8o for qemu-devel@nongnu.org; Thu, 15 Feb 2024 05:50:48 -0500 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5639ffbcc10so875765a12.0 for ; Thu, 15 Feb 2024 02:50:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707994245; x=1708599045; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rih3/8Q+RSzgWPVyG4FhwvSTAtV5rhc3hhCf8/R/bOI=; b=xxYhAtXyqQ69blwcS9f9E93Ew7+F3iW1EN67x+cVkBuk/eifb84GR3nDJVnjEcEite CdZPji4P5GOIbvwk1NLWMWwWlI5T+I+OS/aoqw066RKg29adw6Rax1UancyvP+OLtCZm JuNNsj+Km5C1m8S8TSXWEwuWDdJa5LLcZFJCSBv0FOAhYmGpffcnaZFpPZxzh9vtZJhi pHEU2zT874kkasQTZmiMUY7kDqMAW6XWtXExSrLKL4P6DhyvoUFbCByWou1dyizXclKv 3Qf6wlS70NaN88xT3qqhfFPTuwdr/DOJ6xZX5iooj2LAtSKgSAJPfagVF1n3nautyFOH RzSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707994245; x=1708599045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rih3/8Q+RSzgWPVyG4FhwvSTAtV5rhc3hhCf8/R/bOI=; b=cXeuwqBDU/7x/JKGLL8zzT2lNmQvkboLuQ7ssYIGTefo3xdKKkUu8F7cWUIZmzhnW4 nPjgKQ+b59Yme17QZ4Z37+deh8UIZT7om6SdkECxQNo+9XQEBWy3U6YfjpZax7AGrK4f enEsWgAIpD2V7YfG5W6E8x37kc+mtEKdHLhJRPwQqthOzq0TpOmp2jVL+ClGIlP+JFmm ooPhr4bMrKM50OpnqfAevYl0WEINidstduJhjqxrGKU3tpdcudnnqNdwneo5DprHUxp5 d6RUZdr4OyvnTeW3KbU2zv+qYMJnbMNlxewt/uB+QMV5y91M7XCbS+nQ5gouo9K5TRt5 hOPw== X-Gm-Message-State: AOJu0YyiN68d+6pS0lTBbK6uXGRwL4kZe9z9pv2mhKz3Az9GtLJF5BHr fOrzZCcME4wPck+y4u3BiycTzuqt+l6l1soBa97d3AdUyttitvffWN91cEkjdSaZz0NyOTJ4ZaR E7VI= X-Received: by 2002:aa7:d148:0:b0:563:c54e:f7 with SMTP id r8-20020aa7d148000000b00563c54e00f7mr217880edo.17.1707994245622; Thu, 15 Feb 2024 02:50:45 -0800 (PST) Received: from localhost.localdomain ([92.88.170.215]) by smtp.gmail.com with ESMTPSA id u26-20020a50a41a000000b0056392b7d85fsm446683edb.9.2024.02.15.02.50.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 15 Feb 2024 02:50:45 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc@nongnu.org, =?utf-8?q?C?= =?utf-8?q?=C3=A9dric_Le_Goater?= , Nicholas Piggin , BALATON Zoltan , Daniel Henrique Barboza , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v3 4/4] hw/ppc/ppc440_pcix: Move ppc440_pcix.c to hw/pci-host/ Date: Thu, 15 Feb 2024 11:50:16 +0100 Message-ID: <20240215105017.57748-5-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240215105017.57748-1-philmd@linaro.org> References: <20240215105017.57748-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=philmd@linaro.org; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org ppc440_pcix.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/{ppc => pci-host}/ppc440_pcix.c | 0 hw/pci-host/Kconfig | 4 ++++ hw/pci-host/meson.build | 1 + hw/pci-host/trace-events | 8 ++++++++ hw/ppc/Kconfig | 1 + hw/ppc/meson.build | 2 +- hw/ppc/trace-events | 8 -------- 8 files changed, 16 insertions(+), 10 deletions(-) rename hw/{ppc => pci-host}/ppc440_pcix.c (100%) diff --git a/MAINTAINERS b/MAINTAINERS index b24f7e7e60..4eb98973d7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1554,7 +1554,7 @@ L: qemu-ppc@nongnu.org S: Maintained F: hw/ppc/sam460ex.c F: hw/ppc/ppc440_uc.c -F: hw/ppc/ppc440_pcix.c +F: hw/pci-host/ppc440_pcix.c F: hw/display/sm501* F: hw/ide/sii3112.c F: hw/rtc/m41t80.c diff --git a/hw/ppc/ppc440_pcix.c b/hw/pci-host/ppc440_pcix.c similarity index 100% rename from hw/ppc/ppc440_pcix.c rename to hw/pci-host/ppc440_pcix.c diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig index 0a221e719e..c91880b237 100644 --- a/hw/pci-host/Kconfig +++ b/hw/pci-host/Kconfig @@ -10,6 +10,10 @@ config PPC4XX_PCI bool select PCI +config PPC440_PCIX + bool + select PCI + config RAVEN_PCI bool select PCI diff --git a/hw/pci-host/meson.build b/hw/pci-host/meson.build index eb6dc71c88..3001e93a43 100644 --- a/hw/pci-host/meson.build +++ b/hw/pci-host/meson.build @@ -15,6 +15,7 @@ pci_ss.add(when: 'CONFIG_SH_PCI', if_true: files('sh_pci.c')) # PPC devices pci_ss.add(when: 'CONFIG_PPC4XX_PCI', if_true: files('ppc4xx_pci.c')) +pci_ss.add(when: 'CONFIG_PPC440_PCIX', if_true: files('ppc440_pcix.c')) pci_ss.add(when: 'CONFIG_RAVEN_PCI', if_true: files('raven.c')) pci_ss.add(when: 'CONFIG_GRACKLE_PCI', if_true: files('grackle.c')) # NewWorld PowerMac diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events index 90a37ebff0..0a816b9aa1 100644 --- a/hw/pci-host/trace-events +++ b/hw/pci-host/trace-events @@ -41,6 +41,14 @@ unin_read(uint64_t addr, uint64_t value) "addr=0x%" PRIx64 " val=0x%"PRIx64 ppc4xx_pci_map_irq(int32_t devfn, int irq_num, int slot) "devfn 0x%x irq %d -> %d" ppc4xx_pci_set_irq(int irq_num) "PCI irq %d" +# ppc440_pcix.c +ppc440_pcix_map_irq(int32_t devfn, int irq_num, int slot) "devfn 0x%x irq %d -> %d" +ppc440_pcix_set_irq(int irq_num) "PCI irq %d" +ppc440_pcix_update_pim(int idx, uint64_t size, uint64_t la) "Added window %d of size=0x%" PRIx64 " to CPU=0x%" PRIx64 +ppc440_pcix_update_pom(int idx, uint32_t size, uint64_t la, uint64_t pcia) "Added window %d of size=0x%x from CPU=0x%" PRIx64 " to PCI=0x%" PRIx64 +ppc440_pcix_reg_read(uint64_t addr, uint32_t val) "addr 0x%" PRIx64 " = 0x%" PRIx32 +ppc440_pcix_reg_write(uint64_t addr, uint32_t val, uint32_t size) "addr 0x%" PRIx64 " = 0x%" PRIx32 " size 0x%" PRIx32 + # pnv_phb4.c pnv_phb4_xive_notify(uint64_t notif_port, uint64_t data) "notif=@0x%"PRIx64" data=0x%"PRIx64 pnv_phb4_xive_notify_ic(uint64_t addr, uint64_t data) "addr=@0x%"PRIx64" data=0x%"PRIx64 diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 82e847d22c..99d571fa20 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -46,6 +46,7 @@ config PPC440 imply TEST_DEVICES imply E1000_PCI select PCI_EXPRESS + select PPC440_PCIX select PPC4XX select SERIAL select FDT_PPC diff --git a/hw/ppc/meson.build b/hw/ppc/meson.build index d0efc0aba5..da14fccce5 100644 --- a/hw/ppc/meson.build +++ b/hw/ppc/meson.build @@ -60,7 +60,7 @@ ppc_ss.add(when: 'CONFIG_PPC405', if_true: files( 'ppc405_uc.c')) ppc_ss.add(when: 'CONFIG_PPC440', if_true: files( 'ppc440_bamboo.c', - 'ppc440_pcix.c', 'ppc440_uc.c')) + 'ppc440_uc.c')) ppc_ss.add(when: 'CONFIG_PPC4XX', if_true: files( 'ppc4xx_devs.c', 'ppc4xx_sdram.c')) diff --git a/hw/ppc/trace-events b/hw/ppc/trace-events index b59fbf340f..157ea756e9 100644 --- a/hw/ppc/trace-events +++ b/hw/ppc/trace-events @@ -146,14 +146,6 @@ rs6000mc_size_read(uint32_t addr, uint32_t val) "read addr=0x%x val=0x%x" rs6000mc_size_write(uint32_t addr, uint32_t val) "write addr=0x%x val=0x%x" rs6000mc_parity_read(uint32_t addr, uint32_t val) "read addr=0x%x val=0x%x" -# ppc440_pcix.c -ppc440_pcix_map_irq(int32_t devfn, int irq_num, int slot) "devfn 0x%x irq %d -> %d" -ppc440_pcix_set_irq(int irq_num) "PCI irq %d" -ppc440_pcix_update_pim(int idx, uint64_t size, uint64_t la) "Added window %d of size=0x%" PRIx64 " to CPU=0x%" PRIx64 -ppc440_pcix_update_pom(int idx, uint32_t size, uint64_t la, uint64_t pcia) "Added window %d of size=0x%x from CPU=0x%" PRIx64 " to PCI=0x%" PRIx64 -ppc440_pcix_reg_read(uint64_t addr, uint32_t val) "addr 0x%" PRIx64 " = 0x%" PRIx32 -ppc440_pcix_reg_write(uint64_t addr, uint32_t val, uint32_t size) "addr 0x%" PRIx64 " = 0x%" PRIx32 " size 0x%" PRIx32 - # ppc405_boards.c opba_readb(uint64_t addr, uint32_t val) "addr 0x%" PRIx64 " = 0x%" PRIx32 opba_writeb(uint64_t addr, uint64_t val) "addr 0x%" PRIx64 " = 0x%" PRIx64