From patchwork Fri Feb 16 11:03:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 773314 Delivered-To: patch@linaro.org Received: by 2002:adf:9dc2:0:b0:33b:4db1:f5b3 with SMTP id q2csp1285934wre; Fri, 16 Feb 2024 03:05:37 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUpxTNvSoQsmstUOM873uxddOPvPIVcxDWYn5ZL4hNDxTaGmFiFcebLpP74u3IdaPjVZp7OB7Zj3zjXd1f5MPJP X-Google-Smtp-Source: AGHT+IH9llWlQMwg7RDiDe3fbHUxFTlnZjUNIvDsvxlm8J9JQ6LIQzQGQ/xU6tFkeL2WWWQorWb9 X-Received: by 2002:a0c:df88:0:b0:68d:a591:80e5 with SMTP id w8-20020a0cdf88000000b0068da59180e5mr4872709qvl.39.1708081537613; Fri, 16 Feb 2024 03:05:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708081537; cv=none; d=google.com; s=arc-20160816; b=mkgs/gzXXOixvRkalBdCkGPSu7eXBETnK2xReVsK8RgHiLn+insMUCWAZJ0rl+gRox KD3rh0PynWOeXPlB+88KFxv6uIBZbvMTgT1+Gqj/ja4VtoIxf1EBdVnXQERvj8nHbIJl KRiSFOb8eyu94GGxvgakqDAdPT61zLZh98QV25NAprnSkDi18y6dr6ccT/4fZL0GjWgZ lJNHsEqjchNu//8g6B/dZyJxHwkmvqam+AErOFe6GU/rlPw3nEhHZgrC5gVnfZSJdJ++ EKli7BwBkFne50eGyKNvPR8YgFDgtIUd5pts016wX7E3WFAFW9MHFsx9MDzGFPkQFrVy oVlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lSddd7wgwT+Aw6mIanqA0vHkbVR0NSdWvof0YaVRHNk=; fh=PpPyNa5GEKuCuMie00PQMipI4hymEaRA6fmXgxwYmp4=; b=Y/423NIt0M6K6GOaNoU7ZKhUN2AZL0C/6bIrnGJDzWYWg/dYFsSsUNT+LsWqS8bu8i rFvZUMDZkk7kXujCatl9qvj/QMzsOO1iu5vtt97v2489jtNHWePYT2C5YUQxXo6FV6Kk 1aF/6D6JlSBj6rd5YVyJUeuRKfHxSmwYVd+BlXoZaDyvJDZdu6QgR0jlngUmXWbMwI2E AoWLdFhUqOZ3xG54gQqRczK6KVHzX2m8d15co7XG+hz2RwoO35AaGOULFiIoKyDapc/Y DqaBxSoJ58nD7pk855V/yM2lsdaC9VVxv0TVmenQRzLNUwzMfESrfuMS5jT4vgq/46gS BI7A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WbTSvauY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id jk15-20020ad45d4f000000b0068cccc3bfbcsi3729022qvb.470.2024.02.16.03.05.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Feb 2024 03:05:37 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WbTSvauY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raw1J-0007vz-Ux; Fri, 16 Feb 2024 06:04:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raw1I-0007ob-3R for qemu-devel@nongnu.org; Fri, 16 Feb 2024 06:04:40 -0500 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raw1F-00015c-3m for qemu-devel@nongnu.org; Fri, 16 Feb 2024 06:04:39 -0500 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2d10d2da73dso24658561fa.1 for ; Fri, 16 Feb 2024 03:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708081475; x=1708686275; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lSddd7wgwT+Aw6mIanqA0vHkbVR0NSdWvof0YaVRHNk=; b=WbTSvauYQUvypxaPw7bit1QwCQNsVWwbnLkc3pLQ68kU9yiuZL51QGjnbMpjGQgW/C ziDpm3zbxWJdm/MB1GDpF7+r6//ZHSuOvioOGfhD626hWVbYXbBQczQm7paG7LWidfVU zcWMU418X6f6M9AYr37k6OAcK+7gcUDFOqjWVHD7p5U4Can6PBstIius9Z5OcUbtV4Ar aVzZL2kIN32tUZqF9TncJ6EtMFOtw3wIQMy8C5g/IVxgTUbvnEiqa0BgTCmFXHdBvwly zmMfizwkmlqej5VHWsqe1U8xmd6pUurRXbrATufityGMy+RS30LWkOeXilgea0EWponF lRYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708081475; x=1708686275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lSddd7wgwT+Aw6mIanqA0vHkbVR0NSdWvof0YaVRHNk=; b=jGfMPCuY0Ix4gWJkApVq0mzmHlSRVetQnaYEn7k6YMUOg9ixRVXOoB+wfo2XYy2JqS A+i1kcjAoGmhBj8iE+Ea0adtBdOih3HYNqOxThR60BjYSnNVg0wpMXjqzM4LwXjQM/Yc 7f2rv+0wSZERWBwWF2hnBFDvoOebVHs621cjyhdPz7OXkcHl+UzfkfaInlsKeNwnO6f8 Uwi/C6Hf1x8sXjIeI2/qm5C+nj3SOu7DPfh+4nOw6Ce6rk6W+Oc0kq7iF5esyW0qUCQP Tg5gkaSnMNxfdt1lWkgv6ycqiKvQ1m0e8chjJdUOdvEGdoy5lrpByglBSpAxWlaqrn+j vwvw== X-Gm-Message-State: AOJu0Yze2d0ptQVrz331EovXJQBZER48r6EAziVtewcTkHKgK7QhwdGb u4BzJNQ/D9CHHvphsvHKdXl7Ib1QWtZ4lMrbVbhAwhs5CreJZXfI4430CMsAv6lac7X2LE20C7g O X-Received: by 2002:a2e:9247:0:b0:2d1:1e31:c178 with SMTP id v7-20020a2e9247000000b002d11e31c178mr3333201ljg.17.1708081475351; Fri, 16 Feb 2024 03:04:35 -0800 (PST) Received: from m1x-phil.lan ([176.187.210.246]) by smtp.gmail.com with ESMTPSA id iv6-20020a05600c548600b004103e15441dsm2036535wmb.6.2024.02.16.03.04.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 16 Feb 2024 03:04:34 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, qemu-block@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Marcel Apfelbaum Subject: [PATCH 12/21] hw/pci-host/q35: Update q35_host_props[] comment Date: Fri, 16 Feb 2024 12:03:03 +0100 Message-ID: <20240216110313.17039-13-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240216110313.17039-1-philmd@linaro.org> References: <20240216110313.17039-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::22d; envelope-from=philmd@linaro.org; helo=mail-lj1-x22d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Commit aff39be0ed ("hw/pci-host: Use object_initialize_child for correct reference counting") replaced object_initialize() by object_initialize_child(), update the comment. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/q35.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 0d7d4e3f08..0eb1c7034d 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -165,10 +165,10 @@ static void q35_host_get_pci_hole64_end(Object *obj, Visitor *v, /* * NOTE: setting defaults for the mch.* fields in this table * doesn't work, because mch is a separate QOM object that is - * zeroed by the object_initialize(&s->mch, ...) call inside + * zeroed by the object_initialize_child(..., &s->mch, ...) call inside * q35_host_initfn(). The default values for those * properties need to be initialized manually by - * q35_host_initfn() after the object_initialize() call. + * q35_host_initfn() after the object_initialize_child() call. */ static Property q35_host_props[] = { DEFINE_PROP_UINT64(PCIE_HOST_MCFG_BASE, Q35PCIHost, parent_obj.base_addr, @@ -211,7 +211,7 @@ static void q35_host_initfn(Object *obj) object_initialize_child(OBJECT(s), "mch", &s->mch, TYPE_MCH_PCI_DEVICE); qdev_prop_set_int32(DEVICE(&s->mch), "addr", PCI_DEVFN(0, 0)); qdev_prop_set_bit(DEVICE(&s->mch), "multifunction", false); - /* mch's object_initialize resets the default value, set it again */ + /* mch's object_initialize_child resets the default value, set it again */ qdev_prop_set_uint64(DEVICE(s), PCI_HOST_PROP_PCI_HOLE64_SIZE, Q35_PCI_HOST_HOLE64_SIZE_DEFAULT); object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_START, "uint32",