From patchwork Sat Mar 9 17:51:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 779156 Delivered-To: patch@linaro.org Received: by 2002:a5d:604e:0:b0:33e:7753:30bd with SMTP id j14csp826911wrt; Sat, 9 Mar 2024 09:52:27 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXdQaNj719/+6VBoAAzqvMdX1OI/hKK8njSQOQanu/6ujaE9RV1heJFZ9o5jyvpXrTCkjtximaTCFjqOAYDjE5d X-Google-Smtp-Source: AGHT+IFUyP9cE0/xbIbigxogTkQdKEoOc1Ch5jDJpdtBwO2Lt2+4nsUJtOSNVPGsQW/SFd8LeIwR X-Received: by 2002:a05:6214:ac8:b0:690:b39e:97bc with SMTP id g8-20020a0562140ac800b00690b39e97bcmr5759898qvi.0.1710006746794; Sat, 09 Mar 2024 09:52:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1710006746; cv=none; d=google.com; s=arc-20160816; b=cSlwiRPFMKh3dTiYeHNWmn5OWQuFsBePlYHLWyhEKUd+G86nXI0d9X+3K6Ht8p8dVM 5hjyH0AKxpPMF8+RB4fjOWEncrqnDh/wBPcwHKFoDhxU94guY55Kp4nYxkw96MW4ruOv XV7YijJ9je5vNiaapVnYVOI7/XahFZpS+KDbuTSYOrZm3kSLrbqUHdhAWRf7abj/angf bysTSN5plZWGG0D4G10nzcfNdN9FsnR1bJZVHdTKRMZoU3J7I7FN4Y5fQQsktV/PjgpK hean1jF4jbhrg5jY1hzsLwrfprSPMOIW1GLRehTMk7SnB7cp1UpyNev+b36mJYg2iPZF L8NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pxxy6rYsXE+YgbqfLQwa9qOUOHg4ePBRyOPqmtL2n8Q=; fh=OttSa3rsn1ys6itlbFUVpX2XKbw9wl/b8VK1I3b6cJ4=; b=skdr2/2cGDgFQG4lo4A9yW/JpcvXwrGe3KJovr6YIoFGkumo+ElRNlqj/AHJWLy7Eu v7I9+ls0rkXszkul1AwyeTXvm4Q95R7rMbM6ocEez+GERcEv2ncaRBHsPxeEE8RiEzJo 78FS/nH3T6XTTECENNCBBPhehztp3gAawMz1xF9NVXfMxMmCmzMx/C7oAP0p32a5JILl ENAg/u8/+oUXEJLoIWsS+3ctOsXLV+ttNN0pR3yQV7nFVKnubr/iWj+Cs1bXj/uEptj5 IeA00FT1vbQkGmLOVVufJCDDnsc5KyqnW67hhKJ/c70/wDqJfVKVNbLuqD9ApNmtf4Kx mbjg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DAEoAIuT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id jk7-20020ad45d47000000b006903e81e4bbsi382653qvb.482.2024.03.09.09.52.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Mar 2024 09:52:26 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DAEoAIuT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rj0ql-0005e3-Tf; Sat, 09 Mar 2024 12:51:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rj0qk-0005dZ-9T for qemu-devel@nongnu.org; Sat, 09 Mar 2024 12:51:10 -0500 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rj0qi-0004tK-R7 for qemu-devel@nongnu.org; Sat, 09 Mar 2024 12:51:10 -0500 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-5dcc4076c13so2086329a12.0 for ; Sat, 09 Mar 2024 09:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710006666; x=1710611466; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pxxy6rYsXE+YgbqfLQwa9qOUOHg4ePBRyOPqmtL2n8Q=; b=DAEoAIuTkSeNkp6FY4+Ik2YIG6lZOc/bwHop7S8ZMywcd+AE31J+coKADvHDkAwF6L Z65oHEnJu0htjzqU1o3s7nop7QBD6FX8RgoLnc2vr8Jt7DTwzgIxBbxQfxcUujDhgwXp S96o86C4aQgPkG3lWEENE87h28A3+5yH3OPAuvzsZuW+0AZutV0WYqUr4jzo9y5UZcIA vOEE1MyTmitgVkjQ2aYogZWOTpQXZZEeU5uXz4ZLDfb8jcJM5dbFyrTC02qN4lUHmWav McHgB4xw8qeHbc98D2vkuF0WS5lJsPjD80hoghBJ+n4Qo+/TlzVWmlg0bkn1ZbMqdwTg fhbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710006666; x=1710611466; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pxxy6rYsXE+YgbqfLQwa9qOUOHg4ePBRyOPqmtL2n8Q=; b=GXOXK60Q9GtUQZEpuEIDoNcyDK7MaG2g611X0tqP8IFr4vGdunq/8qxf8xTe+SEdIZ HcdPnm2csjbdFcpKsm6SwG8ytVKqzcaM/W3qB30ilKTuFOAl/l59xLN2/oDDBMVyM1fH COPKp77SChnXL6cjC6q2jspTjEtRA7W81zYdo+F91WF9myzqlIe80MZUfj7V3tqiPiIM AFr7ilSWKoXJwj/3GToSuk4Kdh3siqIo1YvRDu6eVmuWc2WZM4P5RfYLBIpqXFqoEOmW 6/K/sSy6k3EYa5EA35K1wLE8uusq+NTWhj5bzkyxty2S43eN78kPYDpjOFvfI8jS2e4Y QKEw== X-Gm-Message-State: AOJu0Yx5kvJtH5ax4SVorDFh/znGwmnkymwAHbAtAxjFXvKqNLRWpjxU Cv34B4gyhy/aFAG8RCsoo8DILpkm6ureSaSmRhSyBhUkPpVgjhuOV2BJB7YlyYK2+RzcF9wip60 E X-Received: by 2002:a17:902:da8e:b0:1dc:6b26:d1cd with SMTP id j14-20020a170902da8e00b001dc6b26d1cdmr2951651plx.2.1710006666317; Sat, 09 Mar 2024 09:51:06 -0800 (PST) Received: from stoup.. (098-147-055-211.res.spectrum.com. [98.147.55.211]) by smtp.gmail.com with ESMTPSA id o12-20020a170902d4cc00b001dcfbbb1ddesm1578556plg.7.2024.03.09.09.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Mar 2024 09:51:05 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, peter.maydell@linaro.org, qemu-stable@nongnu.org Subject: [PATCH 1/2] tcg/aarch64: Fix tcg_out_cmp for test comparisons Date: Sat, 9 Mar 2024 07:51:01 -1000 Message-Id: <20240309175102.726332-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240309175102.726332-1-richard.henderson@linaro.org> References: <20240309175102.726332-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Pass the type to tcg_out_logicali; remove the assert, duplicated at the start of tcg_out_logicali. Cc: qemu-stable@nongnu.org Fixes: 339adf2f38e ("tcg/aarch64: Support TCG_COND_TST{EQ,NE}") Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Tokarev --- tcg/aarch64/tcg-target.c.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc index dec8ecc1b6..38446c167e 100644 --- a/tcg/aarch64/tcg-target.c.inc +++ b/tcg/aarch64/tcg-target.c.inc @@ -1388,8 +1388,7 @@ static void tcg_out_cmp(TCGContext *s, TCGType ext, TCGCond cond, TCGReg a, if (!const_b) { tcg_out_insn(s, 3510, ANDS, ext, TCG_REG_XZR, a, b); } else { - tcg_debug_assert(is_limm(b)); - tcg_out_logicali(s, I3404_ANDSI, 0, TCG_REG_XZR, a, b); + tcg_out_logicali(s, I3404_ANDSI, ext, TCG_REG_XZR, a, b); } } else { if (!const_b) {