From patchwork Tue Apr 9 13:37:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 787203 Delivered-To: patch@linaro.org Received: by 2002:adf:fdd2:0:b0:346:15ad:a2a with SMTP id i18csp221672wrs; Tue, 9 Apr 2024 06:39:24 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWenWJXJDrg2m0gA9B4aBD0HMn/dV+V57IlshOFZihqFkn5rNI2oNa2OKYSJHDhGG5YfHWOwzWL0owYtUTtaced X-Google-Smtp-Source: AGHT+IGUjg1odefjWXKIvQTV12vDtRe0aXlkfOTfKZ+ZQ/LU5HQHkYCkob8ZW4e4Fx86PHN+8Pe8 X-Received: by 2002:ae9:c20a:0:b0:789:e72b:1250 with SMTP id j10-20020ae9c20a000000b00789e72b1250mr11788289qkg.59.1712669963802; Tue, 09 Apr 2024 06:39:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712669963; cv=none; d=google.com; s=arc-20160816; b=kzIXvTr7NrAdaYZWfzn0rUdedxrfmZB28HC9/mYegJgeX8g2jmfbjNqiY1v/jy1BGp /qLhZTck96SxXj+rqubvVvZOFN/2NCAQS/lyx2WN+3/hbKIO7YP5KA9N5uteftwiCfzN e8sAHXAyuxS7e51ahL4miqDq8xI46yjX8qpLPA0E2T+UgRu91gHInZRXntqW+ZGXsgFP fEvbkQFYz6b3Ut6wZ7gSagbunH8Kty1bYVAph7svNt8sxDX3cL4EjA+NL77SLPWkw26+ ZMCkDwwqsGviCFgSxPiZRPePNPw4fTxpDBNZnoSLq9z5dq43Vd/yPucTJGeHrmyvl4UH XxzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DYq6emMuo84KXuK6pkPRkrWEaAEwv9PfaiSXDO6YJ5M=; fh=QOl9Xi9nQ721K4qxGgLCqy+fNk/yfBHdpOYFmb4mu2g=; b=fwCYEd7gPpBgs4zCkZ3/3f0V/JtqfLmIRJx+4aUQ136lJ1m/sfPWz9pH7s73l5TdWi Qy5YACfJYrLHMCdPjF+jefsbPRi1VGwBLT8Z4Xc9BhASveq0K/LdceD6ae5OvWRy9BNB igNwnlP1HlfEVUHk32nxG+VMOWSO2SCIC7gI5vC5kSxICB2XQKThe7aONq+ig2Hm5wiM D13K2WGtOQRE9ZOgAUMZvAwShSy0H9oados26eKJ9E0dIhmnwssQpSvcNU2gNgi53//V yhPgO4t+sHKisYm/P5kvkyICq03IxQWEqCbPEUfyRfMzrzkJoXLmRQNGnCOqqdo5KTzz iPjQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cxnoEpD6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e1-20020a05620a014100b0078d64750c24si4770671qkn.297.2024.04.09.06.39.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2024 06:39:23 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cxnoEpD6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruBgK-00064w-5z; Tue, 09 Apr 2024 09:38:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruBgC-0005uB-5w for qemu-devel@nongnu.org; Tue, 09 Apr 2024 09:38:28 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruBg7-0008Dj-Iy for qemu-devel@nongnu.org; Tue, 09 Apr 2024 09:38:26 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4169d794358so6526265e9.1 for ; Tue, 09 Apr 2024 06:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712669900; x=1713274700; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DYq6emMuo84KXuK6pkPRkrWEaAEwv9PfaiSXDO6YJ5M=; b=cxnoEpD6KAKtBEw5QDjDUrmguX7lzbDV0x8vzdsb8XUcaMF+c/PECNPb7qMz3cRse5 tuxwcywIHcy90NfWqp6yOx6VwXG+HWWsEZKBWJS0BNqFrS4xHazn3UXT8pimj86Y0KVC q1m63i4uFPfJn5/HFRi1e4b8BqsfjtHw3sQSHlMu8btsw2AVJTavZnfbKsEQdNPLW3QW KvhKctv52gsS4lJBXwTKIlvz6A/p7fLQSxxlVaaR3s67NrqwtxPvjdOnQ/AGceSYg2PP MyWKWXxGlCtLZ0L7dUcQciD+QH/PaY2EetO2VxruQu06qROX9zJMkf6ArpNpr7EZcJDL wGGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712669900; x=1713274700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DYq6emMuo84KXuK6pkPRkrWEaAEwv9PfaiSXDO6YJ5M=; b=iwSJqAlFIeLsuyfXngx4Yi+p3UELVI0Wbb2VkjKQ2hbP2lheAJZu+HPzi1REF82yIu mbgUsbU+A/WwLNJZSvl6tXlNoJ6+l3Y6d9M88657zQYf/pvTB4SUgr72vax5TTS7Kb6e AbS+uqQbxm21A+5qwfjNGid+ViCP61O2/xF4oSX+Y4bqubsQ39GBxXyySZ8FYuWMKSXP LxDTkip13EXhNbBzynOTuqB0o9DjDPfZPbQsz2DE7i/o3mftLy6FDiBQFG9sR+AIJg1w w8Bl7lTDLzVW2JX4npHVEqXy1dHUncqcf+xR3Al3uBwFkr6ONcuV0o5+ozM28hw1C8+r V2Hg== X-Gm-Message-State: AOJu0Yxdc3nkIgptEP4kJqcC6ypspimYEl1DpPnIeBbfZrlA65NbCmuZ WpBG1hfAj21aPFV9akjzMdq2+ALewbQf7/ce1wcngiMemwR5sDmJgBCHwdDTq07xpfod+NAHOFo L X-Received: by 2002:a05:600c:4f0e:b0:416:6e42:ecc5 with SMTP id l14-20020a05600c4f0e00b004166e42ecc5mr4129262wmq.40.1712669899965; Tue, 09 Apr 2024 06:38:19 -0700 (PDT) Received: from m1x-phil.lan ([176.176.160.134]) by smtp.gmail.com with ESMTPSA id q23-20020adfab17000000b003437799a373sm11657644wrc.83.2024.04.09.06.38.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Apr 2024 06:38:19 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chuhong Yuan , Jason Wang , Alexander Bulekov , qemu-arm@nongnu.org, =?utf-8?q?Philippe_?= =?utf-8?q?Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.1 v2 03/11] hw/net/lan9118: Remove duplicated assignment Date: Tue, 9 Apr 2024 15:37:52 +0200 Message-ID: <20240409133801.23503-4-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240409133801.23503-1-philmd@linaro.org> References: <20240409133801.23503-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org s->txp->fifo_used is zeroed in the next 3 lines. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/net/lan9118.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c index 91d81b410b..d6f0e37eb1 100644 --- a/hw/net/lan9118.c +++ b/hw/net/lan9118.c @@ -438,7 +438,6 @@ static void lan9118_reset(DeviceState *d) s->hw_cfg = s->mode_16bit ? 0x00050000 : 0x00050004; s->pmt_ctrl &= 0x45; s->gpio_cfg = 0; - s->txp->fifo_used = 0; s->txp->state = TX_IDLE; s->txp->cmd_a = 0xffffffffu; s->txp->cmd_b = 0xffffffffu;