From patchwork Thu Apr 18 17:49:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 789811 Delivered-To: patch@linaro.org Received: by 2002:adf:e6ca:0:b0:346:15ad:a2a with SMTP id y10csp695158wrm; Thu, 18 Apr 2024 10:52:02 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWR5v41Zmo8UQhQSTvgnYVgpFtHA0N/MOVxeQwTxbtFRhR/Lfwm48Y1CwdU1WGZzQlZo0/G9Zdyq7npSgnh6b5v X-Google-Smtp-Source: AGHT+IFDVeIgaV8kksBPwDiNcz6li/VsoCFTEOlBVfqa1NKLpeXdIJkG+eGETrTiGAXO3yVi7uTx X-Received: by 2002:a05:690c:10c:b0:61b:108f:7dc0 with SMTP id bd12-20020a05690c010c00b0061b108f7dc0mr3691290ywb.45.1713462722533; Thu, 18 Apr 2024 10:52:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713462722; cv=none; d=google.com; s=arc-20160816; b=yhWpYHm1mBhgeeVvvDiyWxacbUtdFhR4CELYDEpq147E11skLR/fT931tApPylkjfE dWe44qKPlC64vArqLwaRz/U762dZ6j5fO0G71Jdzf7YjRDmo2TJSJ9VBYr/AEr1/Mb2f BAupJCSV+0R0mpAayIMmLfs1nEyXBo70BAcqBWR7wgvD8SJL7Tsz5BFdVoJsm/07vVhK HxI2CjpLEC7oz8Ir+imaipI1kMWeu+Sw1Jkw8fwZUvAUqXylUX3INHnwhWicTdGuDan/ vdZWZ4DWhqD7hPNIQaAnehzwH53G/0sQwJDGB3gtZFuZKxfVP0HUQ0KJGb39hEbU2BYH II/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=CUmW0xCZQx4qm2x1BHh0uxvDPVZB4EHQlbOj9bc0RMg=; fh=duFCrbmW7QyIwJKOp0blY4kXHchuONJhRN0ZSjkPt6k=; b=Wi9secMBjX8DpsvOpInhJufr6J3fDUFxG6oj0GtE4cdHTj5Fl7kKJw+c47mKU7pvQe N+GkcSVyfH/z3OdF7xyDyQdW+K/utnhTc7JVJTsjfsWax1DO9msoXdYhtLAW3x3yU7Z1 5coo8aQnc51QUNOjasUiWZKO7p4GGy3o3avPD1ITIBspV6y/3U6HZIMjv8y742oKjw2O 4BlTIXfxc4cKlIoUN5QiAd9jPT0H2QIHXgW30tHc3Wd/RbecWAm7PGTjcmFwRDXtgwiG p/nGjWIiNfNYGhTMgAyIA0p8InKOYb/KXFREIVWcm23oaCshKnE9I7wfTtc/LvpTzhGw dtMw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s7-20020a05622a178700b004364d54e6cdsi2031868qtk.286.2024.04.18.10.52.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2024 10:52:02 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxVuM-0000U6-K9; Thu, 18 Apr 2024 13:50:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxVuK-0000Sf-Vf; Thu, 18 Apr 2024 13:50:48 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxVuI-0007ao-Cc; Thu, 18 Apr 2024 13:50:48 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id EF73C5FD6F; Thu, 18 Apr 2024 20:50:02 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 5659CB9349; Thu, 18 Apr 2024 20:50:00 +0300 (MSK) Received: (nullmailer pid 947848 invoked by uid 1000); Thu, 18 Apr 2024 17:49:55 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , Kevin Wolf , Michael Tokarev Subject: [Stable-8.2.3 102/116] hw/block/nand: Have blk_load() take unsigned offset and return boolean Date: Thu, 18 Apr 2024 20:49:32 +0300 Message-Id: <20240418174955.947730-15-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Negative offset is meaningless, use unsigned type. Return a boolean value indicating success. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20240409135944.24997-3-philmd@linaro.org> (cherry picked from commit 2e3e09b368001f7eaeeca7a9b49cb1f0c9092d85) Signed-off-by: Michael Tokarev diff --git a/hw/block/nand.c b/hw/block/nand.c index 58ef547c5a..d945c0b9e3 100644 --- a/hw/block/nand.c +++ b/hw/block/nand.c @@ -84,7 +84,11 @@ struct NANDFlashState { void (*blk_write)(NANDFlashState *s); void (*blk_erase)(NANDFlashState *s); - void (*blk_load)(NANDFlashState *s, uint64_t addr, int offset); + /* + * Returns %true when block containing (@addr + @offset) is + * successfully loaded, otherwise %false. + */ + bool (*blk_load)(NANDFlashState *s, uint64_t addr, unsigned offset); uint32_t ioaddr_vmstate; }; @@ -772,11 +776,11 @@ static void glue(nand_blk_erase_, NAND_PAGE_SIZE)(NANDFlashState *s) } } -static void glue(nand_blk_load_, NAND_PAGE_SIZE)(NANDFlashState *s, - uint64_t addr, int offset) +static bool glue(nand_blk_load_, NAND_PAGE_SIZE)(NANDFlashState *s, + uint64_t addr, unsigned offset) { if (PAGE(addr) >= s->pages) { - return; + return false; } if (s->blk) { @@ -804,6 +808,8 @@ static void glue(nand_blk_load_, NAND_PAGE_SIZE)(NANDFlashState *s, offset, NAND_PAGE_SIZE + OOB_SIZE - offset); s->ioaddr = s->io; } + + return true; } static void glue(nand_init_, NAND_PAGE_SIZE)(NANDFlashState *s)