From patchwork Wed Apr 24 22:56:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 791545 Delivered-To: patch@linaro.org Received: by 2002:a5d:4884:0:b0:346:15ad:a2a with SMTP id g4csp1093191wrq; Wed, 24 Apr 2024 15:58:15 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWK/uknvkQmhhXEq7vPb50AqG7oBv9yWIeP3FhtXscb+zkTd64mwfMRjol5/DYBbdnFCfnfk4QkWBLnoS+VahS8 X-Google-Smtp-Source: AGHT+IFWzsd4Ox586SLgxlQExxsOtDgvh9BwNbAOR777eikg+yOM1JYZvMKe/uefd4vd0cLZ7/CJ X-Received: by 2002:a05:6214:27e5:b0:6a0:9b70:8966 with SMTP id jt5-20020a05621427e500b006a09b708966mr1910150qvb.38.1713999495700; Wed, 24 Apr 2024 15:58:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713999495; cv=none; d=google.com; s=arc-20160816; b=PwmLYof4fBrCh3QYpPVIPRO6Ersd2X9uRGcJeLL4hc8196ht4fbLgP7t23av2RWR49 BsywfUHdIx9Ka/gWzcIyWIIhnX/Zabqs+U7vZk5a0w6RgaeJgIw93NcZIN8t97KohUTZ NbqB96Oznl7UAG65Pf3E2qWlpk3gh+oU2T4pIh0l/wL64yPurPzGc4vp3kI4e+IYGo0j popY2Dz7+5IfISyva0syERlYpsItP5cmj6y++qh2/Zff2/ktj4i+82SJDd7LDfVnVoVZ anWOClv67gzWWuxfPMHUKwJYPAohWvziiOTh4++aqWpF8bI5gOHbLzkrywFRInN2tg3j eFeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Aco89HGhDUqxtzZSl7gQEXCIzX7CLhr3rgmAxnnD0GI=; fh=IOfZmL/4G2LGBtSV+LzySu7eotL7HJ1AQcRx3etIBXU=; b=GjALNo2Q+V25vvqcVMT4me0iygR668GN7NDsuUhSj2XiINaoDnaozqWU6HnoO9I09U y0NmDJqD+6PZumzfyW54MCLFC+TiHtDNMaSomHN0TJUVAQciJLoJ9upAu7NDdDjHoKLw O9M150EBO/pMKlgI4GlFOSWyOCXfmM1nWIP39Xq7VPIQbSlfS+euAk84thNtX0Gno0kD iEJtqfcuMU/PAtBnpp0fZUa/fS2ummIaKCNVDjAEyk3fdl/UiKIr09XgpstbBMmCc6ho Ewk9113/3TXLYvnyncwEG0sZOOsiloTDeS0mIDzJ/SDjTQcE2CNTLo7RA9vdrf8pF6uz vv8A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i7AOEhjG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o10-20020ad45c8a000000b0069b63f86310si16331380qvh.127.2024.04.24.15.58.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2024 15:58:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i7AOEhjG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzlYJ-0005PF-7v; Wed, 24 Apr 2024 18:57:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzlYG-0005Ov-Rw for qemu-devel@nongnu.org; Wed, 24 Apr 2024 18:57:20 -0400 Received: from mail-oa1-x33.google.com ([2001:4860:4864:20::33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzlYE-0001mp-UK for qemu-devel@nongnu.org; Wed, 24 Apr 2024 18:57:20 -0400 Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-2351c03438cso206049fac.2 for ; Wed, 24 Apr 2024 15:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713999438; x=1714604238; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Aco89HGhDUqxtzZSl7gQEXCIzX7CLhr3rgmAxnnD0GI=; b=i7AOEhjGGugck17CHRV6r+vpb11b/6JZo/IQlW+BDq7tMc1Rbk1ieINquMWbKduXcQ /1eu3isyp3F2nqGv4DNK9Lfu5813cJ9ChPJ/FkpefdMlcGuqHkLi5tXP+jE47PP9bmTN 3pwVy+NoNu5E3j8Pv9iSLpTeiIc5LTZJt4HL7ueeOUUo56KoAzHuaybEef/CKPbrnpfb FoO7YHzuL5uPi1hQcJUDuhbDSVNxtF9KzwqyE7SWl0fnP3XPW7cmukY0YhKOWN+3n0+C 0eA9NNvSX2s+N0RJ31ptjAw9XvZ5pxFgQb/EH5tsq3CllQDGE8KChN4xSUiJLCQQp4jk 53LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713999438; x=1714604238; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Aco89HGhDUqxtzZSl7gQEXCIzX7CLhr3rgmAxnnD0GI=; b=vD2GQ7Yb+twbHtkr73J8jWMsqW8RHyvsHbx1gRIVPY7Gy1ZWcxhevyTvzHxJbSMawU 1B0XVPdPL2yiIXnMopqekbeJBcHByE9zaUZ9GT5xooJe4rNgEee+Z7v3GyP7WQXDUxa2 KBkuTjpH0zKt7rwO1L25FKFbSeloOn9W8/bUush2xpuUClvwiNcE4Vk0tPTELmUTRszX 40H1G8nl84FeROfNGAJwCYzNokObXxoLnALXIY3hSVE6FrLPFkP+sXe9AP2fLUHPKXGp ELj1/Vrsx19QtOzFNpCgQeWCP7hFeAcqPYebiCiv0lwduNbCh9oKY/9XIb8UqXESucq1 eXAA== X-Gm-Message-State: AOJu0Yw8hgCjuvDjvhyFjg0OSwa4Dr6maiKaiHMdstzxKLKQC3ykicGp Yf+QNnNXJBMnXUwj4ui4tsXuqVeaATZZTVUmF+lrRFROXGQJOEF8QrjeylCLPcNlGQs8yH4dbke C X-Received: by 2002:a05:6870:d29c:b0:221:793a:3b9a with SMTP id d28-20020a056870d29c00b00221793a3b9amr4650594oae.40.1713999430087; Wed, 24 Apr 2024 15:57:10 -0700 (PDT) Received: from stoup.. ([156.19.246.23]) by smtp.gmail.com with ESMTPSA id gu26-20020a056a004e5a00b006ed9760b815sm11947413pfb.211.2024.04.24.15.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 15:57:09 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Alexander Monakov , Mikhail Romanov Subject: [PATCH v6 03/10] util/bufferiszero: Reorganize for early test for acceleration Date: Wed, 24 Apr 2024 15:56:58 -0700 Message-Id: <20240424225705.929812-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240424225705.929812-1-richard.henderson@linaro.org> References: <20240424225705.929812-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2001:4860:4864:20::33; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x33.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Alexander Monakov Test for length >= 256 inline, where is is often a constant. Before calling into the accelerated routine, sample three bytes from the buffer, which handles most non-zero buffers. Signed-off-by: Alexander Monakov Signed-off-by: Mikhail Romanov Message-Id: <20240206204809.9859-3-amonakov@ispras.ru> [rth: Use __builtin_constant_p; move the indirect call out of line.] Signed-off-by: Richard Henderson --- include/qemu/cutils.h | 32 ++++++++++++++++- util/bufferiszero.c | 84 +++++++++++++++++-------------------------- 2 files changed, 63 insertions(+), 53 deletions(-) diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h index 92c927a6a3..741dade7cf 100644 --- a/include/qemu/cutils.h +++ b/include/qemu/cutils.h @@ -187,9 +187,39 @@ char *freq_to_str(uint64_t freq_hz); /* used to print char* safely */ #define STR_OR_NULL(str) ((str) ? (str) : "null") -bool buffer_is_zero(const void *buf, size_t len); +/* + * Check if a buffer is all zeroes. + */ + +bool buffer_is_zero_ool(const void *vbuf, size_t len); +bool buffer_is_zero_ge256(const void *vbuf, size_t len); bool test_buffer_is_zero_next_accel(void); +static inline bool buffer_is_zero_sample3(const char *buf, size_t len) +{ + /* + * For any reasonably sized buffer, these three samples come from + * three different cachelines. In qemu-img usage, we find that + * each byte eliminates more than half of all buffer testing. + * It is therefore critical to performance that the byte tests + * short-circuit, so that we do not pull in additional cache lines. + * Do not "optimize" this to !(a | b | c). + */ + return !buf[0] && !buf[len - 1] && !buf[len / 2]; +} + +#ifdef __OPTIMIZE__ +static inline bool buffer_is_zero(const void *buf, size_t len) +{ + return (__builtin_constant_p(len) && len >= 256 + ? buffer_is_zero_sample3(buf, len) && + buffer_is_zero_ge256(buf, len) + : buffer_is_zero_ool(buf, len)); +} +#else +#define buffer_is_zero buffer_is_zero_ool +#endif + /* * Implementation of ULEB128 (http://en.wikipedia.org/wiki/LEB128) * Input is limited to 14-bit numbers diff --git a/util/bufferiszero.c b/util/bufferiszero.c index 641d5f9b9e..972f394cbd 100644 --- a/util/bufferiszero.c +++ b/util/bufferiszero.c @@ -26,8 +26,9 @@ #include "qemu/bswap.h" #include "host/cpuinfo.h" -static bool -buffer_zero_int(const void *buf, size_t len) +static bool (*buffer_is_zero_accel)(const void *, size_t); + +static bool buffer_is_zero_integer(const void *buf, size_t len) { if (unlikely(len < 8)) { /* For a very small buffer, simply accumulate all the bytes. */ @@ -128,60 +129,38 @@ buffer_zero_avx2(const void *buf, size_t len) } #endif /* CONFIG_AVX2_OPT */ -/* - * Make sure that these variables are appropriately initialized when - * SSE2 is enabled on the compiler command-line, but the compiler is - * too old to support CONFIG_AVX2_OPT. - */ -#if defined(CONFIG_AVX2_OPT) -# define INIT_USED 0 -# define INIT_LENGTH 0 -# define INIT_ACCEL buffer_zero_int -#else -# ifndef __SSE2__ -# error "ISA selection confusion" -# endif -# define INIT_USED CPUINFO_SSE2 -# define INIT_LENGTH 64 -# define INIT_ACCEL buffer_zero_sse2 -#endif - -static unsigned used_accel = INIT_USED; -static unsigned length_to_accel = INIT_LENGTH; -static bool (*buffer_accel)(const void *, size_t) = INIT_ACCEL; - static unsigned __attribute__((noinline)) select_accel_cpuinfo(unsigned info) { /* Array is sorted in order of algorithm preference. */ static const struct { unsigned bit; - unsigned len; bool (*fn)(const void *, size_t); } all[] = { #ifdef CONFIG_AVX2_OPT - { CPUINFO_AVX2, 128, buffer_zero_avx2 }, + { CPUINFO_AVX2, buffer_zero_avx2 }, #endif - { CPUINFO_SSE2, 64, buffer_zero_sse2 }, - { CPUINFO_ALWAYS, 0, buffer_zero_int }, + { CPUINFO_SSE2, buffer_zero_sse2 }, + { CPUINFO_ALWAYS, buffer_is_zero_integer }, }; for (unsigned i = 0; i < ARRAY_SIZE(all); ++i) { if (info & all[i].bit) { - length_to_accel = all[i].len; - buffer_accel = all[i].fn; + buffer_is_zero_accel = all[i].fn; return all[i].bit; } } return 0; } -#if defined(CONFIG_AVX2_OPT) +static unsigned used_accel; + static void __attribute__((constructor)) init_accel(void) { used_accel = select_accel_cpuinfo(cpuinfo_init()); } -#endif /* CONFIG_AVX2_OPT */ + +#define INIT_ACCEL NULL bool test_buffer_is_zero_next_accel(void) { @@ -194,36 +173,37 @@ bool test_buffer_is_zero_next_accel(void) used_accel |= used; return used; } - -static bool select_accel_fn(const void *buf, size_t len) -{ - if (likely(len >= length_to_accel)) { - return buffer_accel(buf, len); - } - return buffer_zero_int(buf, len); -} - #else -#define select_accel_fn buffer_zero_int bool test_buffer_is_zero_next_accel(void) { return false; } + +#define INIT_ACCEL buffer_is_zero_integer #endif -/* - * Checks if a buffer is all zeroes - */ -bool buffer_is_zero(const void *buf, size_t len) +static bool (*buffer_is_zero_accel)(const void *, size_t) = INIT_ACCEL; + +bool buffer_is_zero_ool(const void *buf, size_t len) { if (unlikely(len == 0)) { return true; } + if (!buffer_is_zero_sample3(buf, len)) { + return false; + } + /* All bytes are covered for any len <= 3. */ + if (unlikely(len <= 3)) { + return true; + } - /* Fetch the beginning of the buffer while we select the accelerator. */ - __builtin_prefetch(buf); - - /* Use an optimized zero check if possible. Note that this also - includes a check for an unrolled loop over 64-bit integers. */ - return select_accel_fn(buf, len); + if (likely(len >= 256)) { + return buffer_is_zero_accel(buf, len); + } + return buffer_is_zero_integer(buf, len); +} + +bool buffer_is_zero_ge256(const void *buf, size_t len) +{ + return buffer_is_zero_accel(buf, len); }