From patchwork Thu May 2 21:15:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 794136 Delivered-To: patch@linaro.org Received: by 2002:adf:a153:0:b0:34d:5089:5a9e with SMTP id r19csp456468wrr; Thu, 2 May 2024 14:17:03 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW07+0xD8U9VotWjJLaTIfPDhvCBP40mYI/UKdu6v1wrJSqgRnMxwF+jMzWcKzhpShWSQszljPIv+5YXkehBu3K X-Google-Smtp-Source: AGHT+IG8F/3SqnnGTLNIXuMF4+tnmjMTkxyHgLcuMlvFpYZGsrxBSs4VWNuG4tKoRg9DN2yFDy48 X-Received: by 2002:a05:622a:1186:b0:439:73c:3de8 with SMTP id m6-20020a05622a118600b00439073c3de8mr935154qtk.15.1714684623623; Thu, 02 May 2024 14:17:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714684623; cv=none; d=google.com; s=arc-20160816; b=iJ5jgL3juAnIK4bYEdSVeH5Yqy+eMaXIfV9uBzUZLmsyb+p/XxnMCwnXFCBYVWdp9g STnL9Pc9UskINbRNhrzao490E6eYwM3qBarm8cI3E5YibTCb7Nc7VLs6QMFrVOd0msns Dj9kmDJ6B7afR+RWAZEq6gpYLR37Z9mpxVXkc3e01nZk+N6wnNFd8WaNckOV/gAdO4/a UylOTeYT/h9zHPO2xC3r3yKa/kHwjbjfM1Olgb2oS3NxtDUTlsYBNlHg30VkzAOdCXM7 FVfd26Hw7j28SzpxksUS9dPkWpfg1/5bv08IFDqaShb2ConfMMk6FShYZPSUXclwY41V 7YVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=FLV/GYrIEX0gQTx5Yxot837zR7KR8Gz9r47zkNmBYYY=; fh=9xGhv+1UliIX34j+rhFuVtnm9fBdMYzeJdXCJAB33Zg=; b=F+hjvDFq/shpO8nc3LnLcIP5mujkgmlwx/vLfGyU+4st/GRkwSbD6YfEOwguGtCDFg sh9wJxKygg2R4i9OUY51lfd+a+RVZgm6i9GIiDOA6EjCAQHthMoTjxxX0MEAGPbssvGf AGwFXK4GoQXrRrw4s5VdM6WBKMuxaw8bmc5nRLCJzHknn7dgFvPOYcdfoOSJCb9Q2e2+ 3LUDZCb9QpOASMqHD1cwYfO9Dp09D6jb5FIcxxzJewwMGOy2hSf2aaLNFWWwM7nEbXBa qYA4SECFp2gNADuz1+mfunf3CezxR9p5t3aRqj8qiAzwrDKzgCWJv4zJ0OCn6f67oDAe N5KQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jrmwyKUb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y8-20020ac85f48000000b0043adbe75155si1988494qta.207.2024.05.02.14.17.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2024 14:17:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jrmwyKUb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2dmJ-0008Ko-G8; Thu, 02 May 2024 17:15:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2dmI-0008KZ-3D for qemu-devel@nongnu.org; Thu, 02 May 2024 17:15:42 -0400 Received: from mail-il1-x12e.google.com ([2607:f8b0:4864:20::12e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2dmF-0002o2-B4 for qemu-devel@nongnu.org; Thu, 02 May 2024 17:15:41 -0400 Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-36c6f907139so6571705ab.2 for ; Thu, 02 May 2024 14:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714684537; x=1715289337; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FLV/GYrIEX0gQTx5Yxot837zR7KR8Gz9r47zkNmBYYY=; b=jrmwyKUbaxM/vjDSBnPC5DyVRy4SQs81PIMJefKgqPcA+cQMiagjg+k0j7eAnVv875 DgVWyuGSGRFq8KvXDm5oE5gGfhcRn+5/y+rGkMyRsp5n21LLoj7+xk9WBimCknzAdaSt ldVM+BwiHdeLyjJNIohnJWes8L498qN06Vl3dAGtKsD/b8QziUhkhuy834wNyun4PgUT mrey0zMDRwmZRJnPaKKo2+isXTilsK9Xar2bPXF/z7/sGcW0q6MYFNzrntNKhGIFTmez VEsuQ0CMWlnzZddkJPQE0+7EBxqdGYwt+NzJU0eYFOisE4gnNoTOz8THAD+ePYdm2Die CDUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714684537; x=1715289337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FLV/GYrIEX0gQTx5Yxot837zR7KR8Gz9r47zkNmBYYY=; b=n5WR2OwqmhxQZSuR2N26AlZPZzK06VUsg1f37JWZY5K9TkrVccjkyeeER/tYapD3rP f362oai32CGyP8L46Pa+nJWw1wbQxbVSPtuRiBow43WhBhBI5wlZ4IlDp8bdCvV2fUJZ fKn1I6qb8u7EiN72GL6dKntxaodTdsrVWJv4LTrl/KsPBKEkbBvSfGcusk+c/2l4M1Nw OxVa4CsguV+gQLKEIRT23GkutAxOvb0wp4RgaWflmaRJaC2dWaZ3AKoWPV0I616jE70Z NFXPMFaJsTF/+Wkh7xp5R0d+tftwFIXbmJblyqcwOpS1FXSxjNxg5QxnHpGILI1zXWH4 5IoA== X-Gm-Message-State: AOJu0YwaVGfOuyrZWHVlsyJzHn24UOmaDymQ0CiYe/uruR7UEgD28sbo HaaXwN/HaAwt+TB3//ddtqgMZCwXr7z+8JtK69WtnHuCnO4pd60BAkd8kAlkib1yei15KC7PlNn HR1U= X-Received: by 2002:a05:6e02:1d95:b0:36c:3827:58c8 with SMTP id h21-20020a056e021d9500b0036c382758c8mr1296179ila.5.1714684536963; Thu, 02 May 2024 14:15:36 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::ecd0]) by smtp.gmail.com with ESMTPSA id d14-20020a63f24e000000b0060063c4be3bsm1700915pgk.14.2024.05.02.14.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 14:15:36 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Mahmoud Mandour , Alexandre Iooss , Richard Henderson , Paolo Bonzini , Pierrick Bouvier , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v6 1/9] plugins: prepare introduction of new inline ops Date: Thu, 2 May 2024 14:15:14 -0700 Message-Id: <20240502211522.346467-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240502211522.346467-1-pierrick.bouvier@linaro.org> References: <20240502211522.346467-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::12e; envelope-from=pierrick.bouvier@linaro.org; helo=mail-il1-x12e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Until now, only add_u64 was available, and all functions assumed this or were named uniquely. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/qemu/plugin.h | 2 +- accel/tcg/plugin-gen.c | 6 +++--- plugins/core.c | 14 ++++++++++++-- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index 18062528c17..bee1647cfc4 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -69,7 +69,7 @@ union qemu_plugin_cb_sig { enum plugin_dyn_cb_type { PLUGIN_CB_REGULAR, PLUGIN_CB_MEM_REGULAR, - PLUGIN_CB_INLINE, + PLUGIN_CB_INLINE_ADD_U64, }; /* diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 3db74ae9bfe..8028ae76c3a 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -113,7 +113,7 @@ static void gen_udata_cb(struct qemu_plugin_dyn_cb *cb) tcg_temp_free_i32(cpu_index); } -static void gen_inline_cb(struct qemu_plugin_dyn_cb *cb) +static void gen_inline_add_u64_cb(struct qemu_plugin_dyn_cb *cb) { GArray *arr = cb->inline_insn.entry.score->data; size_t offset = cb->inline_insn.entry.offset; @@ -158,8 +158,8 @@ static void inject_cb(struct qemu_plugin_dyn_cb *cb) case PLUGIN_CB_REGULAR: gen_udata_cb(cb); break; - case PLUGIN_CB_INLINE: - gen_inline_cb(cb); + case PLUGIN_CB_INLINE_ADD_U64: + gen_inline_add_u64_cb(cb); break; default: g_assert_not_reached(); diff --git a/plugins/core.c b/plugins/core.c index 0213513ec65..a8557b54ff7 100644 --- a/plugins/core.c +++ b/plugins/core.c @@ -316,6 +316,16 @@ static struct qemu_plugin_dyn_cb *plugin_get_dyn_cb(GArray **arr) return &g_array_index(cbs, struct qemu_plugin_dyn_cb, cbs->len - 1); } +static enum plugin_dyn_cb_type op_to_cb_type(enum qemu_plugin_op op) +{ + switch (op) { + case QEMU_PLUGIN_INLINE_ADD_U64: + return PLUGIN_CB_INLINE_ADD_U64; + default: + g_assert_not_reached(); + } +} + void plugin_register_inline_op_on_entry(GArray **arr, enum qemu_plugin_mem_rw rw, enum qemu_plugin_op op, @@ -326,7 +336,7 @@ void plugin_register_inline_op_on_entry(GArray **arr, dyn_cb = plugin_get_dyn_cb(arr); dyn_cb->userp = NULL; - dyn_cb->type = PLUGIN_CB_INLINE; + dyn_cb->type = op_to_cb_type(op); dyn_cb->rw = rw; dyn_cb->inline_insn.entry = entry; dyn_cb->inline_insn.op = op; @@ -551,7 +561,7 @@ void qemu_plugin_vcpu_mem_cb(CPUState *cpu, uint64_t vaddr, cb->regular.f.vcpu_mem(cpu->cpu_index, make_plugin_meminfo(oi, rw), vaddr, cb->userp); break; - case PLUGIN_CB_INLINE: + case PLUGIN_CB_INLINE_ADD_U64: exec_inline_op(cb, cpu->cpu_index); break; default: