From patchwork Wed Jul 24 09:46:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Patchwork-Id: 814167 Delivered-To: patch@linaro.org Received: by 2002:adf:f288:0:b0:367:895a:4699 with SMTP id k8csp2675349wro; Wed, 24 Jul 2024 02:48:39 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXL6KH5R2hZAaMYkI4rTlF8/VVGSOtUl+SZ6vvY12rdMuMYtSiNmPJBl2HdmFfwndM3PEWo5n27WS6SpPZ/aFVA X-Google-Smtp-Source: AGHT+IFtPThSIqcpLV2K+5Dj4Z9IoZjmh0abOYTgEPR9TFRXd+O+ncx3pb2bADcAwecc6tVnuHIP X-Received: by 2002:a05:6214:c4f:b0:6b5:e852:7273 with SMTP id 6a1803df08f44-6b990799005mr15335596d6.36.1721814519375; Wed, 24 Jul 2024 02:48:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721814519; cv=none; d=google.com; s=arc-20160816; b=YmqjsXlYoYqNbGzgEi7yGWxzXTvySCKR6YFsMfNrFYb/ZOqUDJ7xCGecBfWXdAyCzL /uArTf6pWPJgnmDSp7uMZjsNFbSHYvdrtHZFKID4SuaBhYLtv1HBKkiE19NW+5Sv7UZT czM6qvKlEwyGvCkFpD3N7yfMsQmSK7IflauxnvE0LUf1S2MriJ0kRk4fp2WSgrRxKz8N 1MeuETihT3QMj0KajKMmO/nbXKVFv0f2WnV14oywkQpS/L4y4bgknqzxDgV4R55o0kDo NHRpZaiCytc+Tj998Sz+OfhxvaeNHoPUJ33+dWCAmb8EJXe4YjkTITzHN4Mik3NcTUgY IfqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VqwA2+T83B2AlJaN/PkItDasVfJuM7J+j2zn/LPEOQA=; fh=cOKUfxljBUXgIrIxJJtS6Fgcom6aHeGv5vVzLnZSVlE=; b=tCGytZieK4r8ZkvuqonqYMn6b1MRdDeIXkaWIF3kOQ0vWBrjW+hzkZXRp4aT/mOLv3 8ti8jFhGwLhyQell8szW2QO6ABxip7STTNQ7D+VEpHfJZtCYQ3g3e9eEAsBO5KiTCvHc yJXQ01JQE3/TFUHJ9KfncB09xNgFrVHs0+5qO4H2x1dSRAYrC08GbIt5LOuvCquzDIQ7 t12QIILIr9H/bkligXgURnVC55Ks7mbBbEVVrH8fpRj0J+kNQ7w53UHJ6ztCfOpsOY4/ jLva2zx0Op/j+Men7+qBWGWxLUfdfTyg8JZ4iaYwywHnnyuQlSIiZUIeLZQQQleGH0E+ 1LpQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HQhLc3TR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6b7ac7c585csi115626466d6.125.2024.07.24.02.48.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jul 2024 02:48:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HQhLc3TR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWYbY-0003CU-Bb; Wed, 24 Jul 2024 05:48:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWYbU-0002sl-S0 for qemu-devel@nongnu.org; Wed, 24 Jul 2024 05:48:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWYbT-0003Qr-Cp for qemu-devel@nongnu.org; Wed, 24 Jul 2024 05:48:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721814490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VqwA2+T83B2AlJaN/PkItDasVfJuM7J+j2zn/LPEOQA=; b=HQhLc3TRDKCmTRUJvi3qzxTpK66C1q5CC72A15hUd1xfKaNgdQtCpkOtE9uSKFGmVE7aXo sVA6HTbGsp9rcYGLhVwDAQXfEQ31wn/ghFqMgl7z+FJWpK0p/YxnMTAa/VqB9rADuViw2l KLEAvilnxzhKe3ym9NOVwuh7DcxzP4c= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-532-azCt-RShO16qQjGUmPYa0w-1; Wed, 24 Jul 2024 05:47:55 -0400 X-MC-Unique: azCt-RShO16qQjGUmPYa0w-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A29121955F45; Wed, 24 Jul 2024 09:47:54 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.141]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6066D1955D44; Wed, 24 Jul 2024 09:47:44 +0000 (UTC) From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Thomas Huth , Laurent Vivier , Markus Armbruster , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Eric Blake , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Hyman Huang Subject: [PULL 03/11] crypto: Allow building with GnuTLS but without Libtasn1 Date: Wed, 24 Jul 2024 10:46:58 +0100 Message-ID: <20240724094706.30396-4-berrange@redhat.com> In-Reply-To: <20240724094706.30396-1-berrange@redhat.com> References: <20240724094706.30396-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.133, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé We only use Libtasn1 in unit tests. As noted in commit d47b83b118 ("tests: add migration tests of TLS with x509 credentials"), having GnuTLS without Libtasn1 is a valid configuration, so do not require Libtasn1, to avoid: Dependency gnutls found: YES 3.7.1 (cached) Run-time dependency libtasn1 found: NO (tried pkgconfig) ../meson.build:1914:10: ERROR: Dependency "libtasn1" not found, tried pkgconfig Fixes: ba7ed407e6 ("configure, meson: convert libtasn1 detection to meson") Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index af9f0380e2..4eca361319 100644 --- a/meson.build +++ b/meson.build @@ -1979,6 +1979,7 @@ endif tasn1 = not_found if gnutls.found() tasn1 = dependency('libtasn1', + required: false, method: 'pkg-config') endif keyutils = not_found