From patchwork Thu Sep 19 04:46:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 829569 Delivered-To: patch@linaro.org Received: by 2002:adf:ebcc:0:b0:367:895a:4699 with SMTP id v12csp154285wrn; Wed, 18 Sep 2024 21:49:43 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWS7XC34FL1+hXJHSre5YjQIJmFLZ432zss58V8bJJW1RAc3N3GqFzpmv6AQB8odVHn+yR3Zg==@linaro.org X-Google-Smtp-Source: AGHT+IF/x81qlxLr8CSTxbXBEfigZPwJ9xdn5Z+lfh2v+rFtu8RUOhRi1/XzaOKpUU1KttPpOBqn X-Received: by 2002:a05:620a:2953:b0:7a9:b814:4aa4 with SMTP id af79cd13be357-7a9e5f5ee35mr4674390585a.43.1726721383214; Wed, 18 Sep 2024 21:49:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726721383; cv=none; d=google.com; s=arc-20240605; b=dc1HizetibMu2esd3bn4Vx7iNLkvtHLUKobZXIr9S/ZfqHQkjEJGghB94ptDVys2f5 tRfBwa3LHo3iTIYsdgT4hK5Hy7Fcp84ZzRd/O0boXVsUY2W4tfpHtMMgy0uOogy/bYKl u1vS876hUiLCMQSi3LfxWQb8DFphdorYuNXAnpGoUya++upnGb28Sh/581AEKy+CAmiD PL22SB+xYkkZYJ9ONvyFMPwp4SfKFBNv/i2b0vy46ECBak+y7aBKrhPuGSGHMveN2kLM +7dqZScQ9aOvaHV5R+H5jhhaSlvfOBK1ZTgj/H+OJIFwy+sZFIiuJLXgld5RgwHFR3ag 0DDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=la0dMEWQk3jt41a1BnPVKduxSUDoWih+Jb1d+U0bfqA=; fh=5sUwfmYRlCXWUAcYTQtsUKL3/h5U38RKAKIQYZIY6/E=; b=EB8XlxUqG/rixgqLE6p/jVxRVyqfcughVrnsUe9FeMRR9PtsJ/vu9NMU6UUZaG5qwx iXm5Z+Dce/Vogr0FJRWGRotjrYx9B8bASqw5mTFsgTDDqcezj2W5kC9qPXDm/Rk+07mV O1YyC3lfS5PMzY9CodZu0g91jpcsJmRsLpvbTP9cKsMy0v83Z2bfwLhnTkhW02BaqgjQ TUzaCoDKfCQG4aq53E0Gf+7jAn5Nd/IUIgnzpcsE8mjjlidI0K1lg2jqMXiWc6uoTWDs 6QHoJ7YM0I/ijVIzPcjUGu4YgxSWQHTLdKQ09TSXFuw57p8MufqHTBhhP2tG8Q24Okeh ffRw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kZSm0s2R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acb08c6b38si102504985a.351.2024.09.18.21.49.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Sep 2024 21:49:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kZSm0s2R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sr94Z-0000dC-P0; Thu, 19 Sep 2024 00:47:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr94X-0000TQ-7L for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:17 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sr94P-0007Dj-NB for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:16 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-718e6299191so202670b3a.2 for ; Wed, 18 Sep 2024 21:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721228; x=1727326028; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=la0dMEWQk3jt41a1BnPVKduxSUDoWih+Jb1d+U0bfqA=; b=kZSm0s2RhEWDHFu6pt1OFOG5BDpFCFCy+BrKSCOWl32uin2kJ2ejNCJZtibMpR7Nqj Fws5ltgJsRx2sLRcphVWzbvCGHGHjQtwZvqHU3U6mnjTQDVXtnEkWZ8q3G2kGtRrGHp4 O+7wlMUQZ8glu6MAJTgMlxVPCzjbIYH0LMJJYt4xz42npga4OzYaQH6IIhqVlRP4pqA/ TdVDXjVvg5Otf8dyHDxfQRnZ5G8bbgCecZpLjcB+t5alsDXq0o02DAll3WqrsMl3y9VF h6tOvszi+k8q1zOY4seBJ7CJFoL4ECP6dSjLnCTQAG2JCOLkusnQXBbfvmbdYmBlnmUY 7dHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721228; x=1727326028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=la0dMEWQk3jt41a1BnPVKduxSUDoWih+Jb1d+U0bfqA=; b=gWEkr6fRGes16Smrw4ONL49dX7xSB5F8Nqk/gouOxCDTF8gjSTG9+ZPkOn8el+t8lE TtsM0WWwgk40w25TMiOxdpqCKATSDZ8lRryUid10BmBMZkO1Fwmc/YRxRvfj6hnmrn5E s/k3WQR9BWz7aWox2sPQxBCZtVuTenkbGHoyaAVYgzW/gltUSiC5WKmQDqAECgt54mKK JwrngMPIrGfeHrA1OYuL2snwcWutexwo1LJjK3uXCyCMe/yNDu8Dbl5i7i88ZV2Rj1Cz iBRGRxibdiREdHUDpJ08g4toCEzsTHze9FekAlbWiESI+8s/ebm/zlpq9J5plWlyzmi+ PnXw== X-Gm-Message-State: AOJu0YzPT0QuAuKC9jCakKDu3ClsfauNALsmbXzUJYBR5Rny4CazAYm+ cZzYd713PkEoECFS4Rul81ypa+C1fAA0loaO4j/JHwI+cyaMRE9vp3aB01BOLQwM8TYAQU/YnLt 8Ph/ohQ== X-Received: by 2002:a05:6a00:2316:b0:714:1fc3:79fb with SMTP id d2e1a72fcca58-71925f9b26fmr39873231b3a.0.1726721228183; Wed, 18 Sep 2024 21:47:08 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:07 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 11/34] hw/pci: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:18 -0700 Message-Id: <20240919044641.386068-12-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index f0508682d2b..c6950e21bd4 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -46,13 +46,13 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) /* kvm-all wants this */ MSIMessage pci_get_msi_message(PCIDevice *dev, int vector) { - g_assert(false); + g_assert_not_reached(); return (MSIMessage){}; } uint16_t pci_requester_id(PCIDevice *dev) { - g_assert(false); + g_assert_not_reached(); return 0; }