From patchwork Thu Sep 19 04:46:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 829595 Delivered-To: patch@linaro.org Received: by 2002:adf:ebcc:0:b0:367:895a:4699 with SMTP id v12csp155584wrn; Wed, 18 Sep 2024 21:55:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVXxPACXSW/gnOdw/oa9gS6DR4meWdERH2vlEjQNFwRJfVjEJ7pmQOVKAktVEqE37X1G5bbXg==@linaro.org X-Google-Smtp-Source: AGHT+IHTNZX/ZIKHlMkakxFwWZDI0kCTzVyBlxHskaBTGd4OgOOXkcHWtoNBmV6+Zjo/fIERYfCm X-Received: by 2002:a05:6214:450a:b0:6c5:55d5:f53d with SMTP id 6a1803df08f44-6c57350b9e6mr351072196d6.8.1726721747604; Wed, 18 Sep 2024 21:55:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726721747; cv=none; d=google.com; s=arc-20240605; b=HFitsfw9hY7cBv3+/ochANr13+6yc96vfPT/ICe+a7yn1hoc9tT73el/tEGJj8hKxT ATkS75Z+aXnc9kUaEpvpjn420QSr0sqFBTjpe8IfRBauWqhYONAOE4sRVQe2aRSLCLpp Ptwxwa7h7lvpr+wzSA7+cblw58CBWQMwvTakkvyXvmLZ57DbtFRh/OXF6fPkxcwyE+ea aZZ1Pg0sQRO8x6VfjQvNOabUihmdqDHzKPNiEJIaoLYuSP51yGlE+RNzHVnCle5NzJ9p SbGmfOWXUjYzlZVujUGMz/ZIgzbTJT+wynYA8bM+NxTgpOFPyEISQ3YWyioWth8EAN6q 4s5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qqlshtAdWrkwK7VFTA+7O6AV+UQemh0VvOj30SlF0fo=; fh=5sUwfmYRlCXWUAcYTQtsUKL3/h5U38RKAKIQYZIY6/E=; b=cRfcskFooDX9Q3EuWFE+ULN9y2TIL3vm/SGUBLUl634VO6n691DnBgDGB/6AilD06r i/9sKHrz2BRk30DazlDnFIhg3t6x77XOK2YiHJHs/59EgPWw3HTBEC2l5nNUx4+b8lbq ahUiMcZnn5o1EAhkQrNBaL+O3nVc+jd+QiIRVGH6f3GINqTWqmysITM80GBLSWCQILxk lkkrgkf5CBkaHvzXzxsukZXEJFksZEOIOkc0Jt8vDOu5BHMQHL3Lama2Y65jrcO7TrN1 2Zp09jVvt7OLMp2MvOpbOamGH+kPcV36EDRvI5q2Bu4GvDCwb88oG39p6vriSwPBus8o H7ww==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XsggXCWz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6c75e47c3edsi10541756d6.162.2024.09.18.21.55.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Sep 2024 21:55:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XsggXCWz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sr94R-0008RH-Kk; Thu, 19 Sep 2024 00:47:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr94N-0008CI-W2 for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:08 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sr94G-00078W-4d for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:07 -0400 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-718e11e4186so381547b3a.2 for ; Wed, 18 Sep 2024 21:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721218; x=1727326018; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qqlshtAdWrkwK7VFTA+7O6AV+UQemh0VvOj30SlF0fo=; b=XsggXCWzxJk6PrUfLz3lsbeqthfKq9nFR0rR3Ii4rZNzadWNER1yaL2rBH98RJ1Iee gonneFTUhp/fr6rikT0KHNFd3IL5ao+45YpavDbO3lr2U3zdgqfDwH26ixqmRPyH+VBS XZIHvIvhjSuMIdldk+3OuiHPXm0qU+LmRhv3GyfjjGfSbo6WU0NvyE+Tvz9SECqgmorv V7AE8sKzd9SokMBwon3HQ2FcnQmhwaXK1V/IcJEy9sgBJ88cmx6KCsPB2vo2qLF/O60h 5ok+Zv5/QMuQgROP5sFalhsEjtIWS8OXJGgo61gGaPPU52+J/u8XeEO/bPudknEHhKRy t75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721218; x=1727326018; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qqlshtAdWrkwK7VFTA+7O6AV+UQemh0VvOj30SlF0fo=; b=I9V6/DB3HS5r3YNkTmNCfbvX8dPy1IYZ11rlyHIGPPIv0B7B4A2Jr6847+nv/0WTNY Ryhhiydhdi3S8m+iMy2JJEy1PhRNejkkkb6n5+YmCxK21iHkIN2OfbK9FDsDM7X5JTWk RwmRtLDzGXAXNrpEnMfZacDzFyOPsiakic2bZHXraCgq/rabxOjNrGmfy192CvF0r4GX CnZbavRABO6Kc8zPiHDNugTaFao7wGq1PWHN6VuzjsOkwdRzix8S3gipSP7L+d3rVP+K kgZF0MC09+5yJfkR6yAWh8Eusd5Fa8FkdpFXwdegFtLK98Z4+GIz8fNE/S5x2nR3pC74 Ndtg== X-Gm-Message-State: AOJu0YxUq9uP4y2YUWmCsdqcXGBPGzrautyuoKfWTP7LXPjyNW8oMilj Zp22plxcjZ4NqdvXXxV4JsOucwCRTIe/HYsDIeluoOS6OoDUAKgJA5iO6mohzuWJbq29Qg0zaPr 5xFsReg== X-Received: by 2002:a05:6a00:2d11:b0:714:2198:26a1 with SMTP id d2e1a72fcca58-7192620d8d3mr36118214b3a.27.1726721218493; Wed, 18 Sep 2024 21:46:58 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:46:58 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 06/34] target/ppc: replace assert(0) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:13 -0700 Message-Id: <20240919044641.386068-7-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- target/ppc/dfp_helper.c | 8 ++++---- target/ppc/mmu_helper.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c index 5967ea07a92..ecc3f793267 100644 --- a/target/ppc/dfp_helper.c +++ b/target/ppc/dfp_helper.c @@ -249,7 +249,7 @@ static void dfp_set_FPRF_from_FRT_with_context(struct PPC_DFP *dfp, fprf = 0x05; break; default: - assert(0); /* should never get here */ + g_assert_not_reached(); } dfp->env->fpscr &= ~FP_FPRF; dfp->env->fpscr |= (fprf << FPSCR_FPRF); @@ -1243,7 +1243,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *b) \ } else if (decNumberIsQNaN(&dfp.b)) { \ vt.VsrD(1) = -2; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ set_dfp64(t, &vt); \ } else { \ @@ -1252,7 +1252,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *b) \ } else if ((size) == 128) { \ vt.VsrD(1) = dfp.b.exponent + 6176; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ set_dfp64(t, &vt); \ } \ @@ -1300,7 +1300,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *a, \ raw_inf = 0x1e000; \ bias = 6176; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ \ if (unlikely((exp < 0) || (exp > max_exp))) { \ diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index b0a0676beba..b167b37e0ab 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -316,7 +316,7 @@ void ppc_tlb_invalidate_one(CPUPPCState *env, target_ulong addr) break; default: /* Should never reach here with other MMU models */ - assert(0); + g_assert_not_reached(); } #else ppc_tlb_invalidate_all(env);