From patchwork Sun Dec 22 16:24:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 852907 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp3033952wrq; Sun, 22 Dec 2024 08:25:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCV0ohDPhEEjPqwOji6yBwgwRm6W9Zm9neuihsrNYAUEjbe5NeqgbjktvAP0hHr75rZWUQQfZQ==@linaro.org X-Google-Smtp-Source: AGHT+IF3cTGg0ASGg2nATWggMkiTLCkuo1toRwNUDrVRetZCwZ313GA4NXUY4Z6CDXZugqudGxMw X-Received: by 2002:a05:620a:4551:b0:7b6:6c46:55b with SMTP id af79cd13be357-7b9ba6efbbamr1687487585a.7.1734884750715; Sun, 22 Dec 2024 08:25:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1734884750; cv=none; d=google.com; s=arc-20240605; b=CVKiWo81qrP8bhXadcnKXVZLUXWqjrKR8pXWUF6UFp1s+xLXwv2gyYW9vOAdBz9Lr0 BSyhAuJ3OrN3xGq0H8wOuXiEPCul8/A83JT91oN5QB8mycSxSZ1u7niHbf6WSAJtPCoG idCtW5VcYPdo+rM/9Xvdm0BekmgchP8VOkoE9265qwSPE3+P/VsUcoNu25vd3npxnG9B Q4/1jbHrqDph+jq6kdEkwTN5qCz+3ianHXujYfYuFsHRnwH+5WLatvAOuOZg/eJDr8fb SEEUbSYti6AAMWHhQqgoJzu9xDx3m8Ieflf6t+twPYaYWSR0bgas0QhbwEPYGxx1GcYw FSQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NUfpXkC8dy7CkOQ8+W7y3UlGToz+fRAfXgFSmgORkTU=; fh=vm85eyWrvOAHduw3sqEA+cYBqvHB7M0MHFcRJg7VWOo=; b=UeN3sEuMDA6Wsxnkcuwwfu1i10Wsf4n42vwhmPbHXpoPFGx2n6wlZLH2+n4jm8keRF nr7FZWbRg7p4mLIpEZy/XWlHTsJEYMbKLFmKZ4x2+zEhFVQoF6UQwEoaXXdKf17MaJ/4 vJ3558MGBFbb1L2G5f7TBCX5Q6kp/fLoAubSuQvu13IMybJ6SPfqt/P6Io+oXZAa5LS9 s+/fjITvn7n1QfW+B4nruyQqXzPzD9klUB84NnGCioClJs1JC3l0PqNy57iIjoZZcpZc /o+98X52gJQUoJfN0X7JP2Q1c28+Wjs9FH5eGASmhVkiLI+cP3czAIV0FXtGrbkbh0vZ 452Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uy0+mv2n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b9ac50df5bsi927918685a.566.2024.12.22.08.25.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Dec 2024 08:25:50 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uy0+mv2n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPOlv-0002x8-VT; Sun, 22 Dec 2024 11:25:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPOlN-0002ap-93 for qemu-devel@nongnu.org; Sun, 22 Dec 2024 11:25:06 -0500 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPOlJ-0002zH-2R for qemu-devel@nongnu.org; Sun, 22 Dec 2024 11:25:04 -0500 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-218c8aca5f1so37023425ad.0 for ; Sun, 22 Dec 2024 08:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734884699; x=1735489499; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NUfpXkC8dy7CkOQ8+W7y3UlGToz+fRAfXgFSmgORkTU=; b=uy0+mv2n05BPimnAeKgrtgsnrDjOLTeOQDISCH3kZEX/qgHYnwpMVbPFOjtZrzc6pa ojHNuELATZ4S5OAHtLn/0ipUQw0/v61P3njnkNnkd+afkq2og96qQXf46vJQRc2FHkYV ryckcBPzy90MxamR5Jd7gYOD1jsuBeI/IMrAtk6xRFKpyKo0M81D2JMQwZlAKtOrlJYw 3aMRiSBTADwppjO5JI98oYF2wHXj/HBNyOq7t9vBd0nVHSz2i9HqFvcOIxdNmZRAcBZ0 kM4Od5kX2t7YB52eXQwB8Fu5+NKyaKg4v/edBFG4Top8qDaCTfRUZO4VPt5ScgY+Mr0n R0iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734884699; x=1735489499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NUfpXkC8dy7CkOQ8+W7y3UlGToz+fRAfXgFSmgORkTU=; b=oyqTbweY+FRF71vslVTu4rrPee2NK3ldKeH64YBp5SvRj5CppV/1esmeOQka9WrL05 GoXKM71jgm23d+dDSdPHyFLotZ1pFL7d4KKYSUfrv8asv/J84MDqIMGyyl/hG/eyea8E 64hTe9OK5yAU/F7pGyeBPQjRfPVw1D/qwq5zSwPvAbcW0fakJ6/54mxdewqVnpIn4hwQ QyWDofIOIRCcoWuwOlfgfDSvinGUJrD/tVybI22KuyqqxLlwwA5LzviqKNNhRvh+l5Dd ToMjFLjw/w6SfjAhxK9BWyHFjNNtoxOAfuao4GJgRf3TNkQW5MP+Zi/6k6r2zwRZSG3K 5iZA== X-Gm-Message-State: AOJu0Yzhfkjct4dy6qfc+Rol9K4+wRlgwwGmjnABtLx/S/QL2azGXGL+ 9pxPhacVzRQB8d5VrVFYggp6VMd3OAyyD8sXxSWO3YVWiRNX3uSm1isQJ7c1gYtNvOGtSqpYhJR 2mWo= X-Gm-Gg: ASbGncuRZV1sUS9fWSyKTmVLQTB5TlCS2cHr8HrVyttCyJoyQTNRWuUFcwuHgNqI3Ai NKIIc1qdaZdUl7r4tKOi8b5V0fHfrRVqAZxuhr2WcIUb9U20HibU2iwofBBaHI7Y3JSuR4dnk1Z NHQqe7OklYKQXPjx9670rrB/65Dc6+DpQU4Y+CSbiX+qYTOd60ZR2U9O1AJwzCDo2LUi2fA6nKx NfkFSpPnZ7YmxbdFDa1kv4PYyaoLeK9H34nU5kyOb4l2aaMTXh8D5Cf9GzoiaQ= X-Received: by 2002:a17:902:f602:b0:216:3c2b:a5e5 with SMTP id d9443c01a7336-219e6ebb682mr129995655ad.27.1734884699199; Sun, 22 Dec 2024 08:24:59 -0800 (PST) Received: from stoup.. ([71.212.144.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc971814sm58461385ad.79.2024.12.22.08.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2024 08:24:58 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PATCH v3 18/51] tcg/optimize: Use fold_masks_z in fold_extract Date: Sun, 22 Dec 2024 08:24:13 -0800 Message-ID: <20241222162446.2415717-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241222162446.2415717-1-richard.henderson@linaro.org> References: <20241222162446.2415717-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Avoid the use of the OptContext slots. Find TempOptInfo once. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- tcg/optimize.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 9c1fba00fb..5aca1b3c38 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1722,25 +1722,22 @@ static bool fold_eqv(OptContext *ctx, TCGOp *op) static bool fold_extract(OptContext *ctx, TCGOp *op) { uint64_t z_mask_old, z_mask; + TempOptInfo *t1 = arg_info(op->args[1]); int pos = op->args[2]; int len = op->args[3]; - if (arg_is_const(op->args[1])) { - uint64_t t; - - t = arg_info(op->args[1])->val; - t = extract64(t, pos, len); - return tcg_opt_gen_movi(ctx, op, op->args[0], t); + if (t1->is_const) { + return tcg_opt_gen_movi(ctx, op, op->args[0], + extract64(t1->val, pos, len)); } - z_mask_old = arg_info(op->args[1])->z_mask; + z_mask_old = t1->z_mask; z_mask = extract64(z_mask_old, pos, len); if (pos == 0 && fold_affected_mask(ctx, op, z_mask_old ^ z_mask)) { return true; } - ctx->z_mask = z_mask; - return fold_masks(ctx, op); + return fold_masks_z(ctx, op, z_mask); } static bool fold_extract2(OptContext *ctx, TCGOp *op)