From patchwork Tue Feb 11 16:25:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 864093 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1289:b0:385:e875:8a9e with SMTP id f9csp325271wrx; Tue, 11 Feb 2025 08:30:43 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCX4wCc6Y7zh/Wr7O9GrI0nbP1JZSEQhSoO7pxMc0AJlwyp7uTryD/CgXu78PNXEKM/hIWZtFw==@linaro.org X-Google-Smtp-Source: AGHT+IFEZU1VoW2jtAc644sfmhng44ma6HX/9/q2OCUcUqlZfmyD/PH01vvbONen61GRNPpfayuP X-Received: by 2002:a05:600c:1d02:b0:431:542d:2599 with SMTP id 5b1f17b1804b1-439249a7ba5mr162907945e9.22.1739291443453; Tue, 11 Feb 2025 08:30:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739291443; cv=none; d=google.com; s=arc-20240605; b=iGbGX2SNq9Bg7icW43aCkJHCGd5gfed4mUHLkGUDfIzieotvfU8dLRYXUB71Cfr4C+ vOD75psJzRFJNQaiU4dMT9ztuaZWCk4h5bGkdMk7XxYQGQVl2gb3ceU0cDDwTEnxiVby fzgDi/rVngl4fVkJ0MFSiHfTFJFLDAvVkg9Vj48/tz3k81leXdqWnNTjyDV4Q5fyngtX DUJf7jIpCHmnBcgoASrsBkA4DjGaMD8H3LYPcehSBl30+aWWyjowO4hmBWgK36+6uUua cT5Jh2KtxhWyAQozL0xTU72lmXfr4elsbLC/+DlZjzNFEPrUK6/tLgo0QvHobtKoDr1i XTgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=7dyLKxLX4AdtS3tHaeGy6yAUU+znVzaV3FfmSWYqaks=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=kBzoO6bkp7NechrIl/RzMub9g0RzxuKdMask2TKwX9D/TvbgJvXHffOYakBlfUAPqh 268OUJWeKWPVQWF8IPkgZf0ySlFQaPs+CiOvrZp+Fbev82GXTG8Q59SBoFjS86S4eCq+ GkHh0E7YMvavJf622yGnpU0BNmn7zP1uSui2w8tKMWQ5wYGfLaq4xO09t7xOzKI0K5CF 6v4ScbDDdlrI6z3oabGg9jbakrIr0gaWPP8xlV9H7TjSSp7Owk2KKYDW6SV42KjBpw7s MBajqZbmE7/QgqdBSykEAW10n1tSA6wNd7aPXlolPsQW3kQQKtaxyZh/RE2ke8S+Glxa ueQA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J7rCHsvS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ffacd0b85a97d-38dd3c4a0cdsi5419571f8f.715.2025.02.11.08.30.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2025 08:30:43 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J7rCHsvS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tht6V-0007d6-J3; Tue, 11 Feb 2025 11:27:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tht5e-0006W2-Tt for qemu-devel@nongnu.org; Tue, 11 Feb 2025 11:26:27 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tht5d-00039x-71 for qemu-devel@nongnu.org; Tue, 11 Feb 2025 11:26:26 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4395561ab71so8284505e9.2 for ; Tue, 11 Feb 2025 08:26:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739291184; x=1739895984; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=7dyLKxLX4AdtS3tHaeGy6yAUU+znVzaV3FfmSWYqaks=; b=J7rCHsvSTmZQa3y+5ZFvVyLY3u8DhoIL879UfL31lBX8qfHYRbjVVOrAd+46Xcl4ON 9joppJQxOqIrkq6ZolNpFq08JG7sI93+h2BZ66b4aqP52Em0fo1RWwVzCq31nTLLVpN0 b7eau/4/VvjSllQWP8FMkesHNEMZcbMc1bbu7r7XLaI8bUnFowF1BfpbgS3OpHOwthyl F/Dt+eb6STebz5iMtWm1kxMcvyuTIKPQzmE0EJqmlk/4uozynKEX4/pl6UIXpHZr917q ZQdVEkU/CtOFs7XXliGhLZzZS380bNwRlyQANurVGt6H6c8qJhxkKT7csKFoLhE33veY /h7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739291184; x=1739895984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7dyLKxLX4AdtS3tHaeGy6yAUU+znVzaV3FfmSWYqaks=; b=cmgpLeve7RuToVdc7aY09wBx7SASMUE+K5R3YDxFS/Lgqownz3iYHF8dC0saZCxZgb wAlQunNdYKUtc+aivYmqNs6+VjwWQRGOiaiKuKE0OgxTwM4hiNxvkioAQ3ZFIbgQe/uc x1JNgG8nED8hOEU/dhp65A4cQUKvd6aKQhq9jq1dgsRwtaJSgYz9mpXYBK/YZzMYa/q7 kevsz2rqLKR2sAudthFDDSJQlBSuhPI/FVm8qgCLCtsrLbPAhdNsoUC5zN4wCV3NpteU jsoDHZ/pCA+3owTPsZ9mvRjFeKd0m0q7767ZJPdzIGSg5YLO9iDt1mc5zKLsr9AOCgTE ky1g== X-Gm-Message-State: AOJu0YzkL1fGvcf9CJSTJveeqqhEgWpXHwq3gqVnMeF6DqaL4SeVIUax xX/PvHGM+n0OTFCBozs1zeVBcTcYM76ISgHYfy0eadT2kxdgv8gyWDtAq4PAhbskctNdgUQYEQE M X-Gm-Gg: ASbGncupYKDR9bJQKjlDKN/THl2gfYXp5UTITErJeKtwlfhbb83l2YyoXL0HqyAuyzJ oW0rhso4rzOu3b/xX2cCJYp5GGuSrs1IIh0uCtBLI3QYGv+SJR07KWOoejlK0V28e9a0kwl2bbI 66OqzzAgS61PJWvmrs6buDwbZ46o7T/KwgmEDzoA2u4ri5/wmKaJWpJfabnLWzuyHcCBSdkHBeb jIk7oMuG0Sp0GwQ9/jpZYOFXl1Xr5jPMRJEvhSSkOSQ2ssXNn5BmXCQV963dhxdNfbiIM8EHaaf 7RI0FB3opAStxcGGSDfu X-Received: by 2002:a5d:64a6:0:b0:38d:de38:746d with SMTP id ffacd0b85a97d-38dde387647mr9062569f8f.47.1739291183739; Tue, 11 Feb 2025 08:26:23 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4393f202721sm82660455e9.21.2025.02.11.08.26.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 08:26:23 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 26/68] target/arm: Implement FPCR.AH semantics for FMINP and FMAXP Date: Tue, 11 Feb 2025 16:25:12 +0000 Message-Id: <20250211162554.4135349-27-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250211162554.4135349-1-peter.maydell@linaro.org> References: <20250211162554.4135349-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Implement the FPCR.AH semantics for the pairwise floating point minimum/maximum insns FMINP and FMAXP. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/tcg/helper-sve.h | 14 ++++++++++++++ target/arm/tcg/translate-a64.c | 25 +++++++++++++++++++++---- target/arm/tcg/vec_helper.c | 10 ++++++++++ 3 files changed, 45 insertions(+), 4 deletions(-) diff --git a/target/arm/tcg/helper-sve.h b/target/arm/tcg/helper-sve.h index f1b4606f763..8349752e99b 100644 --- a/target/arm/tcg/helper-sve.h +++ b/target/arm/tcg/helper-sve.h @@ -986,6 +986,20 @@ DEF_HELPER_FLAGS_5(gvec_ah_fmin_s, TCG_CALL_NO_RWG, DEF_HELPER_FLAGS_5(gvec_ah_fmin_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_5(gvec_ah_fmaxp_h, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_5(gvec_ah_fmaxp_s, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_5(gvec_ah_fmaxp_d, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) + +DEF_HELPER_FLAGS_5(gvec_ah_fminp_h, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_5(gvec_ah_fminp_s, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_5(gvec_ah_fminp_d, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) + DEF_HELPER_FLAGS_4(sve_faddv_h, TCG_CALL_NO_RWG, i64, ptr, ptr, fpst, i32) DEF_HELPER_FLAGS_4(sve_faddv_s, TCG_CALL_NO_RWG, diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index 4ae0426bf76..02701b10c6b 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -5765,14 +5765,24 @@ static gen_helper_gvec_3_ptr * const f_vector_fmaxp[3] = { gen_helper_gvec_fmaxp_s, gen_helper_gvec_fmaxp_d, }; -TRANS(FMAXP_v, do_fp3_vector, a, 0, f_vector_fmaxp) +static gen_helper_gvec_3_ptr * const f_vector_ah_fmaxp[3] = { + gen_helper_gvec_ah_fmaxp_h, + gen_helper_gvec_ah_fmaxp_s, + gen_helper_gvec_ah_fmaxp_d, +}; +TRANS(FMAXP_v, do_fp3_vector_2fn, a, 0, f_vector_fmaxp, f_vector_ah_fmaxp) static gen_helper_gvec_3_ptr * const f_vector_fminp[3] = { gen_helper_gvec_fminp_h, gen_helper_gvec_fminp_s, gen_helper_gvec_fminp_d, }; -TRANS(FMINP_v, do_fp3_vector, a, 0, f_vector_fminp) +static gen_helper_gvec_3_ptr * const f_vector_ah_fminp[3] = { + gen_helper_gvec_ah_fminp_h, + gen_helper_gvec_ah_fminp_s, + gen_helper_gvec_ah_fminp_d, +}; +TRANS(FMINP_v, do_fp3_vector_2fn, a, 0, f_vector_fminp, f_vector_ah_fminp) static gen_helper_gvec_3_ptr * const f_vector_fmaxnmp[3] = { gen_helper_gvec_fmaxnump_h, @@ -6764,9 +6774,16 @@ static bool do_fp3_scalar_pair(DisasContext *s, arg_rr_e *a, const FPScalar *f) return true; } +static bool do_fp3_scalar_pair_2fn(DisasContext *s, arg_rr_e *a, + const FPScalar *fnormal, + const FPScalar *fah) +{ + return do_fp3_scalar_pair(s, a, s->fpcr_ah ? fah : fnormal); +} + TRANS(FADDP_s, do_fp3_scalar_pair, a, &f_scalar_fadd) -TRANS(FMAXP_s, do_fp3_scalar_pair, a, &f_scalar_fmax) -TRANS(FMINP_s, do_fp3_scalar_pair, a, &f_scalar_fmin) +TRANS(FMAXP_s, do_fp3_scalar_pair_2fn, a, &f_scalar_fmax, &f_scalar_fmax_ah) +TRANS(FMINP_s, do_fp3_scalar_pair_2fn, a, &f_scalar_fmin, &f_scalar_fmin_ah) TRANS(FMAXNMP_s, do_fp3_scalar_pair, a, &f_scalar_fmaxnm) TRANS(FMINNMP_s, do_fp3_scalar_pair, a, &f_scalar_fminnm) diff --git a/target/arm/tcg/vec_helper.c b/target/arm/tcg/vec_helper.c index 9f77aa6b919..61e6e54570c 100644 --- a/target/arm/tcg/vec_helper.c +++ b/target/arm/tcg/vec_helper.c @@ -2444,6 +2444,16 @@ DO_3OP_PAIR(gvec_fminnump_h, float16_minnum, float16, H2) DO_3OP_PAIR(gvec_fminnump_s, float32_minnum, float32, H4) DO_3OP_PAIR(gvec_fminnump_d, float64_minnum, float64, ) +#ifdef TARGET_AARCH64 +DO_3OP_PAIR(gvec_ah_fmaxp_h, helper_vfp_ah_maxh, float16, H2) +DO_3OP_PAIR(gvec_ah_fmaxp_s, helper_vfp_ah_maxs, float32, H4) +DO_3OP_PAIR(gvec_ah_fmaxp_d, helper_vfp_ah_maxd, float64, ) + +DO_3OP_PAIR(gvec_ah_fminp_h, helper_vfp_ah_minh, float16, H2) +DO_3OP_PAIR(gvec_ah_fminp_s, helper_vfp_ah_mins, float32, H4) +DO_3OP_PAIR(gvec_ah_fminp_d, helper_vfp_ah_mind, float64, ) +#endif + #undef DO_3OP_PAIR #define DO_3OP_PAIR(NAME, FUNC, TYPE, H) \