From patchwork Wed Feb 12 15:43:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 864464 Delivered-To: patch@linaro.org Received: by 2002:a5d:4cc5:0:b0:38f:210b:807b with SMTP id c5csp186244wrt; Wed, 12 Feb 2025 07:44:18 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXpigfICB29Qh7UrKPB5KmW8W0FUt/QOrawv6gAZn/nBYrK7Rvz3B8jG34v4mMAA35pegJwVQ==@linaro.org X-Google-Smtp-Source: AGHT+IHKf1uuAOYddoZDB22b+nycJ2wuS6TjLewrbVUUtU3dXx7ypZPsaPPhypDlAxEDIEKXOHsf X-Received: by 2002:a05:6102:4191:b0:4b6:15fa:566a with SMTP id ada2fe7eead31-4bbf216f8d4mr4212590137.2.1739375058379; Wed, 12 Feb 2025 07:44:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739375058; cv=none; d=google.com; s=arc-20240605; b=Q9/I30Kk1Znt49urWX2gAsECKh0MbCJEoAoCzhe6tQZy5Eofv0Um/rNWBtJJMr0Dz9 ccl5lb+FxecDMI8tp9r156F1KYIZ9zuKYH09IffGgoFT9Zz+iJtFpIXWp/i8f8buLjBs NfgoUSzyUFykKy7fu/55xwg5xis1/4p6kdWmL7VfPFPnrQD9JzNx0zIPPyRNimenWQ9g uxVPKbTQBco3TRpzguNxvI7hyKYUqVLViIpVZ98KvjRs1MoF3omNUL+Ph5VSzFT48y/l sflo3/aSPaxVNU5/5A7R1sp8kofKyb5INqlAtYm+tuqwu84mhH75VVGM/rAujqLNz7rr fC4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UeIZFp/oTPSZTqhQVQuuyB79ED/0E39RbO6UofIGgaE=; fh=lzaa7I3YGCYWkDWyTcVwEb5cG79+nkOCzjzvwF81yJk=; b=e4UNsnzu8tdcrWial4dX1zGx91MqABW5LLLG+SUFQQ2YKzgrtqnMiEOTRFJ4hZWSxz 7vfOTgBpt1/oMNc65hBxBfAsS4/dvYMwXZzB/waZWycTVQkjb2d/yszKyCBE/J6MGtbG Ugmp3Z2lnYBRRHRAP8iuRPxTiHSIGOd4uAPfCWyycwoHy+8dpSDunpTyN8OR06uBVKKI x2jTaufqBK+vLoTMF67cYlDEaqJl5SjRhTDiiq6jcO6UXbBwuEeqHPt9qHDyuGFWNDkk o5uOOgJu2HzlbE3SzqM1VYhqobziC6rmb++RGdKMmyKq8A9+ryZI0mAAqorOS+w7hgyl c+yA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MemEiYgb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4bbb7f4d386si1863853137.490.2025.02.12.07.44.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Feb 2025 07:44:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MemEiYgb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tiEtw-0004Oj-NY; Wed, 12 Feb 2025 10:43:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tiEtu-0004Nl-53 for qemu-devel@nongnu.org; Wed, 12 Feb 2025 10:43:46 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tiEtr-0006sK-KN for qemu-devel@nongnu.org; Wed, 12 Feb 2025 10:43:45 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-43690d4605dso48146135e9.0 for ; Wed, 12 Feb 2025 07:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739375020; x=1739979820; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UeIZFp/oTPSZTqhQVQuuyB79ED/0E39RbO6UofIGgaE=; b=MemEiYgbn7cz9bCXJgmJrLDGqBPFtCKQXZLXvDOeG1eZbz86R2qLw8gdVIZtbRD+pV 2HqnPAEzVLHTyPajI7QdPU7rZwCvnGgOGQsOh4nwXx62NXlS89YH7yEDixXad5BEH6IB E4qgNIzRK9mprO8RoqzmW24l5/oWY3vGt2+rsKK/Zn97bzBOzhz/zstKNzCJxh2XAd/q 3Rqwxvx2uScDCl3or8pDf2tstOlYnJnYvVCngvuRm4aS+aS5fA8uAXM9vuqtTpUqVsEF YQTBOIPDu5kO3WPYEHuLwJ17LVd5ilX83RMXnro8Hfe3YhRGkWz/QU7/1wYC4y76/NuM mmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739375020; x=1739979820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UeIZFp/oTPSZTqhQVQuuyB79ED/0E39RbO6UofIGgaE=; b=ICOrSEmD6Kd7e8UeokUrcIgGm3T5caN0GIaaPiPRY0uS0R8ssO+3+V5naJdpbN7dDd hBkRe27x+c3eNpV5rOsRaOGCg/PyE7SrzmHf5QOajxV/Zi0UE9ZR+VBhKf1gHVcwgISu KT/JlL0uF0iX6GsdxovGuwBGkvbch+BgT2tjbP8se8WnKdePFB2CnsQZXZhugHGlpTVr o6ZaIwMXi59jLwcugfYhpEG/DcO4/LB2mobiZaEaXwrQDc1IW/oO4UOqUDgjxSmVQkUO kTzHzJbK3ckDMOlYfSuCvgJJfZxWlDwv7X4DSf83NzMBMHU2QG3x4/lRWlgQRLP7EqDg 4zng== X-Gm-Message-State: AOJu0Ywlv9WrKeEEYq1FGwsrbUa8OiNbW7WtSAHaZUGlMpF3k7kGTMIa fJEFO4F0xzdhd90RItvR+bYhSmF3BF845goBU7q+igRouU+QvtQrdRkcmo+ZtH+3S0AErMcO0gf T/eo= X-Gm-Gg: ASbGncuo9+rJjyay++PyYullOnvin+/CAzzyOJ+LtA4pedsMtf3j/8WgQZ4CMo59eRb w4bIwIa6+BbHJFU6fpaLDMeOws7+dAqyqpPtnTQqW/jXw6T7tJCPK9S9V/hMWN7wlTzYMF70BF+ zw6xc5NsMlvCDJVnfHvJ9iqd9qr+i7M7xUCRIONb7qUVP0j4+v1n1W0ZRxKlJPCo0s9w435bMLH 2uxCU5SsygqgZjyE3xIAW8o+ywFD+qK+ME/+7PbOjNAwPppnBJSKV6js9kJpvBa0IzCn4MhLvS7 uFGQSS5Va+XYhOhnlfmftQJFqUwbRQW5g39xp8isq6wsUjmyb1PMFgRoxmFN0aKM65meDbQ= X-Received: by 2002:a05:600c:4f85:b0:439:4376:cc0 with SMTP id 5b1f17b1804b1-439581ca7fcmr29685005e9.25.1739375020549; Wed, 12 Feb 2025 07:43:40 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dd8dee385sm10812262f8f.61.2025.02.12.07.43.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Feb 2025 07:43:39 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , Alistair Francis , Peter Maydell , Rob Herring , Igor Mitsyanko , qemu-arm@nongnu.org, =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/8] hw/arm/exynos4210: Replace magic 32 by proper 'GIC_INTERNAL' definition Date: Wed, 12 Feb 2025 16:43:26 +0100 Message-ID: <20250212154333.28644-2-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250212154333.28644-1-philmd@linaro.org> References: <20250212154333.28644-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The 32 IRQ lines skipped are the GIC internal ones. Use the GIC_INTERNAL definition for clarity. No logical change. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/arm/exynos4210.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c index dd0edc81d5c..b6537a2d64a 100644 --- a/hw/arm/exynos4210.c +++ b/hw/arm/exynos4210.c @@ -394,7 +394,8 @@ static void exynos4210_init_board_irqs(Exynos4210State *s) } if (irq_id) { qdev_connect_gpio_out(splitter, splitin, - qdev_get_gpio_in(extgicdev, irq_id - 32)); + qdev_get_gpio_in(extgicdev, + irq_id - GIC_INTERNAL)); } } for (; n < EXYNOS4210_MAX_INT_COMBINER_IN_IRQ; n++) { @@ -421,7 +422,8 @@ static void exynos4210_init_board_irqs(Exynos4210State *s) s->irq_table[n] = qdev_get_gpio_in(splitter, 0); qdev_connect_gpio_out(splitter, 0, qdev_get_gpio_in(intcdev, n)); qdev_connect_gpio_out(splitter, 1, - qdev_get_gpio_in(extgicdev, irq_id - 32)); + qdev_get_gpio_in(extgicdev, + irq_id - GIC_INTERNAL)); } else { s->irq_table[n] = qdev_get_gpio_in(intcdev, n); }