From patchwork Sun Feb 16 23:09:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 865891 Delivered-To: patch@linaro.org Received: by 2002:a5d:64e6:0:b0:38f:210b:807b with SMTP id g6csp863673wri; Sun, 16 Feb 2025 15:36:08 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUby27CAHviUZdyF7OKZr3SoY+GZu/DRDOUlDYc8k+bji9DbfECa8kU+yO3AgsjxH+/Ib2xpw==@linaro.org X-Google-Smtp-Source: AGHT+IHf0kzDxmWElFmr9MRmIJ3kQEaBP+Ld6tV0aJyrtAR9jr0gIhDVVLhvuPW+nmOPQAQnlYJi X-Received: by 2002:a05:622a:287:b0:471:8b81:e546 with SMTP id d75a77b69052e-471dbd5250cmr77705651cf.24.1739748967964; Sun, 16 Feb 2025 15:36:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739748967; cv=none; d=google.com; s=arc-20240605; b=KrmBNs1Rtfs4jYuaFGrNIfFes8SmQPWdUhjiTwXAiwQkk269SSUdtDr1bIDl6XeN+7 7wN//ivkPfqyyjKxmzvHqCYX5UKkQTvZqVmXisz96AgJ1zu9UoI0RCHLwnWeWuh+0QiB nhUCt2MuQEkSczrI81ISgoEuV6xAhaFP+Bu8XNWDhkJK4jKMqsS5XMjN/2xAbOPiqVVg boAK6aJdUAtBSIALJlU34ZyRQo5DnAeZ8u6JV3V12FGyc1gcOQhU8C+OC1HhxhhLLxLV N7X761mlTmompktY8RwXgkCfCCDcZR99i2J2gNjrTblbDu49JnTxS1cYog9nYzNm3fO3 Hpsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1RvvgZaKuSF9edcsX84Gnnmj3wiiQW6WmhJ/O+pUWs0=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=MgvY9eWVLqNjuXUlqP6XDS7gbT3LQKsXm82zyihhBUNy8p1vY9h2ydc84eK3wbS+mx cf2IXtGofwrvaZ3smm0Rthd1KYi0qHpwCO2NPUCeo5UB8STnqp/8DrzB4Dw3oYaZgGyH wyPUv+UwTwye/ZWlvOBaFachTVZi2CRqDN7QL2OzkYwYuhuia2rfy6+zi1/L3RrbE3LQ QnUzjpP3VI9yT4SgcwVW7DPjkyHmQhoATVGXQxXlqbDynQPL53oGBan0m03sT64c/uZY ujIS9LBz1L5S1VZ8dBwj0t5QxPsNu/PCgLCkaOQUYCmzGPXjKE0pkalPzt3i1tWaFlgQ owgw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VoYR2HM9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-471dd8da8desi38776241cf.612.2025.02.16.15.36.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Feb 2025 15:36:07 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VoYR2HM9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tjnuZ-0004ie-GJ; Sun, 16 Feb 2025 18:18:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tjntK-0002sA-6I for qemu-devel@nongnu.org; Sun, 16 Feb 2025 18:17:38 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tjntG-00063o-Vk for qemu-devel@nongnu.org; Sun, 16 Feb 2025 18:17:36 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2211cd4463cso11956405ad.2 for ; Sun, 16 Feb 2025 15:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739747853; x=1740352653; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1RvvgZaKuSF9edcsX84Gnnmj3wiiQW6WmhJ/O+pUWs0=; b=VoYR2HM9kzDDCEgxrLUI2PCGViDCN5+Fk/wCyD8SXQ1SZQfW0c64ArktWZJJsXG2fX O2TGFN70Mybfh9fM5Rp3d/sBsnxqCfd8pGaqTXaK3THs6CXNhHvmSoV8vjlHP+0Hx4wJ wjJbOSTTc8igUx2wUpGcGK7oi0TU/CFQ5MZF/upxIoQngEeM6hAoKwFMdPpgfSVEALSp +WFFnOv1I7IoPSDDfDLO3ZDjEoyNICQsPYxJPLI/eLDfn81QvnOxefuhfsDIsiaV/gcQ ooTyAMfCmNGQsIfUQ1XmyH9I3JJWzUsieforzbwAx19sIc0va536T4jFBhhgVfgrpyFb fphg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739747853; x=1740352653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1RvvgZaKuSF9edcsX84Gnnmj3wiiQW6WmhJ/O+pUWs0=; b=r74g63pblWoKES21SW+xVkc3JREcxFRNxJmwbMpahQIg1MSNX7gyrkYbbmwmjui8KL pQ8bmn98FUboEqAWpFA8gA2F/NUp4B2tz+rp1M6XanbzTjrvKE5Mp9ibgrvndFiXe0qb U21YN8F9UlE4ck+cBX0Fe8BU0Q66V8cHZSqu6XvL7HM4V2MmroZYJYbl2C/cwM+lNudf UGghDHIaCYbpQ0Ox9rng6lXdsmeUzQzjlZce4THJAeNsYzyX3SK6gfKV9p6sRMR7GPT4 32wKwjuis6aSGYDXKBJmEItlmihx5piviIXBCOiCJFGspTW31unM/tX2sYNns7cX3O+h G1kg== X-Gm-Message-State: AOJu0YzFQQ2j38tBBF9jJ8TBFFMzUFsqtgUhnssfRC2irEWHSd6HUbIH z4XNhpUSpwrA5By1gLoiYA28p3bZTfOH5Myv5xRdOOkRXhCJN9udZ/VO+lBCir+U1LcPaAxA1aC b X-Gm-Gg: ASbGnct8gpd6Uit/vbbFMZWW0g3xNKIlrli1lpowRz+4Ih3rVFG0nKYrQyfPrsGm0zO h5vGwPO5w+8zW/VV3jCvqYn41c7H890pfwJFwkmWb/xv4Zboc8vDtU2hc/R7dGy4s0I9CvodEqI 2bpMUSft3gvdsEdEAm8xaWV/ZyV+RqdR+Do+crj42pBx+GiyuQ5he1FhGMLRM57woHreHB7BiZl QUwq4idiyxk9M+SgGqA/A2n9zp4v6LfF68GHl1L0uJ7Z4To1VVVsKXfrlUFsKHLFett9JH1347A eLqwxI25DQOs3dnGPrNJ9+K0FQNIVXxrvyr1B5WGlIFQapE= X-Received: by 2002:a17:902:f651:b0:216:6283:5a8c with SMTP id d9443c01a7336-221040b1310mr127153465ad.39.1739747853328; Sun, 16 Feb 2025 15:17:33 -0800 (PST) Received: from stoup.. (71-212-39-66.tukw.qwest.net. [71.212.39.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2213394d6c8sm5449885ad.181.2025.02.16.15.17.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 15:17:32 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 105/162] tcg: Expand fallback add2 with 32-bit operations Date: Sun, 16 Feb 2025 15:09:14 -0800 Message-ID: <20250216231012.2808572-106-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250216231012.2808572-1-richard.henderson@linaro.org> References: <20250216231012.2808572-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org No need to expand to i64 to perform the add. This may smaller on a loongarch64 host, e.g. bstrpick_d r28, r27, 31, 0 bstrpick_d r29, r24, 31, 0 add_d r28, r28, r29 addi_w r29, r28, 0 srai_d r28, r28, 32 --- add_w r28, r27, r24 sltu r29, r28, r24 Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index edbb214f7c..8b1356c526 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -1105,14 +1105,15 @@ void tcg_gen_add2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 al, if (TCG_TARGET_HAS_add2_i32) { tcg_gen_op6_i32(INDEX_op_add2_i32, rl, rh, al, ah, bl, bh); } else { - TCGv_i64 t0 = tcg_temp_ebb_new_i64(); - TCGv_i64 t1 = tcg_temp_ebb_new_i64(); - tcg_gen_concat_i32_i64(t0, al, ah); - tcg_gen_concat_i32_i64(t1, bl, bh); - tcg_gen_add_i64(t0, t0, t1); - tcg_gen_extr_i64_i32(rl, rh, t0); - tcg_temp_free_i64(t0); - tcg_temp_free_i64(t1); + TCGv_i32 t0 = tcg_temp_ebb_new_i32(); + TCGv_i32 t1 = tcg_temp_ebb_new_i32(); + tcg_gen_add_i32(t0, al, bl); + tcg_gen_setcond_i32(TCG_COND_LTU, t1, t0, al); + tcg_gen_add_i32(rh, ah, bh); + tcg_gen_add_i32(rh, rh, t1); + tcg_gen_mov_i32(rl, t0); + tcg_temp_free_i32(t0); + tcg_temp_free_i32(t1); } }