From patchwork Wed Feb 19 21:08:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 866446 Delivered-To: patch@linaro.org Received: by 2002:a5d:64e6:0:b0:38f:210b:807b with SMTP id g6csp2279377wri; Wed, 19 Feb 2025 13:09:40 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUn/u1kM4c3RPD6eDzmuf+Qp2XaNc9pCrk0/8JBOaFYy+b85PtrxrFQ19Zml8yoxH5oLpGHZw==@linaro.org X-Google-Smtp-Source: AGHT+IEtoVID+0/p1C+K/BVeyKlBuEN0y3oJ8uMxoCg9f/uClH/6cQNty6qaI9PWtPjUXaJaJqfx X-Received: by 2002:a05:620a:4412:b0:7c0:b523:e1ad with SMTP id af79cd13be357-7c0b523e3c9mr794232785a.47.1739999380184; Wed, 19 Feb 2025 13:09:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739999380; cv=none; d=google.com; s=arc-20240605; b=gbQNzcmRNVJqNW0/Y7LjdkR0sk+0qGmPlKuTLAAKfZFz92xn//ruI372hnoBYLGDRn Wp4ieM2mamlrUjwmH3Rpm/potXa54ApwaDykOo9AEEG/7dFD3CdM+xlIeHE/vbm4mS5z qfEe1I6cw2GSBcjgzcmd0PjxKBFZAIKVnfB+i6TXkVuf8V1DEEPD5YpRYUf7oNziEPcU fUYuhZOm5PmqJEA2cu+ANl01YW0pLMOUuLQjmzadYWXHv1mHWFCyFS74zguTz0CZrPoc SgmDaU0IHoKc2I6ZQPi/JZLh5HrKMCdjkvS8K8fkgrgHdui9v/LlGWWtAvFTUeVdo1UR L5MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JhwkxvyKpTQZAt9mirHnFUfpe4JfORLzfwmDQNOghTo=; fh=ENgXamMRtMaKwPEbkwMSHtIq+uF6Gw1pUKUB7L+e7mA=; b=WGHD1sX2dFGbgBKhrpykiE6V6O07IwP042GqnhZYKtyhZWQwm9kAxxHCTbSc6cTwiN qbxjVoecDCFINqgxdPqEpibXBVWsHLmKWemGJkKwxv8H1nma1iGSNE4pKjV4/v8P+v4p Bydbhl1IFtGU0h5lW9PT5pDAZpl5pu2GKCLnGVAC29Jipk2PNbalmE03m6w3jqasN3Fn Fw/9zqe9RuWgUnOLDgplVtvX/OnoWDtVdW6Aa3kNIYBJXwj2pQsZswaEq97qzofRmlxt jY+/E27JXarpo5EPz2oZv2h8LPDqQf0ewoF/tWir8C3R5F267ma6lM9E7i025xEACm39 iVmg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UKbdE6q4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c0bbf00b41si134593685a.37.2025.02.19.13.09.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Feb 2025 13:09:40 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UKbdE6q4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tkrJq-00025u-MI; Wed, 19 Feb 2025 16:09:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tkrJi-00021f-VV for qemu-devel@nongnu.org; Wed, 19 Feb 2025 16:09:16 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tkrJh-00007O-7A for qemu-devel@nongnu.org; Wed, 19 Feb 2025 16:09:14 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-439350f1a0bso1672195e9.0 for ; Wed, 19 Feb 2025 13:09:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739999351; x=1740604151; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JhwkxvyKpTQZAt9mirHnFUfpe4JfORLzfwmDQNOghTo=; b=UKbdE6q47vKyzx8BxWVf2/iEOXagu9xtHPhXkyT3a5o/87nMVkTbKXDdjHcYcLS0T8 rgfT5aRd1PTaw5q6xS/csfWIJvZmo++9zsvM+nQ6PrpCxI4UiMIGczr3x6bvQEXx/u3T 02cQqQwW7XpZyuBD7bGlNxfgEKiy7aMq7ITfHVtiEqL2fZnqDdgb1yVxc+FXsr/cdCe5 7pO9nuSvYKzbawcrXUApdxr+owcUwe1dnbc3jV6YTGJRaO8hvFusnIPV0slBo5tKP+So cB7El1n/POo7rVW9LsjswKN/xrX8sI17W0kFs22xl9OBrW7NfXLQM1i0CS1KK9vJ1ow+ H8uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739999351; x=1740604151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JhwkxvyKpTQZAt9mirHnFUfpe4JfORLzfwmDQNOghTo=; b=DDkNfZPXJgG7OR3YjN5+X75ShuJPXrRB3oFNoWfbZjp/X4zcg09ffug5jIxKAWg2lp 2mDfCx2P/CxOEUaKsbA873k4ejs4bML784jPRkdHI8M0pslZh/0lSzpaeGTzHqAkR77n +qhPZ5Iw7qJ1rU2i6Ta9GjGjHqtulDrNPKoPTrw0ragCoX27Q0a/wKZD9MCvxj3Ve4J6 +Fymrxv3b2lUSqJCIH2mzmbJFamUcSW4jnyd4nbm943OEWBQebD6QdZv5SYFdhqyU/l+ Akeify96nQ7VR7wJ3r1HhLcQN5DTZX57rY6UT4QXRNp8BtJr032lT/cvF9o+fkuLG6MP xX/g== X-Forwarded-Encrypted: i=1; AJvYcCXU1s9N2wKPoZY7V79hWvpZUiYpCcbsHawF97imkFo11y/z2njhPwD0+msYgnr5IZw+VMplH1Ih2J+W@nongnu.org X-Gm-Message-State: AOJu0YzGZ7Bxzui/ohrmYhgU3qYn2l0uInToFdTyVhYHfNKbkV1hKK3U OawPKScqEZaDcA/O0fhosjXCC05pire+ch5TfcMx9/PYn+qsxaXLnzUGofMLlkg= X-Gm-Gg: ASbGnct2W2QzSWJyct8ybNZx45K2qdFSBy7cbOE0Q/iQKQV0NqAmpIStKeiNl5lXwdT ugct6ZBL/iSs6MazFilB7Qj3DpOczuj4j/2qOf9ld1ik+aciruuyN9XV2EcSEyOJ/2sY7hzmAsZ R/LQH7ys4QrRZlhNscMmhhdu50zcUFbN9pn0ejy7ZZvpVQqDHhuGHXVBiDCZpgqoFUpvLuCRH2d Rk8TdWmsM6f2IvifCCg7miJaYn6GcNZTCbGe84tvR4H24l5xhM7hdSf3/AnbikIJp5prsh069o4 AIf5nBFMbH+iuDzVbby/QNTlJO2nF1b7uDYHj1fYg2qYPc7zBKO0M0pBIy0L40nubw== X-Received: by 2002:a05:600c:4e8d:b0:439:892c:dfd0 with SMTP id 5b1f17b1804b1-439a30e91femr5924815e9.14.1739999351505; Wed, 19 Feb 2025 13:09:11 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43986320899sm93060315e9.38.2025.02.19.13.09.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 19 Feb 2025 13:09:11 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , qemu-devel@nongnu.org Cc: Evgeny Iakovlev , Rayhan Faizel , Luc Michel , Paolo Bonzini , Yoshinori Sato , Magnus Damm , Peter Maydell , =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , Shin'ichiro Kawasaki , =?utf-8?q?Philippe_Math?= =?utf-8?q?ieu-Daud=C3=A9?= , qemu-arm@nongnu.org Subject: [PATCH 5/9] hw/char/bcm2835_aux: Really use RX FIFO depth Date: Wed, 19 Feb 2025 22:08:37 +0100 Message-ID: <20250219210841.94797-6-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250219210841.94797-1-philmd@linaro.org> References: <20250219210841.94797-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org While we model a 8-elements RX FIFO since the PL011 model was introduced in commit 97398d900ca ("bcm2835_aux: add emulation of BCM2835 AUX block") we only read 1 char at a time! Have the IOCanReadHandler handler return how many elements are available, and use that in the IOReadHandler handler. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel --- hw/char/bcm2835_aux.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/char/bcm2835_aux.c b/hw/char/bcm2835_aux.c index 73ad5934067..c6e7eccf7dd 100644 --- a/hw/char/bcm2835_aux.c +++ b/hw/char/bcm2835_aux.c @@ -221,7 +221,7 @@ static int bcm2835_aux_can_receive(void *opaque) { BCM2835AuxState *s = opaque; - return s->read_count < BCM2835_AUX_RX_FIFO_LEN; + return BCM2835_AUX_RX_FIFO_LEN - s->read_count; } static void bcm2835_aux_put_fifo(void *opaque, uint8_t value) @@ -243,7 +243,9 @@ static void bcm2835_aux_put_fifo(void *opaque, uint8_t value) static void bcm2835_aux_receive(void *opaque, const uint8_t *buf, int size) { - bcm2835_aux_put_fifo(opaque, *buf); + for (int i = 0; i < size; i++) { + bcm2835_aux_put_fifo(opaque, buf[i]); + } } static const MemoryRegionOps bcm2835_aux_ops = {