diff mbox series

[10/25] tests/vm: bump timeout for shutdown

Message ID 20250226140343.3907080-11-alex.bennee@linaro.org
State New
Headers show
Series maintainer updates for 10.0 softfreeze (gpu/tcg tests, plugins, MAINTAINERS) | expand

Commit Message

Alex Bennée Feb. 26, 2025, 2:03 p.m. UTC 
On my fairly beefy machine the timeout was triggering leaving a
corrupted disk image due to power being pulled before the disk had
synced. Double the timeout to avoid this.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/vm/basevm.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Huth Feb. 26, 2025, 4:15 p.m. UTC | #1 
On 26/02/2025 15.03, Alex Bennée wrote:
> On my fairly beefy machine the timeout was triggering leaving a
> corrupted disk image due to power being pulled before the disk had
> synced. Double the timeout to avoid this.

Triple the timeout?

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/vm/basevm.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
> index 6d41ac7574..9e879e966a 100644
> --- a/tests/vm/basevm.py
> +++ b/tests/vm/basevm.py
> @@ -83,7 +83,7 @@ class BaseVM(object):
>       # command to halt the guest, can be overridden by subclasses
>       poweroff = "poweroff"
>       # Time to wait for shutdown to finish.
> -    shutdown_timeout_default = 30
> +    shutdown_timeout_default = 90
>       # enable IPv6 networking
>       ipv6 = True
>       # This is the timeout on the wait for console bytes.

With the commit description fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 6d41ac7574..9e879e966a 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -83,7 +83,7 @@  class BaseVM(object):
     # command to halt the guest, can be overridden by subclasses
     poweroff = "poweroff"
     # Time to wait for shutdown to finish.
-    shutdown_timeout_default = 30
+    shutdown_timeout_default = 90
     # enable IPv6 networking
     ipv6 = True
     # This is the timeout on the wait for console bytes.