From patchwork Tue Apr 15 19:24:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 881331 Delivered-To: patch@linaro.org Received: by 2002:adf:f902:0:b0:38f:210b:807b with SMTP id b2csp638726wrr; Tue, 15 Apr 2025 13:09:13 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWY8LFF8Td5scmqc6H3P3DYn/ApSnzlKcrqn7WsUYroyameFYt2JQepvyDtEgNDCrNkgxrcFQ==@linaro.org X-Google-Smtp-Source: AGHT+IHPMUXATCLt45SUwmNJUXeiFlvIt1ort4+jURzubJn0/hGO9VSovYA/9uP1TdVVB2rJAk0g X-Received: by 2002:a05:620a:3913:b0:7c0:a70e:b934 with SMTP id af79cd13be357-7c91419a4afmr142495685a.7.1744747753342; Tue, 15 Apr 2025 13:09:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744747753; cv=none; d=google.com; s=arc-20240605; b=gRglhT9K2RVcOZ5TasTV2mfugA0VPm2bpdZSTHLvNNkMzI3wywj2bQu74a865rH+5e 2Ih/sCuDD5+7T8VhUURauUuDJZ4buKE+B1eDu3OhCBmqQs7ew7o7R/Rz7QBac1qJBUiu VA0sk9lWksYquqOUllfqBDndSCLtXQ3WMHwJKRRdANQJbCsPHXDVOkmHLUjquYwEjy5e 7JPQghXA9JibmMnJL+vZz+gZSEF2peqEGCqZmGJT4FqgHLdJyPqQlT8RKtvec3WvgG+O qorVyhSDqAsL+xdHgSp6xCVqVoT1TCbFRBmN2YekWIY5ewWNDoAAPU6er1BGHqi7HvSk uVZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=hFnYeJKgvTco35iIcxVFzyI3nrLlH/dm/A1BmcF8NhQ=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=MBwIXpAHVPqkcOXSjA7vKswhiZ0lpWw51KAZ6iSfBFK+s23aUYRiKaafZbUGbyboXy RKthGOQCsLLKfoEnz2TIXEqVRG2LCPDE64xYzdXUcSbcgsFuhnaKOZvth1iou+aZPdn+ axgcjhAAjz7a9tbjigLxbl8GXZWvnrFOp0Hdt2ez+xBKq+j5PhjSaKJp4nXMNi7+VwAh RIZU7/c2/CwADkPAboC1+pfQed+n8LRf8Cb5GDw16KwLhmqif9G+zAbixMDQsPvczb0q LMzHAzSY/lhgGcJaSUWHRrcVpInTrCR+xJv0M+X9UUQ69+AKUxHH3DiLas05n9yIkwal uiXg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JpqkSkbp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c7a895c9c4si1113467585a.189.2025.04.15.13.09.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Apr 2025 13:09:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JpqkSkbp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u4mIE-0004rv-FT; Tue, 15 Apr 2025 15:50:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4mCa-00032y-VV for qemu-devel@nongnu.org; Tue, 15 Apr 2025 15:44:17 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u4mBc-0008EE-Jv for qemu-devel@nongnu.org; Tue, 15 Apr 2025 15:44:12 -0400 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-7c0e135e953so622682885a.2 for ; Tue, 15 Apr 2025 12:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744746187; x=1745350987; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=hFnYeJKgvTco35iIcxVFzyI3nrLlH/dm/A1BmcF8NhQ=; b=JpqkSkbppLkhj4C9QTEF2RporsoLUMpGy6ILhIin8aUlb/TOczb7KGCbMPergsAC+J 2qwed08xRKudcyf541Eg5dGGm1JFkptPC7P9yEsDr3XnlZXfBw+pj9cnQPQ7R4kCVkM3 gI4MIzA3JDkAawiv5pAwlGzj8+vLIP1k1GhE3y1YxZnNP5Mfw+dPsO1tM8GjulUAjHmR G7GGNyu3VXubWOjvdNqIOj7M4m/VIxl36sHBMQ5UUKlk4mjv9Oj3OhBZEWqP2WBByTR6 I9TATSEDRJ0wnwN4HWf70vwrpN23NEFFCv8HMlu/8K7xS6zYU2EhvR4SD5IEMDu2TAp5 t3jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744746187; x=1745350987; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hFnYeJKgvTco35iIcxVFzyI3nrLlH/dm/A1BmcF8NhQ=; b=See8nu0RnNzTgwSaoaqfCs1KDArvubp834dFQg11MfhVXnFpW7Y1L24lgOlFGiAVnu bPhbye1E8AV5EqJZmNr1BPWozmJzQhlC0bGDCFSsW+4HZIFhK2QdmX9jtHm+xgxx1Q5V WTyoBzy459o/uYxTEpPaPkCrajAq9IJj0AgeM5r5v0R8ZWbuIdWHDdhJrKu2HetxRtYo SJMz6uxL+4hS+JxTzdyfyIu/wB+tPFTewMAU6iMp/MRfF7+hiqqzn2U5LYojk5zGy5gE 4Nvj5XMfsu7l+qeTn6mo/TgmF96VsR3KYTUZSgFutswgsTOXLtxzIm4+HcSrecVk0/DN 3ceQ== X-Gm-Message-State: AOJu0YwX6WEqtnF8629p3Z8bHClN0/jyDc8/WlUhosC0lJvbUYctytBP CLLdjY2DbakSusAuZJGjkfVRKT3JoWggGEdmHXkfwwpbW3cPTxgUd4KJ6Bro1u1G7vkLgnIAOQA Y X-Gm-Gg: ASbGncu7892US/aWkSV3xk4+3o45IUGmvFVSD1IBaGtPwctQWdSglghMOumeCkIushp 3WHBe9urfaNpH3GFcO2k/095jTrtAAj+NYRgZNwdoQrXE7gpe47RuZM7HwIAYXcBaxD5gcvcV3Y Nja/mIs3yMJ5TTKN4bVGqO8pjxv5FHmFd/BWHwo2tiKULW9w0L3Qj0QD8/0NXZhxM7B/elilUry QC8y5JTamhu1Q3w5zCHmzlo/7J9CACt9p+1iNPixQk8o12cueYh8zbbexURLqkZpAVfYQjHdjUL O3gHu5tzS5vFPYMj/lIOJfHTfVKu1TK+uLF5ATxsNya9ArujOfmtmnRHmWwmMzSmEQ7B9UcHc0s = X-Received: by 2002:a05:6a00:2e11:b0:736:52d7:daca with SMTP id d2e1a72fcca58-73c1fafc18dmr1126600b3a.18.1744745761169; Tue, 15 Apr 2025 12:36:01 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd230e34asm9155603b3a.137.2025.04.15.12.36.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 12:36:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 124/163] target/arm: Use tcg_gen_addcio_* for ADCS Date: Tue, 15 Apr 2025 12:24:35 -0700 Message-ID: <20250415192515.232910-125-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415192515.232910-1-richard.henderson@linaro.org> References: <20250415192515.232910-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::733; envelope-from=richard.henderson@linaro.org; helo=mail-qk1-x733.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé --- target/arm/tcg/translate-a64.c | 8 ++------ target/arm/tcg/translate.c | 17 +++-------------- 2 files changed, 5 insertions(+), 20 deletions(-) diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index 934d66848a..99545a900d 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -1076,11 +1076,9 @@ static void gen_adc_CC(int sf, TCGv_i64 dest, TCGv_i64 t0, TCGv_i64 t1) TCGv_i64 cf_64 = tcg_temp_new_i64(); TCGv_i64 vf_64 = tcg_temp_new_i64(); TCGv_i64 tmp = tcg_temp_new_i64(); - TCGv_i64 zero = tcg_constant_i64(0); tcg_gen_extu_i32_i64(cf_64, cpu_CF); - tcg_gen_add2_i64(result, cf_64, t0, zero, cf_64, zero); - tcg_gen_add2_i64(result, cf_64, result, cf_64, t1, zero); + tcg_gen_addcio_i64(result, cf_64, t0, t1, cf_64); tcg_gen_extrl_i64_i32(cpu_CF, cf_64); gen_set_NZ64(result); @@ -1094,12 +1092,10 @@ static void gen_adc_CC(int sf, TCGv_i64 dest, TCGv_i64 t0, TCGv_i64 t1) TCGv_i32 t0_32 = tcg_temp_new_i32(); TCGv_i32 t1_32 = tcg_temp_new_i32(); TCGv_i32 tmp = tcg_temp_new_i32(); - TCGv_i32 zero = tcg_constant_i32(0); tcg_gen_extrl_i64_i32(t0_32, t0); tcg_gen_extrl_i64_i32(t1_32, t1); - tcg_gen_add2_i32(cpu_NF, cpu_CF, t0_32, zero, cpu_CF, zero); - tcg_gen_add2_i32(cpu_NF, cpu_CF, cpu_NF, cpu_CF, t1_32, zero); + tcg_gen_addcio_i32(cpu_NF, cpu_CF, t0_32, t1_32, cpu_CF); tcg_gen_mov_i32(cpu_ZF, cpu_NF); tcg_gen_xor_i32(cpu_VF, cpu_NF, t0_32); diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index d280018138..e5aa76d44a 100644 --- a/target/arm/tcg/translate.c +++ b/target/arm/tcg/translate.c @@ -493,20 +493,9 @@ static void gen_add_CC(TCGv_i32 dest, TCGv_i32 t0, TCGv_i32 t1) static void gen_adc_CC(TCGv_i32 dest, TCGv_i32 t0, TCGv_i32 t1) { TCGv_i32 tmp = tcg_temp_new_i32(); - if (tcg_op_supported(INDEX_op_add2_i32, TCG_TYPE_I32, 0)) { - tcg_gen_movi_i32(tmp, 0); - tcg_gen_add2_i32(cpu_NF, cpu_CF, t0, tmp, cpu_CF, tmp); - tcg_gen_add2_i32(cpu_NF, cpu_CF, cpu_NF, cpu_CF, t1, tmp); - } else { - TCGv_i64 q0 = tcg_temp_new_i64(); - TCGv_i64 q1 = tcg_temp_new_i64(); - tcg_gen_extu_i32_i64(q0, t0); - tcg_gen_extu_i32_i64(q1, t1); - tcg_gen_add_i64(q0, q0, q1); - tcg_gen_extu_i32_i64(q1, cpu_CF); - tcg_gen_add_i64(q0, q0, q1); - tcg_gen_extr_i64_i32(cpu_NF, cpu_CF, q0); - } + + tcg_gen_addcio_i32(cpu_NF, cpu_CF, t0, t1, cpu_CF); + tcg_gen_mov_i32(cpu_ZF, cpu_NF); tcg_gen_xor_i32(cpu_VF, cpu_NF, t0); tcg_gen_xor_i32(tmp, t0, t1);