From patchwork Tue Apr 15 19:24:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 881366 Delivered-To: patch@linaro.org Received: by 2002:adf:f902:0:b0:38f:210b:807b with SMTP id b2csp642867wrr; Tue, 15 Apr 2025 13:19:39 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUT+dnBA+qL6NGep5x4cqD9+PnA5HuudVNfqMpwx7XI0RNhcneiqb7Z1+6+u3qd/ZgykkbQgA==@linaro.org X-Google-Smtp-Source: AGHT+IGnD7fW8xFQYXp2DQ1sXRxDSmKSBisJzuRU2xudz2F0wPicyLiaHozQAU5NK5ChXzs4xudQ X-Received: by 2002:a05:620a:4247:b0:7c7:a555:8788 with SMTP id af79cd13be357-7c91415fa80mr121022385a.2.1744748379267; Tue, 15 Apr 2025 13:19:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744748379; cv=none; d=google.com; s=arc-20240605; b=GUCTrMwk5aE14u3ZWjCOiJuHPlW6NyycQw5ZMI8g5RvjpIrave35SFCiUoQUO+OyNc 4nJskkYqgeZAezvnV6rvF0YUC+lsR+VVtzML9K14dDIekZdp6shXforuOjzzOFh0J/z2 k+BAaUQtZ3UwPTLPqcyPAdYtdMxgTmJt1pLc2WgRngK80pc8dtX6E2Zy7vX6cf3u7phe gwqpaXVrqk5aujmVGoi926KnNMMrPT3ffV49t80TDivTefNPNcbwDTM4xIdXh85VFixq lq00x7PQJ6yqaUD/TY0c4TbZBgZeMKI4VbLp3fHrKm6KzY4W7qbbXx9dS+6qGcqJQQ1O o8gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=xnOKRkVYNjmbi4selFTGOFb0kWlEgpoJ/8u2eUimwZU=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=S7Yhv8QmpGRTdjfpIeRG5v5jZ0jnl6Tpr75zlj0BRcktvL+/6Db0ILajGdUzmd/LaB aSZftcHQXKbpFYJy5IBMSusjSlV7gQSyhJ+BIAUJMGUN9Y7zYwVBZDLowsX4J54PX8n/ RGaEl/Pc1UKUBzAUgjwHO7GQUVdlGruoXV4hZRUg5zN7mJ6vUGiprksRqMLrzeB0D0oa y19gNTBa1cbqHMPy4/9RFCh63FCX2u3Mi7KQnz0VWaY3zPR4enYZryetIdxj8pcugkzf YNw2sRA7X/LZb9F0henDdYP3l7QuRYkDtzB94dkK349v3hmrLbftOja5N5lbmMtejTXJ brtw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Dk38dW4g; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c7a894c7c5si1178827385a.103.2025.04.15.13.19.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Apr 2025 13:19:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Dk38dW4g; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u4mKB-0000tI-AF; Tue, 15 Apr 2025 15:52:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4mCy-0003HQ-JH for qemu-devel@nongnu.org; Tue, 15 Apr 2025 15:44:38 -0400 Received: from mail-vk1-xa29.google.com ([2607:f8b0:4864:20::a29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u4mBx-0008P6-1s for qemu-devel@nongnu.org; Tue, 15 Apr 2025 15:44:35 -0400 Received: by mail-vk1-xa29.google.com with SMTP id 71dfb90a1353d-524168b16d3so5113150e0c.0 for ; Tue, 15 Apr 2025 12:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744746207; x=1745351007; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=xnOKRkVYNjmbi4selFTGOFb0kWlEgpoJ/8u2eUimwZU=; b=Dk38dW4gI3EpYdQX/UD4mrk7mBN44F6YtCG2EhtXBw49hSjWEh2cM+vRy+JISPCRHT 1bofD2xRhPnzr3lM1+kws4YuXoTuTX3/RVsUjN8OmnBPudQfPXvU41nRAftorzGhGY1h J/kKxOi7yjY/eslXQAQhGYf5u/wvsquZcHwMWI2mbwFWp5k4eoD46ODEOBJH/9v9NHO+ T5DtDGzAyrHcKvfDCe95koP/PjwNory+GfYxxcHmmLxf78K7T95u5iG2EF/NJ7QY9idV 7+dYl2wHePjPtZ+bW35p84c7BILYuLZuLl3xPHZiYxR8zV/2rxMRFm+wM4J+oB1Z6pOS mzzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744746207; x=1745351007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xnOKRkVYNjmbi4selFTGOFb0kWlEgpoJ/8u2eUimwZU=; b=AJdL4IgpLopFzjY3yOVxLykRkr2ImJYllKixUtGxs4mwR6FLtKWjFJxhr/eGJ5UN/a gjwQC8gbXDR+OL6FiCRanEfxCvdBjeiL6gOeCQ6YhkCOTT8wyp2fmOQRsw3EpZRn6iW2 c+hYzNVNl/JmmWPt3zHk0vQ237NcvUsDOfqvra/HereslN84Namse9MCNmTg67s3Wlu8 QumRcfvMNoMvVgFLpV/7T1AqmksXaw7HYItLJ55qDVDvMOypCeM9S4SXEQAKm4fqbZCO wVTwve+6GAgNK4NmVlsPpLFsO9r+npScHIV1rWUFEHKB1Z0lJNMfQhxq52OMyfLnoKt8 LcJg== X-Gm-Message-State: AOJu0YwOYZNG9eXTLUjM02+bQTvYUYjwXEzSxICAtAZgPEncZPs2l3ob aCJGbF0Acc6I1Or8wD9GIueDUreYHiwKQjM0t1PiIKTIcF4ocBY94+tx4wXb3XBJ+WcT0VIGw1k s X-Gm-Gg: ASbGncul7hwfbdrOoswGDAjytSspCNhNSkcKwgDZ8lv3uzj7AEQYYyOcagkz6iwVTR/ kvJ6/ikmoLX8lcFSD4Wk0Jdj/W/tOxYlQuQcQQZLTuSAeeL0cyXyK7SjyYAMtV6snxqyloflMFy nWQa6FqlnhEQcIz7fNPEeatHvCQz9qpFKbKF+ttzRWyzyaj2FxwlJpMqahsvj3jxKVdD7yCVRbo Ex6RgVoSju7ErBAiiJe7TUar3chgmWoe5Llk7AqcU3xLlQMkt2MwCQV1/t6JzundVZA2EQO85Xk B0f3UdI1gsxJOFUI2j1Hd+D7HrsJwshD2J1jeLcMHy137VEHOmMPf7fw7nl/w0sticit/pQUxb4 = X-Received: by 2002:a17:903:1b6e:b0:223:4d7e:e523 with SMTP id d9443c01a7336-22c31af4df7mr4728125ad.50.1744745763929; Tue, 15 Apr 2025 12:36:03 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd230e34asm9155603b3a.137.2025.04.15.12.36.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 12:36:03 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 128/163] target/ppc: Use tcg_gen_addcio_tl for ADD and SUBF Date: Tue, 15 Apr 2025 12:24:39 -0700 Message-ID: <20250415192515.232910-129-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415192515.232910-1-richard.henderson@linaro.org> References: <20250415192515.232910-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::a29; envelope-from=richard.henderson@linaro.org; helo=mail-vk1-xa29.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson Reviewed-by: Nicholas Piggin Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé --- target/ppc/translate.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index a52cbc869a..e082d50977 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -1745,11 +1745,10 @@ static inline void gen_op_arith_add(DisasContext *ctx, TCGv ret, TCGv arg1, tcg_gen_mov_tl(ca32, ca); } } else { - TCGv zero = tcg_constant_tl(0); if (add_ca) { - tcg_gen_add2_tl(t0, ca, arg1, zero, ca, zero); - tcg_gen_add2_tl(t0, ca, t0, ca, arg2, zero); + tcg_gen_addcio_tl(t0, ca, arg1, arg2, ca); } else { + TCGv zero = tcg_constant_tl(0); tcg_gen_add2_tl(t0, ca, arg1, zero, arg2, zero); } gen_op_arith_compute_ca32(ctx, t0, arg1, arg2, ca32, 0); @@ -1948,11 +1947,9 @@ static inline void gen_op_arith_subf(DisasContext *ctx, TCGv ret, TCGv arg1, tcg_gen_mov_tl(cpu_ca32, cpu_ca); } } else if (add_ca) { - TCGv zero, inv1 = tcg_temp_new(); + TCGv inv1 = tcg_temp_new(); tcg_gen_not_tl(inv1, arg1); - zero = tcg_constant_tl(0); - tcg_gen_add2_tl(t0, cpu_ca, arg2, zero, cpu_ca, zero); - tcg_gen_add2_tl(t0, cpu_ca, t0, cpu_ca, inv1, zero); + tcg_gen_addcio_tl(t0, cpu_ca, arg2, inv1, cpu_ca); gen_op_arith_compute_ca32(ctx, t0, inv1, arg2, cpu_ca32, 0); } else { tcg_gen_setcond_tl(TCG_COND_GEU, cpu_ca, arg2, arg1);