From patchwork Tue Apr 15 19:22:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 881215 Delivered-To: patch@linaro.org Received: by 2002:adf:f902:0:b0:38f:210b:807b with SMTP id b2csp622646wrr; Tue, 15 Apr 2025 12:26:11 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU4csXVs7KRUxyZJOyxrCnXV832q8uQTECZuueH8iDVvj2DsxC/PH3k1YMKcv8u3ZhzxgYqQQ==@linaro.org X-Google-Smtp-Source: AGHT+IE//K4HuRuNxSeH5hdeLIovJyd/A62/zUSAqWvSbVKxxR/97pPAhsQ3n1+3SPjO3WTT4Teo X-Received: by 2002:a05:620a:4724:b0:7c7:a64e:e8b5 with SMTP id af79cd13be357-7c91427bebamr127632085a.48.1744745171110; Tue, 15 Apr 2025 12:26:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744745171; cv=none; d=google.com; s=arc-20240605; b=eCX8ciWqQ1lkcalrEOPBlMVl+eoJM4TIZOwqkjEeXK2OU9I+OxaF+Rr5vZU9lzV5x4 2hSJkHNkNxTxS0WoenWcFLLfzA8piej6dLHyc+NZff8+6oY7HvYpigrlHMOGLcrBm7bc UMPNE3ESnQhlxP9hazgNW9Xg17HJ5evPhc2I8yVcdw3pdeMKkF11uYTL41L04gz/Ni9f VpZu2gPsJ4rPVz8YepAZxKYwBU2r1ch+3z9eDKyN19SBxaDsXe5TBH7zaMpvl1S60RoR lZ+Etzwvr2YxfOZttaBWZFq4RFYoG/WqiBj1QPU5SpnbsmnnFxg7x6Ep9Q5kcTRoEHGZ gWWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=t/zQGxGO/NlI4vEg03ZEmNBPOEr3MMOkBBYL06UjaHI=; fh=kQadAhxV42GJ3cd2VUw1RyURv/zJQGvmUdF7iLEVTtc=; b=gnXqafPiPbIaDYwnSwqo1R18MrcIvSL7t6fz7o8Qs0xcxpXd9sm96UR7KzdB29RG1z 69Nn3mGupxIqZWAb3QFAeTMgjRz64+EA15vtPcnQudhoczvVmsT65ZbnRDLguTnkYBZg jru/OC+vUCCbv5QnmDen1W9TThTsy/XdtfbACaKUVKKuZMNCOCFJXub0FYcr1B/mJ5CN RfOWc5mBdUaEDQtC210hZeYki5kRXRjSBBJMYiyAK+fjNJwlN6HVFN+/cPgCzNmKKpC0 T9vTDjIZbqhv4ZgOCuSW6uYCk9bN/VmeyA6E6bnct9UhIq9IfFkx0mjpJlqm+VFrMF9a D2gg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="BUVEO/W1"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c7a895ab72si1124639585a.156.2025.04.15.12.26.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Apr 2025 12:26:11 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="BUVEO/W1"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u4luS-0008Px-TU; Tue, 15 Apr 2025 15:25:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4luN-0008MD-0i for qemu-devel@nongnu.org; Tue, 15 Apr 2025 15:25:23 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u4luK-0007v5-I2 for qemu-devel@nongnu.org; Tue, 15 Apr 2025 15:25:22 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-22580c9ee0aso63496995ad.2 for ; Tue, 15 Apr 2025 12:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744745118; x=1745349918; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t/zQGxGO/NlI4vEg03ZEmNBPOEr3MMOkBBYL06UjaHI=; b=BUVEO/W1OLm2odocvh/xlaRHrA+35jgD8VgUFLOuwoZGaHpqCe1VYGBNlhucw+AQaU nxnJ2LYbWGadcXdNw1tVL8u5YqGqsyInd8lVG5PaQ1QQu2gMfBC1KBUAqGxjq3EQxx9e 7Cow0QUi0M7ziU6ezG1fVv8ZoplfHZ5TAdGoJOyTywcHr0FJQIuHfvma85t3MgvrkfZf 1Wal8JwjVjgip//O7o26FXO5ys/I0TVzUaOYc2u4z0wtikCMEHMyzxTqKKzPFGoEAmwA wzSbvEedac7j9VTS6q9Cvt/euS0RHXVsZpdNiXrpBeIJw5lgAHmIYWpZ38iWzA90Kdz7 Ib1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744745118; x=1745349918; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t/zQGxGO/NlI4vEg03ZEmNBPOEr3MMOkBBYL06UjaHI=; b=Exv2hhQRe6eN7t124Te0aUko/nnFE96RJGu2Y+H92HYCi8d5fMe9JeyMumR9SSt7gn gwFoDjE7sDeXO3YNrYyBQpsW5T+D2YxaKtQdTOa24WjOnVDfE4D+mjkfyyb4lx24Myxk soRH+2Su7wLCOQe3Lb0zKj5zr9vD3fblzqNbX7BUUmbsdngTA8BGvfwKCl1hwn2lEGbh czBflSBtsZDJ15IxgaXBFdPVjVaYPJhz30WL0FUFfxNDZr5FhQGLYqKvpr+LLomvFDpt DuuQEg9BHWg4ebDgSZVlzXzv5zsZAV3SwRj+/s+BKsN6RT7jFZa34NQ7AXYbq7XVhfm+ gz1w== X-Gm-Message-State: AOJu0YwR2OR9YDNLIZa4BhSE+ACkYOHIvd5V0g0BzXol2gb4tE0Ul43c UFlK1AMl72weLAY6P0tWxIzYN3eQmi5tGnl3EgI7Rc4E3hJmToYecZ/vd2EWqyI7joAy2dHUVOd / X-Gm-Gg: ASbGncv2He5PBh4Q4xTXBfiFEJjT69ntjIsSrKrwNXomXvW+XBtEEYprGuzmEhWrJqi EvxFRiK/CQ5bl/CFyVvxKi2WYFodD1pY5hlgszC+hfsxVtGXzNOu8aX1PBqMi3fjv9520h3/dxm gWLjWvFGCAIMgvbdREza66SRwI1Wxzo5RWrvGe7hICLgB2k+ITl72F2NptQjajeJ7trAuBpQ3ia 9zQGfF02ytak0KZYY6e8OE+U34sKb5bCsHkjwt8lrWDmXYezuW9NClMJR2N2pCT+Zhec8c984g8 AQOX/0D68sRrh4iiZUT4s/ykKVnWO3w8k6UpDVpAZf2ZUy1yQag+BDYo5hzd63f+cC9/fzVKwrp vJZavfPeFuA== X-Received: by 2002:a17:902:ea12:b0:220:faa2:c917 with SMTP id d9443c01a7336-22c31a7ab9dmr4634005ad.34.1744745118000; Tue, 15 Apr 2025 12:25:18 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd22f82ebsm9225124b3a.92.2025.04.15.12.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 12:25:17 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v4 002/163] tcg: Use extract2 for cross-word 64-bit extract on 32-bit host Date: Tue, 15 Apr 2025 12:22:33 -0700 Message-ID: <20250415192515.232910-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415192515.232910-1-richard.henderson@linaro.org> References: <20250415192515.232910-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index fec6d678a2..f68c4f9702 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -2804,9 +2804,18 @@ void tcg_gen_extract_i64(TCGv_i64 ret, TCGv_i64 arg, tcg_gen_movi_i32(TCGV_HIGH(ret), 0); return; } - /* The field is split across two words. One double-word - shift is better than two double-word shifts. */ - goto do_shift_and; + + /* The field is split across two words. */ + tcg_gen_extract2_i32(TCGV_LOW(ret), TCGV_LOW(arg), + TCGV_HIGH(arg), ofs); + if (len <= 32) { + tcg_gen_extract_i32(TCGV_LOW(ret), TCGV_LOW(ret), 0, len); + tcg_gen_movi_i32(TCGV_HIGH(ret), 0); + } else { + tcg_gen_extract_i32(TCGV_HIGH(ret), TCGV_HIGH(arg), + ofs, len - 32); + } + return; } if (TCG_TARGET_extract_valid(TCG_TYPE_I64, ofs, len)) { @@ -2844,7 +2853,6 @@ void tcg_gen_extract_i64(TCGv_i64 ret, TCGv_i64 arg, so that we get ext8u, ext16u, and ext32u. */ switch (len) { case 1 ... 8: case 16: case 32: - do_shift_and: tcg_gen_shri_i64(ret, arg, ofs); tcg_gen_andi_i64(ret, ret, (1ull << len) - 1); break;