From patchwork Tue Apr 15 19:23:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 881379 Delivered-To: patch@linaro.org Received: by 2002:adf:f902:0:b0:38f:210b:807b with SMTP id b2csp645210wrr; Tue, 15 Apr 2025 13:26:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV5EVJKIVM909U4jvx33OCkycx9oyFMd4tnD8SvPVo5Do+bPYj2PuGdOmtyVU2w1VWQ3Z9/lw==@linaro.org X-Google-Smtp-Source: AGHT+IE9ZqB9VKPITyXEZlEYJ64V5a+zka5wGr6be/bIEC+J3uMUTmmv/X0s9oj2Iz7ACIw0yhn8 X-Received: by 2002:ac8:5fc5:0:b0:477:6f6d:533e with SMTP id d75a77b69052e-47ad39f50cdmr12085911cf.3.1744748807325; Tue, 15 Apr 2025 13:26:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744748807; cv=none; d=google.com; s=arc-20240605; b=hqjKlxe8ao4VELDX5Qwi+N2cmeJYgs5BJkPOQbzZTuzLPQ/YMiWbD0GIz/B4a3bbL4 u0BHmMiSC7ZXnXPez+HEB1rNUogUtSM+ZUjgIhqWDCW83seKrgbLU4KdlSzm1PbRUeyB UcRCUpG6TAyDRF997nPkEqLjBGkOL0wWNUgDghHnP3uAMTT8IyCrvIDiJGm1BSRp4cXL 9s6PVtkzNPrhm4JnUmraxLWOO9UEnmpp8gGYYAjJ58rzZ8B1UgWHiTuM6DIxxfw+q231 W7JEUQlEpreOT/6tf8wA10uEeAwtvfno4AvijFLI0zBqfflos4+/wYh2USnORvWxR72P h9+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=/icXR9rPS4TkXbbgbXcXZQMlEO+JipjRgWA+vktz47I=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=QPUusTl1GlWKB3xMD8ELK2mqbEixsCsQgAsEi8n+UnFwQPk2xZdwDRQFnP0w60URg8 5dktcNV8+X6RjDJz4NLtYAnT4m4I1tujblj2k17u8hGrWFKSnXuDy3zhgRYZtWSej2iK s8O3FWmq+xsWJlcv2jyDoYcQ8fLKnjhp8OZA+5NEWCWESIMCa5M090nB+NLI6w2O8pTl LrhJk/dd1VwGzwBO1Fwd3t5XovYGKIA+Ta10+eXQ3wER6nxW7/78okdaLlgLJ/2KV9Cf Km0KgWNhJuu6ZjFWxRbeg9LNAi366tIUxPUqAeF3TUbSLxKhP3o0kHIGkK2RLheBBk6F jlpQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wlJcd6oJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4796edeba21si118389861cf.573.2025.04.15.13.26.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Apr 2025 13:26:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wlJcd6oJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u4mJu-0008PH-6V; Tue, 15 Apr 2025 15:51:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4mAS-0006Jy-Ky for qemu-devel@nongnu.org; Tue, 15 Apr 2025 15:42:19 -0400 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u4m8h-0006XS-Ct for qemu-devel@nongnu.org; Tue, 15 Apr 2025 15:41:11 -0400 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2ff799d99dcso5586397a91.1 for ; Tue, 15 Apr 2025 12:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744746009; x=1745350809; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=/icXR9rPS4TkXbbgbXcXZQMlEO+JipjRgWA+vktz47I=; b=wlJcd6oJDJsvH3Wb6OI+EidxJuU64EEWh2eRMSG1KVHuChi0JxMGAFb4x3Fg7P9xIU kTpZdNWxI3XG/q+ixYkb1f58YhFYcSvkFQ16lhO0Y9VyxurWJlbQk+llaM/dvLwEOJHT cON8SevNvP3tLWxacn9fzaZQT0CtdE5+SBLc+7jnFNjk2mHJP1M1edBdT36H5ShNlqpS oTGEhFEfkonEtrIFAgt+Y0Gho784iYms/eAvopV94g1Q3xHA+5ouMtoLGWUCldAsqIfS wOrDx4zSoctD2/jj8IrTDKYrUwcQMkWP419WQ+TQnr0yOrNeoZS3P08Nw8vkrpx+ZeuG bbag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744746009; x=1745350809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/icXR9rPS4TkXbbgbXcXZQMlEO+JipjRgWA+vktz47I=; b=siwtD2OwPou2iJNc4aOL4FV+Es2rfHY5gAZjFBna+T860VsdidAU+8k55sQtZeq6+P 0CAJXNwNMcJTCG2LB8iIgKPulumwACDYpfu3at4wb+VbUCAGpZT5Ve1DnTqtcuVxG45N z4drai5qOpHnSyGcvmE8ykTaUKsZ0ru+4Rh9f2C0+B4VzIAtGEOXMhastDxIVuGA6gAf TaNIqCMAgzVHsvrXQ6xGO6nJjLsLx8IbBKtmIM+utghfnkCtDXww+KGoThbAZh+d72Mu kHNsKiUh2JGErl3ZHGAxZy9OUOqEPijbp3TiSGjg64cT23d3lrkmULsnpCuKPmzc1SnJ YZwQ== X-Gm-Message-State: AOJu0YyCNxMs1tSYEp7U1AhqiB1T1OfYVOUf0TKMQc9gDBpRJ/nX5RRE baG++/gqdJ/wVcP1xM21XU/gyijBpKINeep4cpP7cYIW6aGKRfu3BeoNTm2yQJYk0QPE8fnPFwR J X-Gm-Gg: ASbGnctV4y0R61/A7sqrUVjMuSWxqTkNm3XBqIopCc3ibo5WBoExQu6G9a522NMYQxu nOaJxw7wYgIb39YUEGaeEGuDt7boK2S/dqLrcFq87CQvit08SK2/HYfB1ivihVRTxEHYc9bovL5 p2kaCZIwL8K4iWSxfnjS+eO6e4o1ghPYByZDGLcFr0kxF4PxA+jcw7bsg3Stl4bMrnPPINcu4Yp GQnmddBEu2l2PyBkcoCrSSwIUJ0GEq0ahtDxZF9rJIfCEVRGYYA82TGdwNPrz9ZNt+mc3Y8sU7W aPzG1kfQgVCRn9yppAXy+zuYA2vKvlewMswHCZMP8IM5Qk4MjfX9IbFr+UWfsh+Dv+JPO+RJHRY = X-Received: by 2002:a17:902:d48b:b0:223:5a6e:b16 with SMTP id d9443c01a7336-22c318a901bmr5367015ad.5.1744745547271; Tue, 15 Apr 2025 12:32:27 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7ccbd5esm122062355ad.248.2025.04.15.12.32.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 12:32:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 083/163] tcg/arm: Expand arguments to tcg_out_cmp2 Date: Tue, 15 Apr 2025 12:23:54 -0700 Message-ID: <20250415192515.232910-84-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415192515.232910-1-richard.henderson@linaro.org> References: <20250415192515.232910-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Pass explicit arguments instead of arrays. Signed-off-by: Richard Henderson Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé --- tcg/arm/tcg-target.c.inc | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc index 3d864c1c1e..cebd783285 100644 --- a/tcg/arm/tcg-target.c.inc +++ b/tcg/arm/tcg-target.c.inc @@ -1254,17 +1254,9 @@ static TCGCond tcg_out_cmp(TCGContext *s, TCGCond cond, TCGReg a, } } -static TCGCond tcg_out_cmp2(TCGContext *s, const TCGArg *args, - const int *const_args) +static TCGCond tcg_out_cmp2(TCGContext *s, TCGCond cond, TCGReg al, TCGReg ah, + TCGArg bl, bool const_bl, TCGArg bh, bool const_bh) { - TCGReg al = args[0]; - TCGReg ah = args[1]; - TCGArg bl = args[2]; - TCGArg bh = args[3]; - TCGCond cond = args[4]; - int const_bl = const_args[2]; - int const_bh = const_args[3]; - switch (cond) { case TCG_COND_EQ: case TCG_COND_NE: @@ -2344,11 +2336,13 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, TCGType type, break; case INDEX_op_brcond2_i32: - c = tcg_out_cmp2(s, args, const_args); + c = tcg_out_cmp2(s, args[4], args[0], args[1], args[2], const_args[2], + args[3], const_args[3]); tcg_out_goto_label(s, tcg_cond_to_arm_cond[c], arg_label(args[5])); break; case INDEX_op_setcond2_i32: - c = tcg_out_cmp2(s, args + 1, const_args + 1); + c = tcg_out_cmp2(s, args[5], args[1], args[2], args[3], const_args[3], + args[4], const_args[4]); tcg_out_dat_imm(s, tcg_cond_to_arm_cond[c], ARITH_MOV, args[0], 0, 1); tcg_out_dat_imm(s, tcg_cond_to_arm_cond[tcg_invert_cond(c)], ARITH_MOV, args[0], 0, 0);