From patchwork Tue Apr 22 14:54:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 882991 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp2456762wrs; Tue, 22 Apr 2025 07:56:46 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUSBrTg2YJubYnpNV4lYllTzZbY3C5j4Frx4mZ8EEpquUQbkpsLy3lD8hddN6fwn4vJ2KWU9A==@linaro.org X-Google-Smtp-Source: AGHT+IGhilBLbOcUSpGkhMiKx3vhEmSIgYjnCceuCUw9Xb/Xv9nsDUeUYcCA+0w4q65P8lrEaQLL X-Received: by 2002:a05:620a:454a:b0:7c5:e92a:cba3 with SMTP id af79cd13be357-7c92804027emr2702253185a.49.1745333805740; Tue, 22 Apr 2025 07:56:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745333805; cv=none; d=google.com; s=arc-20240605; b=XrEmWn8xDa0BByrC3dctVIP37n41zrzlrqNSQ80wlwzOtNVnZczsurDimkmNSpKhM2 HwTm8IDOfw2Ke3xh4Iw4tUpQByUuCMF9S+CejDbaBYsYixSRY20fBbv0c2PQi02VWzWB 6AK+/xx3k1vndndeCnmEvTUP+qALLI1Q+EirjEckD57F88aqqplfY5/5b22bAIs6j5/Z zudUWxR6qZ+TrWLKek2MMxrYwVmGNXFrci55hXI8htYnA7GGDmeqsPk0+L7M/ULdubJf PbXP9r+s9wA5uaZJf4CiseyX6+y0o79UMpKDfkAbk4/qO5tSmYDJZnB5n57ISNrBNn3S avZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MPk7GJ/Q7Awhqe4M7LOu5PgmoZQozcGdMhSTLUXghio=; fh=98FKcUbfHOMAWlQQi9/5y14VVYgcGa56vjU1mKYkvXI=; b=VBvTU2UjIu3rLLJ1/8ItjP2OpZrBtItYSl6xuMSBlw0ZnnvVQNGb1lU4JWQz75lepC TWWAb5hNtXK5JZiwa1uwtU19cS3RkNSnf2W8v5VnE7SpMvkTdoXP1syAbeXCVnymrWIN L5oHCUXaF12neTvtIv+3OEhjhXGhecAcJUjYLgVe6OxojOdXBjQfMeQ+gdfq7w4Xcl3L M3qEJyKD26KgKk6oJgQqoW5wbwkKpn7ZyJE8UBulmLuHiJFilJzTmlx3odslNlT8h65/ bDJPWWDCETK3WT7KDVpJh2Nvj1SIrY4gOeCCk7PwYdgvDsCaGpBKw1aiRddQTnqGoBwo ouoA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JtpCxqdO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c925aaf893si1185978685a.75.2025.04.22.07.56.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Apr 2025 07:56:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JtpCxqdO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u7F2Q-000705-5Q; Tue, 22 Apr 2025 10:55:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7F2M-0006vD-T0 for qemu-devel@nongnu.org; Tue, 22 Apr 2025 10:55:51 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u7F2K-0005Dd-PU for qemu-devel@nongnu.org; Tue, 22 Apr 2025 10:55:50 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-39c1efbefc6so3269419f8f.1 for ; Tue, 22 Apr 2025 07:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745333746; x=1745938546; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MPk7GJ/Q7Awhqe4M7LOu5PgmoZQozcGdMhSTLUXghio=; b=JtpCxqdOjhWWHD8tE1zsP3daosMbTYHZ60fbmsy1ejgt2oxGpfADL1aov6tjvXt5Jy P+2e1lcBfB8KYJFp4S2jyF/aZLOKSqoCyxVGlpcSOnkakznxTyE0gWvjio1B1YKoj04A XGJUFeLc9GnHVLo0ttpI7elAb254CZlw2JYR1thVtRa9Og7rBUCS9HR2ltWztDg3VAFk qtLB0QaYvC++fjyzsQszJgSJ7uHYeDHqDMrqFC3scbrFmpBCM/NQOeU+azPpxCn3na9W 311Rp5BQYR1S76xz0Jg/YSYVfVI9stMHc0pI5H6ZsTFx8yw4hDUMg+6bObWSnRZx3YxE gz1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745333746; x=1745938546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MPk7GJ/Q7Awhqe4M7LOu5PgmoZQozcGdMhSTLUXghio=; b=ELVgBcqb6kDkuNaFWddO2YRaaeogmO+NBfY4lV7uz84wx6tvYtMyc1ICVb8mDMKHwj 2W/TJGX9lU+L8zoiG5Cu/j1HJJxZr98zR6I7y/xkDFZgSRD9qZsiUjt0N4ULfahOo6uP HTycVOhVaB/BAxy16DffaY4PhSLgCHPOOiurpuuIFtEdE08DmK+wK6wgXB4JXRU5+1An M8AVo3YXDtj9G61Ld96EGbGgzINxmVFNjk6aVut0Up/o0gBuE29Pd5cW5OIHBOTQhqyC 8DrqeJHSBW3x8iALeWUX5ky+SWVbA9PFOdWVg+Nfk9BAz7S831G3VcFrKBu2o7joYH92 RcKQ== X-Gm-Message-State: AOJu0YyRicMwsVcYaJBdaJNBY1pLaWkoiFv6h9MaZGX3npHq2U301SFI 6mz07HcFI4xrpelQ2s1Ii74/OHrzHQDeWU7Dllec4LJciVNJn8WW3KJwxvDGbp61dLQaG3ntqaU 1 X-Gm-Gg: ASbGncvLok5hKO23OoTh1ENcR8Qway+2nqY7M42NCewE599G7sbAXEgNnNCn9Y3Ps7g ttzzJK8+PaWVoiutU/fqWhqbGiZ1aU3ibrHQWohMV0UGoUMR3sEIBv0XyS11yQJ7/7xSUBlYkRq LWrmtAGNmn/Z8hv7MM3/Ftb7g1XhhKeGe4+J3efMNc39ixX30qwxpZ0K7HmKUrOIQRGgxaiB0ts f57Onfj2AlDfS/HqxVWfmZNCtyUuT0TNghINn4VWApogEbM6N5RzOqk/3wkOGC+lpTpIQrPDfiN go7gCs31z452mmH+w67NLv632S69DSqGbGp8pMcPNBnwjzL4HcGwZ3fK18BtiC6fEUMmiZ0llMn ztAvu81ki64IbAws= X-Received: by 2002:a05:6000:400e:b0:39e:cbf3:2660 with SMTP id ffacd0b85a97d-39efba26294mr12321098f8f.3.1745333746355; Tue, 22 Apr 2025 07:55:46 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d6db131sm176258285e9.28.2025.04.22.07.55.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 22 Apr 2025 07:55:45 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Pierrick Bouvier Cc: Richard Henderson , Anton Johansson Subject: [RFC PATCH v4 09/19] hw/arm/aspeed: Build objects once Date: Tue, 22 Apr 2025 16:54:51 +0200 Message-ID: <20250422145502.70770-10-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250422145502.70770-1-philmd@linaro.org> References: <20250422145502.70770-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Now than Aspeed machines can be filtered when running a qemu-system-arm or qemu-system-aarch64 binary, we can remove the TARGET_AARCH64 #ifdef'ry and compile the aspeed.c file once, moving it from arm_ss[] source set to arm_common_ss[]. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- hw/arm/aspeed.c | 6 ------ hw/arm/meson.build | 4 ++-- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index ce4d49a9f59..6de61505a09 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -180,13 +180,11 @@ struct AspeedMachineState { #define AST2600_EVB_HW_STRAP1 0x000000C0 #define AST2600_EVB_HW_STRAP2 0x00000003 -#ifdef TARGET_AARCH64 /* AST2700 evb hardware value */ /* SCU HW Strap1 */ #define AST2700_EVB_HW_STRAP1 0x00000800 /* SCUIO HW Strap1 */ #define AST2700_EVB_HW_STRAP2 0x00000700 -#endif /* Rainier hardware value: (QEMU prototype) */ #define RAINIER_BMC_HW_STRAP1 (0x00422016 | SCU_AST2600_HW_STRAP_BOOT_SRC_EMMC) @@ -1664,7 +1662,6 @@ static void aspeed_minibmc_machine_ast1030_evb_class_init(ObjectClass *oc, aspeed_machine_class_init_cpus_defaults(mc); } -#ifdef TARGET_AARCH64 static void ast2700_evb_i2c_init(AspeedMachineState *bmc) { AspeedSoCState *soc = bmc->soc; @@ -1714,7 +1711,6 @@ static void aspeed_machine_ast2700a1_evb_class_init(ObjectClass *oc, void *data) mc->default_ram_size = 1 * GiB; aspeed_machine_class_init_cpus_defaults(mc); } -#endif static void aspeed_machine_qcom_dc_scm_v1_class_init(ObjectClass *oc, void *data) @@ -1937,7 +1933,6 @@ static const TypeInfo aspeed_machine_types[] = { { TYPE_TARGET_AARCH64_MACHINE }, { }, }, -#ifdef TARGET_AARCH64 }, { .name = MACHINE_TYPE_NAME("ast2700a0-evb"), .parent = TYPE_ASPEED_MACHINE, @@ -1954,7 +1949,6 @@ static const TypeInfo aspeed_machine_types[] = { { TYPE_TARGET_AARCH64_MACHINE }, { }, }, -#endif }, { .name = TYPE_ASPEED_MACHINE, .parent = TYPE_MACHINE, diff --git a/hw/arm/meson.build b/hw/arm/meson.build index 09b1cfe5b57..f76e7fb229f 100644 --- a/hw/arm/meson.build +++ b/hw/arm/meson.build @@ -39,15 +39,15 @@ arm_common_ss.add(when: 'CONFIG_XLNX_VERSAL', if_true: files('xlnx-versal.c', 'x arm_common_ss.add(when: 'CONFIG_FSL_IMX25', if_true: files('fsl-imx25.c', 'imx25_pdk.c')) arm_common_ss.add(when: 'CONFIG_FSL_IMX31', if_true: files('fsl-imx31.c', 'kzm.c')) arm_common_ss.add(when: 'CONFIG_FSL_IMX6', if_true: files('fsl-imx6.c')) -arm_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( +arm_common_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( 'aspeed.c', 'aspeed_soc_common.c', 'aspeed_ast2400.c', 'aspeed_ast2600.c', 'aspeed_ast10x0.c', + 'aspeed_ast27x0.c', 'aspeed_eeprom.c', 'fby35.c')) -arm_common_ss.add(when: ['CONFIG_ASPEED_SOC', 'TARGET_AARCH64'], if_true: files('aspeed_ast27x0.c')) arm_common_ss.add(when: 'CONFIG_MPS2', if_true: files('mps2.c')) arm_common_ss.add(when: 'CONFIG_MPS2', if_true: files('mps2-tz.c')) arm_common_ss.add(when: 'CONFIG_MSF2', if_true: files('msf2-soc.c'))