From patchwork Tue Apr 22 19:26:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 883034 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp2587150wrs; Tue, 22 Apr 2025 12:36:13 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXv4UtPed91Qys24Clw9FsTie9Q96nXOGSGb7QsfbsYHJLgO7sgbibdIxBtbjPhl/6PJl5Kdw==@linaro.org X-Google-Smtp-Source: AGHT+IGBgst3b8/1Euxjkhkn8kodUklXjen+IPCsT5YySqD69CSt0cCAquR6PiFMV+Cq9sDk7TpB X-Received: by 2002:a05:622a:24f:b0:478:eb5f:f948 with SMTP id d75a77b69052e-47aec4dc7aamr310521941cf.49.1745350572901; Tue, 22 Apr 2025 12:36:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745350572; cv=none; d=google.com; s=arc-20240605; b=gQ9XGMClo634SoiXkUEo1dNxPEcsGNwWbBlZIP56fLlcPsUrvqn1TBI2Z5Dvy9km1k 6iy01y7UkagHpAPBgX59FAp2H4cds/SH//K4NkJd2gqJvtHc9IMo7alrmgbkbX5PvC+N vVh/X01c0C1CBKG1JimLcyvX/qdOe0Knww7quFoJWliD8dQFzshn8QjyWNIjkoGmFKTG oGGFJ1fVjfll8nQrtoynFn3LDW9NgYKqgHfZR5eFm8T5Qh/BiIk/TOh8kG4K2Jt6MV7X KuJXj0qIBeGDJaFIhv/onUKvopSs25R20m04pPL8Z18M37DTzx0NUOOSrOOaAQNy8JI5 zOHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=I6MDZmD8wHi337leE/VPRqxkP9hRcv8+ycuZ+hH6Uq0=; fh=6Iy23zC9AdgEjl8BT287tms7OsCTNhvcMTX6iUEgWw0=; b=ZeV4X2oOh2fcdKEtTzvgUDglNaL2nulWN9lb3WrOp+7xxjG1oaItjSrwpzKYRhja4p WJWNXS0ArAlgXdNXzbviTvbuXksVo+db6RObX/lDywLEeQgcxLz78KvWSRI7xFuMMsYY gtAJ8aeF7c/543kCBFKS4nifGW5vvLtGPAtBSXc4fcRwOO8uimFZVB0MaDaF8oh/HfI5 UcLca6JGNSHPWrTl4Kfp4TqmQ8dueGfoTzPo/PJOtgAKXBpAxkne35jEea2EZkx06FUU CStY5HJBmZUhfCLOqcd9NOA6OF0zT7rqlYKRh8jNVLYxNmalzXjCDFb4QoKhh/W2PdT2 sUQA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NrD1VnDp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-47ae9ca3c5csi116085231cf.218.2025.04.22.12.36.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Apr 2025 12:36:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NrD1VnDp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u7JIY-0002XN-Vm; Tue, 22 Apr 2025 15:28:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7JII-0002St-QE for qemu-devel@nongnu.org; Tue, 22 Apr 2025 15:28:34 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u7JIG-0006BU-O1 for qemu-devel@nongnu.org; Tue, 22 Apr 2025 15:28:34 -0400 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-af28bc68846so4772653a12.1 for ; Tue, 22 Apr 2025 12:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745350111; x=1745954911; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I6MDZmD8wHi337leE/VPRqxkP9hRcv8+ycuZ+hH6Uq0=; b=NrD1VnDp844ED4uF21HdG7bwQY3sQqHBsHeeNt1RgbjwJ5cuYFwv6lXnS5DHtHoPmL nFePIGgTLBt7VhAJ4uBEPeLHwhO3xk4PI/XM08At4r/VTw3D3WcCKE2hNQZD7vXYNd25 Urw9s2HTOdi4cihwDk00PQzsXowuqVd2jVyFabaJt1zTLamhRJQu5bEcKjHabcN+ZYND 4mxIsF6AVcEUskhYCOVWcf02gG9/8RNNjkjIO89kW3m3mQgbeU7Cxc8OoIeVYoLN9J0K 2VaC7Xm8tRN1hTEA/9Nl3rY2E1o+Vtu6Vx0ofQzcbw/fNzzqYkxqkv1bbnYY0JEt1/Lo wnyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745350111; x=1745954911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I6MDZmD8wHi337leE/VPRqxkP9hRcv8+ycuZ+hH6Uq0=; b=sELbvNVrdBFypm8pJ9X0I3IdorrH2VznETiy1wlNJH82/ortNMFlTwdZ0EYDr2A/To t2OEPXMQDf6qG5FTsizfgvsME+tkHlYlUCjayA7dE8SwhLCCOf5IxCJow+05NTWY1Rug 7GSTlFO+7MjUPQsqWu+TBWndfqaVQwBRpF/NEHYbnyk3aBFQGk4d4/lKEHmSu0Wy0BHt LMMYw/A83WNIk9aq0ws5DSuI/JgDTZZ3fZwj9GVS/iDdJxLeGRZWtLc4fEnPWj+OC2Ae F/moH7D7RQshZBmBsknOhXtSjAb+Sbz+QwYwbCDFsi0qYMd9zL97Qjn0+vuCEIJC/v9U dQ7g== X-Gm-Message-State: AOJu0Yz0GvlRJu8Hn+RpHFiCKIyW9m0McXTWYX8i72VtlC6k0TsR+s/o 3rWyp2uzeCtbcDCkelizFDe5A24+LgJBnGGKuPoUpiI2C59lSfNd1Ib7BxMcpQfgzdDrK5/Iy/Y l X-Gm-Gg: ASbGncs5pp0I/qMYlnPCFlu3wj0EI4qMyRdj/Mn34BJ21wyPeD3H8HnhAJs9+FBbY1Z jb5Knf7d/ULtbGFgQ8TeJuowAEbr0mg2gPVsI1x+SIkHa29rhKLSppGHwN3VdkTmU+eFpYyWFZe Y+x2tKYYsSb/YX6yScx6zGUTzSKA9sNhg9U0CpYJs4oh7am6ZmGDtDV6ZuGaMs/2cXc3C9lYJMW OrSEUgdSahNTU9ZthGkL7uxIkEB26+gYbnXHDage8uPnvQmWOIVkFwzZPOAhPrzktI4MZjkmfsF 7yeRjlgA/zlYeA9a2i/abhC8GIAkA9QSA5hWGPmAk5tiFfnwMNhjxbYu+YCKgTAoDSaah43U2QE = X-Received: by 2002:a17:90b:4ecf:b0:2ff:62f3:5b31 with SMTP id 98e67ed59e1d1-3087bcc8b16mr22972171a91.29.1745350111082; Tue, 22 Apr 2025 12:28:31 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3087df21278sm9146865a91.29.2025.04.22.12.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 12:28:30 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , =?utf-8?q?Philippe_Mathi?= =?utf-8?q?eu-Daud=C3=A9?= Subject: [PATCH 016/147] include/exec/memory: move devend functions to memory-internal.h Date: Tue, 22 Apr 2025 12:26:05 -0700 Message-ID: <20250422192819.302784-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250422192819.302784-1-richard.henderson@linaro.org> References: <20250422192819.302784-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier Only system/physmem.c and system/memory.c use those functions, so we can move then to internal header. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-ID: <20250317183417.285700-17-pierrick.bouvier@linaro.org> --- include/exec/memory-internal.h | 19 +++++++++++++++++++ include/exec/memory.h | 18 ------------------ 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index b729f3b25a..c75178a3d6 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -43,5 +43,24 @@ void address_space_dispatch_free(AddressSpaceDispatch *d); void mtree_print_dispatch(struct AddressSpaceDispatch *d, MemoryRegion *root); + +/* returns true if end is big endian. */ +static inline bool devend_big_endian(enum device_endian end) +{ + QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && + DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); + + if (end == DEVICE_NATIVE_ENDIAN) { + return target_words_bigendian(); + } + return end == DEVICE_BIG_ENDIAN; +} + +/* enum device_endian to MemOp. */ +static inline MemOp devend_memop(enum device_endian end) +{ + return devend_big_endian(end) ? MO_BE : MO_LE; +} + #endif #endif diff --git a/include/exec/memory.h b/include/exec/memory.h index fc07f69916..2f84a7cfed 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -3138,24 +3138,6 @@ address_space_write_cached(MemoryRegionCache *cache, hwaddr addr, MemTxResult address_space_set(AddressSpace *as, hwaddr addr, uint8_t c, hwaddr len, MemTxAttrs attrs); -/* returns true if end is big endian. */ -static inline bool devend_big_endian(enum device_endian end) -{ - QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && - DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); - - if (end == DEVICE_NATIVE_ENDIAN) { - return target_words_bigendian(); - } - return end == DEVICE_BIG_ENDIAN; -} - -/* enum device_endian to MemOp. */ -static inline MemOp devend_memop(enum device_endian end) -{ - return devend_big_endian(end) ? MO_BE : MO_LE; -} - /* * Inhibit technologies that require discarding of pages in RAM blocks, e.g., * to manage the actual amount of memory consumed by the VM (then, the memory