From patchwork Tue Apr 22 21:11:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 883161 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp2623700wrs; Tue, 22 Apr 2025 14:13:16 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVxZMHpkHe0lXA2VCgIgQou4SfE4vjbWsjHVwsEZ1nunVub/EGfTj6LY6srLBwQnM/taniWmA==@linaro.org X-Google-Smtp-Source: AGHT+IET/YhXFQrjmvBgFYmKk8FyXkqhyJlikvJzJIsmciEp3Ase1Hav/i5+e/I4mjgNdblnxRWu X-Received: by 2002:a05:6214:21ef:b0:6e6:684f:7f78 with SMTP id 6a1803df08f44-6f2c450c0d2mr278746806d6.3.1745356396016; Tue, 22 Apr 2025 14:13:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745356396; cv=none; d=google.com; s=arc-20240605; b=LS0PzVjfBs3x0tSEk841Vy+HDnUeQosrxEyMmbZDTQZpXpF+N+4UW/cZHtSgGKqkx7 ROAcvSv88xK5s34P9KVwrmolcy1QhSup77pCie59PPotXO7dQbjP5tMPiUaMFpX2BK7j ie7UIXnRYtiUWoQGzj0BhoNRz9IuoguSVjuY4bKPyfhsHitxirABr8/UA7PjqXQCm7pS P7Pmu8T3jC5+45uGX/ErjyhL0m5owMBhxqBG8WxzOQ0Dn7GkNX/EukIMuiUIKwVKesos Ox0o1M9tsvVjQOULehfpscFrGaMl6r9HJjb9wSYiAMLoaVxvHFFuLVX4TYBgn1/Fj4GD yC5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=p5VV71JY8goeor4xQCwdYnut93y9ysd8cImiGLe4Oic=; fh=vm85eyWrvOAHduw3sqEA+cYBqvHB7M0MHFcRJg7VWOo=; b=FimGYWnED2eMtELTsD+UFK4Bxw903fnHnDSy5hIe0qxn7vNpu02cUGuowmot4C3C4i UccCoNV2LchknuV7Wj3ZITU/IWQVsbJb7fHBBbVzUchF0aF6VeqcFzftuEzPVoPkXkOQ KA0hvG5BRiMyNVC4loNiBalfDlTKNnqIlgMi2NIrTy3wHB8P/UvTiwkWDVVetjF6e9yf B71x/RdEdfDVR50kATlMAk8x4+wdllnP7tYBV6FpSB2oWJU13ABfwQwJfiK19bTFOPmj CcJB/kYUYtzV2L0jzOWbNPZ1iJLbeqxHEQG/bh/1aUomy+TJTtGTiUcxyxfJ92urFg8i zMSw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cdIMRHb0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6f2c2b2d21asi115719106d6.135.2025.04.22.14.13.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Apr 2025 14:13:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cdIMRHb0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u7KuD-0001IM-8y; Tue, 22 Apr 2025 17:11:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7Ktx-000104-Ds for qemu-devel@nongnu.org; Tue, 22 Apr 2025 17:11:35 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u7Ktu-0000Px-U3 for qemu-devel@nongnu.org; Tue, 22 Apr 2025 17:11:33 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-7376e311086so7939001b3a.3 for ; Tue, 22 Apr 2025 14:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745356289; x=1745961089; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p5VV71JY8goeor4xQCwdYnut93y9ysd8cImiGLe4Oic=; b=cdIMRHb0xncuM2ogmE18r1QK5LH6SKLBjGovynlt+fA6VojwqYzZO5P1SuO7YQhv+m TzHnd8OfDWpjirtnj5gwMIOBeEiY6S66e84xD+b3JDlfy9gWTbf/ZrYTjOaI3TIxuXRv jDe76pZKzkoMDFLvPAV749jCLLZV4LaMkfxO/IPW8V2FyIfFFCznsZu4TysWmgKGhHal 00uSmAYUusUalFhSJzoMAGqUKUd10ZV0oMlgnA3BC3ueNiOjssQSVz23feeLq7JUKhA9 u+ogYriRVKqu9pX/Gsf2JRheoJVdAbreFn/R5TOKXWRdm0MDPhzKjDqHiDZzs7zliE1o bHBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745356289; x=1745961089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p5VV71JY8goeor4xQCwdYnut93y9ysd8cImiGLe4Oic=; b=t0Fajb9/YnTrCR0WV18A9LkkYff8tyveNADP23VtXp0/0GWdUc1334g7SYmI/QWizg 9YxwV8ZbBpBmWXSfH4eX7pf38eHveeJpa2RuE9tuGiqDe5PuoKfxOpBMaqmQZC0BKNea rvj1QB2raz8xOuVA/2xoQF+2/P3o03laWNsEeprDEJS5dY1k+cVx+JTF5QTONyghz1Rf 8X8KPT569HHZ2n8zeJ5SHdfBmeGXe68I3pJgeXAFSJiL3KN+oYjJCNwNpRC86XTUIvSm ErFghgOSm2HGJ9EKOY3mLRr1hKQCj/xlURuWP/gERjtrGXnB4Uaa7prwJA6nkknOf80b FXZQ== X-Gm-Message-State: AOJu0YxnpwD2JMu69ULz1MhUJWZnfKiFyXX3GEMFl5iJFla0Kdj+/zBi AeXDQ2UcaviEZdcRa8HpnL1yQ0TX7uyquEtAUyNVVizTvzv2KZcU3/fXZ+wDwjq+X6wm4A5j183 a X-Gm-Gg: ASbGncsulLrPaKcVZAqYwHhDVJFfP30fdoQleNijLfvPEQ9RL9DtaFVGs/11oe6EnGP IrDL2A8olsFEFeGgK2lOGS5EgMRDVVd35JJlS8G18YHWVB7ZK78sqPbr8UKCSpjOG6zEo/x9UvL /L3oNpJ6STsTcHVBPsp+KuDAinL+yrfuW14dOn1SZjT4pXmVxTNP9wmcIJAMK/W3Ev4GuA4DA5a l4S8lBvFVHXti8A+YgCPrbuTYuRI9lEjX3vRKQvDGFqJqaldorkMkgW0WMfLsSC5YwaSa47zgCP 44ciBU6APQ6X7j2Gm8a/G5+G4Kcwd3gFnqgq75IhpkJRKaTjIPEEv9YUmWcGvLjvPto7pi5xv7u BqyYLAbvIXQ== X-Received: by 2002:a05:6a00:1947:b0:730:95a6:3761 with SMTP id d2e1a72fcca58-73dc144d8fdmr24243657b3a.3.1745356289569; Tue, 22 Apr 2025 14:11:29 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73dbf8e4932sm9448160b3a.55.2025.04.22.14.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 14:11:29 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 6/9] target/avr: Use cpu_stb_mmuidx_ra in helper_fullwr Date: Tue, 22 Apr 2025 14:11:21 -0700 Message-ID: <20250422211124.305724-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250422211124.305724-1-richard.henderson@linaro.org> References: <20250422211124.305724-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Avoid direct use of address_space_memory. Make use of the softmmu cache of the i/o page. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/avr/helper.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target/avr/helper.c b/target/avr/helper.c index d0e86f5614..7d6954ec26 100644 --- a/target/avr/helper.c +++ b/target/avr/helper.c @@ -23,10 +23,10 @@ #include "qemu/error-report.h" #include "cpu.h" #include "accel/tcg/cpu-ops.h" +#include "accel/tcg/getpc.h" #include "exec/cputlb.h" #include "exec/page-protection.h" #include "exec/cpu_ldst.h" -#include "exec/address-spaces.h" #include "exec/helper-proto.h" bool avr_cpu_exec_interrupt(CPUState *cs, int interrupt_request) @@ -67,6 +67,11 @@ bool avr_cpu_exec_interrupt(CPUState *cs, int interrupt_request) return false; } +static void do_stb(CPUAVRState *env, uint32_t addr, uint8_t data, uintptr_t ra) +{ + cpu_stb_mmuidx_ra(env, addr, data, MMU_DATA_IDX, ra); +} + void avr_cpu_do_interrupt(CPUState *cs) { CPUAVRState *env = cpu_env(cs); @@ -311,8 +316,7 @@ void helper_fullwr(CPUAVRState *env, uint32_t data, uint32_t addr) break; default: - address_space_stb(&address_space_memory, OFFSET_DATA + addr, data, - MEMTXATTRS_UNSPECIFIED, NULL); + do_stb(env, addr, data, GETPC()); break; } }