From patchwork Fri Apr 25 21:54:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 884529 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp4184989wrs; Fri, 25 Apr 2025 15:19:00 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCURKnArNHu5OPYPZisoKCsvBQ1gdS1hZey1+Gn2ZyNf/GzXI7Pu4MUyadqLw1xxRj71NkGs9g==@linaro.org X-Google-Smtp-Source: AGHT+IGNA27HVVffQcn6I73cazoxQkGiVzIgYRDJItOWbJotasnPtALmq3g/JsV3Q17cIj5N9lKS X-Received: by 2002:a05:622a:1a08:b0:476:7806:be7e with SMTP id d75a77b69052e-4801c3bb73amr64342801cf.11.1745619540308; Fri, 25 Apr 2025 15:19:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745619540; cv=none; d=google.com; s=arc-20240605; b=LoknQGxQIPFTEJK28ogORGqsr6asE6DxisfYyS7o5YB8CYFk3j3BqRtpTZqDe/En++ BG6k4sERc26/sqe6tq4k8uXa3gTiHHikstmD97fAEUOVcF2ADZRhhkUnXgLIFaGQgWr1 DSsUvDaDRU8jZq0Gh3VnP65snaRp4HyjBCRHFRFZd+UVzLXAfC3zG1We9WwoG5Rws9kM NwCyCroig5Cx+cQdhEbI5mx7wPNFA2Jbrl7XB0i9mlM4afVQ1IXgX8Xcid/KKBCIx4Np iVCpSSCUvJS8FeLLxun+zsWLEfGsnixWoIpbYU/8+9iabNarjZBgy4C3mxmarQr/HKSF OInA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WglycbPcE3zC2RAMMKBRHGhj/1SPbsKRWhmjSwvRD/8=; fh=vm85eyWrvOAHduw3sqEA+cYBqvHB7M0MHFcRJg7VWOo=; b=NmNXb/x4Qpr0TUcH5NLUCC/8/+LNw6Go50THrgDExTkXjkL+65BsJI/BfJT1frPnwl L4MwwfcQ/4P0pLCbkgo8jhPZeY/A98p/jlpQaoR6JTKlMztT8bg4yPqTpsbuLmCcU6XH nycLV8wgxL7g1oAueKlLBWklj23BgHOtm7JS7KVe4MmT8ljPvAq2X4JJpfxnr/P4sS46 uYjcQ9dxwQKF00uHCi9Ht7YO+gIXmgvjaPDQ8y8LBNeSRKbbBdqxxSnEVM9EQiasIaj1 IkTcAlAhmPKFG5V2TaQj8IE9AIuht/F7hJSiM4FL6ANRfUtRJp3XZa2Sy1K4V/Zwry0o Z3FQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ooGkf82r; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-47ea26a3b91si46864951cf.562.2025.04.25.15.19.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Apr 2025 15:19:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ooGkf82r; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8RBb-0005kJ-H5; Fri, 25 Apr 2025 18:06:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8R7n-0005Xc-Dn for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:02:24 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u8R7k-0001OC-7M for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:02:22 -0400 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-22c33e4fdb8so31145705ad.2 for ; Fri, 25 Apr 2025 15:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745618538; x=1746223338; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WglycbPcE3zC2RAMMKBRHGhj/1SPbsKRWhmjSwvRD/8=; b=ooGkf82rksQPkTy99RIJEg7zVG5MGNboHFpPxqAIbES2a0i4MCX6Wq1wDdJpWpVR7R 2+n/Wba4BtCVMXxTLtRLL0m0h5qJKAdG8lK1fB/yv1lNLDMLzwPoqG45Sps0JbeUAUM1 kuMLy0xiTSnJOqyfErMh3CSjgm6cNc+2ZtijVhZDN2tesvMo10GtD/C/E+pp8u1r2ACH PEtBqEekxM1IQfNjqJXurE+Dnqn3JlMnJOh/A+AIcUw3+J5pbc8K6PGq6/Nlcm57WRVU OS7bYAiunW+YOm7I/Aj/69glv0MJZEQ5b8dNg9en0QX5aJhJbQQYqiUtjjxMiWbGnCUv juhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745618538; x=1746223338; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WglycbPcE3zC2RAMMKBRHGhj/1SPbsKRWhmjSwvRD/8=; b=j137j5ZCOGKZEs6xqRUfflSKXAt5Z0YIvh2FkKd1DQsx5jDMVHXP5Ox/xy7GfsLB3M /bxdgyjQvpO74rzcdie5vnywnmtGohP8OMjzVTAQxK4ssx/dPoroThHi1CqPNOqQIVxv boYFnFs0dYjKfeQEHyKSajdvF6CuZGx0s6AtEyO8X58hMKIkqrI+xGNHQ+cS3BS8AKHy RN0GgNQBVKucJxUdvXBYvANNbbanb4cEA9lyZSbeQCre+gMg6xEVa1A9bQyrdVE4EPtc a4FXApXLJBhVhp6ljK8KhuXeb617YLQmvcbaXThFvEX7Z/NcTYH3ig8Ev8V9QMgeoEve DM0g== X-Gm-Message-State: AOJu0YwAxrSh1m4VyRfLgi6R5/114RPNSsi7Cm9S5geguCyWeK2ATOzh In3KSiLDMgboZMjLZgpQPIjeHIijrFyP79YTkm+ggOIHPu04iNI/UFVmMqdcGdBYxSAm6+vT0Ev o X-Gm-Gg: ASbGncs8ugRYl9Hdppklk60Im6z/ZieZKoWOfrrj3YrW9puiL6WOfWa9E1D7eIfHio1 ZCYuwcOSzPkoYwvxpZ1N3SCjj7EIdUQ9YfIVdoAx7ZghRF5uSoabcBdgB5NMiGHyYlq/GS0meLT sxXi6AkDDdcPs4zD8yQfzsQrslNk+MQmgUSxlZ1ZutrlqW/mL646GMUmkLsJpe3mJQ3wvgZq3fh yGdCJOO98u7g8RqH7VyGAp6FKYenThFizzJGWI9kIDCOhzfFls7FyycwcPVphVw/xL0xd/OZYAt KiCcwHN30ie0NzmoS+jBM8CkLtrp4LMaXGkyXtzuwA65e0pymVqk5GiCDtd42FMpZ9ols5E2TUz RgiprbxyZbg== X-Received: by 2002:a17:902:da88:b0:223:5ca1:3b0b with SMTP id d9443c01a7336-22dbf62c6edmr61836715ad.40.1745618538326; Fri, 25 Apr 2025 15:02:18 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309f7765c88sm2212961a91.28.2025.04.25.15.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 15:02:18 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 110/159] tcg: Expand fallback add2 with 32-bit operations Date: Fri, 25 Apr 2025 14:54:04 -0700 Message-ID: <20250425215454.886111-111-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250425215454.886111-1-richard.henderson@linaro.org> References: <20250425215454.886111-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org No need to expand to i64 to perform the add. This is smaller on a loongarch64 host, e.g. bstrpick_d r28, r27, 31, 0 bstrpick_d r29, r24, 31, 0 add_d r28, r28, r29 addi_w r29, r28, 0 srai_d r28, r28, 32 --- add_w r28, r27, r24 sltu r29, r28, r24 Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index edbb214f7c..8b1356c526 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -1105,14 +1105,15 @@ void tcg_gen_add2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 al, if (TCG_TARGET_HAS_add2_i32) { tcg_gen_op6_i32(INDEX_op_add2_i32, rl, rh, al, ah, bl, bh); } else { - TCGv_i64 t0 = tcg_temp_ebb_new_i64(); - TCGv_i64 t1 = tcg_temp_ebb_new_i64(); - tcg_gen_concat_i32_i64(t0, al, ah); - tcg_gen_concat_i32_i64(t1, bl, bh); - tcg_gen_add_i64(t0, t0, t1); - tcg_gen_extr_i64_i32(rl, rh, t0); - tcg_temp_free_i64(t0); - tcg_temp_free_i64(t1); + TCGv_i32 t0 = tcg_temp_ebb_new_i32(); + TCGv_i32 t1 = tcg_temp_ebb_new_i32(); + tcg_gen_add_i32(t0, al, bl); + tcg_gen_setcond_i32(TCG_COND_LTU, t1, t0, al); + tcg_gen_add_i32(rh, ah, bh); + tcg_gen_add_i32(rh, rh, t1); + tcg_gen_mov_i32(rl, t0); + tcg_temp_free_i32(t0); + tcg_temp_free_i32(t1); } }