From patchwork Fri Apr 25 21:54:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 884535 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp4186041wrs; Fri, 25 Apr 2025 15:22:53 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWt/RQxTL1lDeCSR3D9yhLfSCyDYaAvCKJBYtz+jqCCGjbNifNUjuiUdkXRvxN/yjpM4ZPaTw==@linaro.org X-Google-Smtp-Source: AGHT+IHz9M6oYHAwT4JMPIu9islGgbVj/SI12eb6tAHdMsHq/MC8xZuMZyQNvXKeE80VRlhyN4G1 X-Received: by 2002:a05:622a:180f:b0:475:1773:275e with SMTP id d75a77b69052e-4802e07c49cmr72387871cf.13.1745619772805; Fri, 25 Apr 2025 15:22:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745619772; cv=none; d=google.com; s=arc-20240605; b=hQoJEHWqueP71q3YcCJaIbAMqbcxPp4qwqNEOosJ3hpjzLmcNROtNKeNZDJqpw4tsC YLplrTSBIizfcEIzL/1oXj1A57IvXFXhvxDpEC6HjX4y7UkQ+F1mTIz9DGeUS8g9rY6s 6TY5UgJcsLaU6CdRL0XopfIFhVKGN4yswLIgsg469RCXDLLTfZwCrh4uI18mzu3D3B9Y a1sxRzTFa/ZsxGk3uQczN6tEWxZ26DVvqk++wOuDoegTdrERKPl+DzppIDhP1hlAwpsn if/6AvHGVyB/Fqy7IALabbKOYK1M648TthEOPLqmn3Ss/NYxonkk3fJGXjuG5hrJ/EUV ksNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=iIgsM45b/QDIOPbNEdZby6PszUYx14mn+jSOMJ0q4ik=; fh=vm85eyWrvOAHduw3sqEA+cYBqvHB7M0MHFcRJg7VWOo=; b=CQXbVgAXW3nlVYwy8eYjibmCG8q0k2otlQ5y+dsaQGP2UPXXUGfQA4u27AoYPo0isM JEdwk/wu3lnpiO8f/RmEY6XvuzfHNlFCp8wxu7m8uZ4a425mTo3P12xgvHfrA7lYbt0b 4H+QQC5D3R6XXR+a2C0RZCdoUB5g2DQn5vCtV18Ss95c2cjNDncGzvxNQy8DJ5pARw2b YhtIFeMd64SjuqvgTPrLLCWcKZ865JdvI8nmU+OOeqJeUTz4RnnQzz8ix7zhA1wpSpIq 04shOvUhw8Yb2tRVUD3J5TCUNpkPygvBiuyRdpEjniLPk8mTh5OPpxUXEYhYjeWujP+D Ej9w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Rp2mDmqq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-47e9f1d5e72si49130871cf.111.2025.04.25.15.22.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Apr 2025 15:22:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Rp2mDmqq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8RCj-00005h-My; Fri, 25 Apr 2025 18:07:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8RAq-0003er-HH for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:05:39 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u8RAn-0001q4-II for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:05:31 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-736c277331eso3830461b3a.1 for ; Fri, 25 Apr 2025 15:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745618728; x=1746223528; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iIgsM45b/QDIOPbNEdZby6PszUYx14mn+jSOMJ0q4ik=; b=Rp2mDmqqpEsVGZWRMjD4vpuaVABx4KBMxC6pKs3b8rc4CNUjBNviU3ee+jVTOSM4TC hiikpIz2qZU2+xpaPsseh6m+PzcOeL1jihNshsbhmvM/hmezqt/6LKKd+/qfaZgLpOF/ dO3zSvYI6GAK4fVfztViU8/3WQKTggal9gNNa1H8VCqODEpatcW2vq6GRNeX6s8NagiG pVvadsa5C7Qz4AqG+lEZgKYwuGbhNVs9/Ag6cvhpb2X5aQr8WLPe7KFXZzlCFDzy//tL SMTK5WIt4zGGMgk9C706IQ9S4jdJ4LS10y2xGh20Jwjq5fxzCn651JbcPPtP08+8JS+e RLIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745618728; x=1746223528; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iIgsM45b/QDIOPbNEdZby6PszUYx14mn+jSOMJ0q4ik=; b=xK/JjO2vDH+IDoxVaHx57L+0o4Q/xYCcaKRlCXFyV4F4XBgt0qQownR8ZjTPsOoE5u t3n5imdUBszmVPC3+bLCwlT0GENW36sdl+pLzIXxIq0Rzh9cWHoDoD8cWuPwtITledHP TFz0v7k/rcF9yB5rv8Zzm8DJGiqS3lTBCGeRe6n0WbqtKt37s3K1MrXt1khUdQ8VRp4/ Cz6BehigDe917GWuiNIO9ryNX8LvNZSgJP4yvpw51Dvfujh+Pq/rZw/2LpbrIZDZGXSy 0wq4X9xzQoshLs0sIbiBJwmnsCqzBiglgjaGv+S6doTqGO9Q+4T6dAWOmkt/LnsyFGlD 8aPQ== X-Gm-Message-State: AOJu0Yzwkz6gS40SGHq5/jI4CxOkQ27jDf5ARzC9st42b8l6qiq7QAb6 Qm9DGhq2j6i4j7uwC5V4x7cW1fL+zsxgOzut7wc/yWAYIsed0UKKNEXOgAE4X9bXwX4ttWtB/tg p X-Gm-Gg: ASbGncuLYwHJv71A615T/qWq6EWYaYABS2jyp48iHQX8wCV7NS+Y7Nmkc7Rm9yKtw2p dwQr6EclaQsnukvHh4pGZj77Tza+9A9MfHXwExmohy+i1abRy8ilInG7rpad4/M9ll+f0r2mGY7 w6aHUSwF5aQ2Q8lZa9qXiM2YQCewoExEailOnA3kHDg8XJkPeXccH5ZQSK8qsqMXgaZc63kF2yc yg59Z4V4zAkVK8OxBxBqFH22z7b/+Jc11H1e31omndm/9UWAv2qI5b1GDP8eI6nMZEdiz4vqt08 DfYr0+G9JAlPKTcfuGVmnfzFzmUp2HVKb37qaT1t1c8QazWp8bCgbuQNt8JFESyeN0yMqETJWU8 = X-Received: by 2002:a05:6a21:9993:b0:1f3:3864:bbe0 with SMTP id adf61e73a8af0-2045b40ff06mr5175332637.8.1745618727879; Fri, 25 Apr 2025 15:05:27 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a49esm3796573b3a.106.2025.04.25.15.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 15:05:27 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 125/159] tcg/i386: Special case addci r, 0, 0 Date: Fri, 25 Apr 2025 14:54:19 -0700 Message-ID: <20250425215454.886111-126-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250425215454.886111-1-richard.henderson@linaro.org> References: <20250425215454.886111-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Using addci with two zeros as input in order to capture the value of the carry-in bit is common. Special case this with sbb+neg so that we do not have to load 0 into a register first. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- tcg/i386/tcg-target-con-set.h | 1 + tcg/i386/tcg-target.c.inc | 46 ++++++++++++++++++++++++++++++++--- 2 files changed, 44 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target-con-set.h b/tcg/i386/tcg-target-con-set.h index 85c93836bb..458d69c3c0 100644 --- a/tcg/i386/tcg-target-con-set.h +++ b/tcg/i386/tcg-target-con-set.h @@ -45,6 +45,7 @@ C_O1_I2(r, L, L) C_O1_I2(r, r, r) C_O1_I2(r, r, re) C_O1_I2(r, r, ri) +C_O1_I2(r, rO, re) C_O1_I2(x, x, x) C_N1_I2(r, r, r) C_N1_I2(r, r, rW) diff --git a/tcg/i386/tcg-target.c.inc b/tcg/i386/tcg-target.c.inc index 44f9afc0d6..da05f13b21 100644 --- a/tcg/i386/tcg-target.c.inc +++ b/tcg/i386/tcg-target.c.inc @@ -2670,10 +2670,50 @@ static const TCGOutOpBinary outop_addcio = { .out_rri = tgen_addcio_imm, }; +static void tgen_addci_rrr(TCGContext *s, TCGType type, + TCGReg a0, TCGReg a1, TCGReg a2) +{ + /* Because "0O" is not a valid constraint, we must match ourselves. */ + if (a0 == a2) { + tgen_addcio(s, type, a0, a0, a1); + } else { + tcg_out_mov(s, type, a0, a1); + tgen_addcio(s, type, a0, a0, a2); + } +} + +static void tgen_addci_rri(TCGContext *s, TCGType type, + TCGReg a0, TCGReg a1, tcg_target_long a2) +{ + tcg_out_mov(s, type, a0, a1); + tgen_addcio_imm(s, type, a0, a0, a2); +} + +static void tgen_addci_rir(TCGContext *s, TCGType type, + TCGReg a0, tcg_target_long a1, TCGReg a2) +{ + tgen_addci_rri(s, type, a0, a2, a1); +} + +static void tgen_addci_rii(TCGContext *s, TCGType type, TCGReg a0, + tcg_target_long a1, tcg_target_long a2) +{ + if (a2 == 0) { + /* Implement 0 + 0 + C with -(x - x - c). */ + tgen_arithr(s, ARITH_SBB, a0, a0); + tcg_out_modrm(s, OPC_GRP3_Ev, EXT3_NEG, a0); + } else { + tcg_out_movi(s, type, a0, a2); + tgen_addcio_imm(s, type, a0, a0, a1); + } +} + static const TCGOutOpAddSubCarry outop_addci = { - .base.static_constraint = C_O1_I2(r, 0, re), - .out_rrr = tgen_addcio, - .out_rri = tgen_addcio_imm, + .base.static_constraint = C_O1_I2(r, rO, re), + .out_rrr = tgen_addci_rrr, + .out_rri = tgen_addci_rri, + .out_rir = tgen_addci_rir, + .out_rii = tgen_addci_rii, }; static void tcg_out_set_carry(TCGContext *s)