From patchwork Fri Apr 25 21:54:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 884809 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp4191140wrs; Fri, 25 Apr 2025 15:41:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVvBVWUeJsRWqj87UIy9/Z5Wgv/d489kJDz9pjR/yBBvS1vi0yp0Vqa7oW0g11zE+caxGJndA==@linaro.org X-Google-Smtp-Source: AGHT+IG/SAr56ZF0Bc2K4IZ+R/VHzgbOW8rmtOJMzVUwGRXMJG+msTraSUL3JuxIa/Kspzp575Ue X-Received: by 2002:a05:620a:4245:b0:7c5:e2fe:f431 with SMTP id af79cd13be357-7c9668d0b56mr199588985a.52.1745620864666; Fri, 25 Apr 2025 15:41:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745620864; cv=none; d=google.com; s=arc-20240605; b=Z5KX1eczwdrqV0ak1B4C9LV1sJmm7NUN2NYqaH14TvRrS/dFIskJ+rqwLUjhAQgJ14 RLivBUj2+8X1M6wMg5BiK1U4u1Nx5jx2ZgGK/jbNBIEWQQ8G32HDyl73aDuuhmSqJQqP 9n8qiLtN+ANaQIB2i3Lv0bdzBgstT857eJ4yXURlEZG+6XUqLjQcDbx+JI0xVJhbw6Zs HfGUoWMMLfTLuHBZEme4+h4jUVHsApHf+rW5/Q8xjpCFDwtGjtkQZaGdbQfoZnFWjnlW ZPGLb3onBbpahQ2xO2yHz27m7F5hAJZj5JxpYKi0mKckPVPE8Ut9/eOHW/bWEitgi8ni TK1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BrBCsIJgWKGCpaAsMFDooeM8W+Z2wqYDVyB0/xDhg7c=; fh=vm85eyWrvOAHduw3sqEA+cYBqvHB7M0MHFcRJg7VWOo=; b=K9HgXEX9MUqS5WUQr7Gkd+7NYZ+515V/Eo/OpqNbvIu6robevx2mBzOEm/9vxMxPvf 4J3P3q6KyZDeXxqXq3YNYTb5pDHLeIcShv6/ag3gWt8rDEQSMGGOUkJsoWzdSgn9p14F efli2q4LifcSO7strfNUuYjL2cdSYh1Rs/3vexnSx9AIjX5eBkGi/roNTAX66ppXWnkp G2vk3SFPBzKGb264y3Xg5+IUM1R6ONg4YWldABFtBpB81aS3X6fo0iY2/NCxhRRldejz NLdJcmP5iTSdRg7ksmphR17oNuJKPH78sbJA2Q5LRGlVTBBtx/i9wxQ/98dlsrbizEFQ U4OQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BVr2N3XR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c958c9f1a6si467486085a.104.2025.04.25.15.41.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Apr 2025 15:41:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BVr2N3XR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8REM-0002u1-C4; Fri, 25 Apr 2025 18:09:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8RAz-0003iR-IG for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:05:45 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u8RAx-0001st-Pv for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:05:41 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-736c1138ae5so2758857b3a.3 for ; Fri, 25 Apr 2025 15:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745618738; x=1746223538; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BrBCsIJgWKGCpaAsMFDooeM8W+Z2wqYDVyB0/xDhg7c=; b=BVr2N3XRFRAWz+zavJ8cT6qgBFmM+WmYrKeBhIriwRLImqYGCUGIEJDEKLEAUO3tDP H/4hTPvWPyjYCdxHGhiMh3dBhuTOtb+oiirFC7TypErn+i5IDLlYW+jvakcCSICMH6uD CZSMTauITWm1s/dNvSrW8WKIx8IMkWkpe4Gk77OOKFnm4O5SPmgCAeXjki6hiV5YGLW+ 0u4mfN78XlyhvTOgLWi4e6o1P5L1DTU/G0C93v6cuzKDOhKuEDM8lDWfEcFp5TfCLG2V x1rQ4Pl5i3Drh24t9sU94NL/SYpDdlC1QimLYEfWQbN88KSquIjeAj7z4W0AnNi99/XW j2Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745618738; x=1746223538; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BrBCsIJgWKGCpaAsMFDooeM8W+Z2wqYDVyB0/xDhg7c=; b=QeBVn98oapHQHh6ep0/j/kn6rLnIoMsazs99PXh2luym6ESl6JsLpCogBd/gl3tTjE 9A3+zwlCnS4zY8jP79IX4Tkxu/TJZjWXb0uQUZff4IY/q6UDrH7xyskMc2MZmNFANnOJ rn7Qhy2xx89dLJxhPVuUukxgZ2HBI869xrnRe8oFkEq2OCDGFmwmLRSXcJPWVCsLHoMC KxEM778Yg4fZ5AbXPM2jBHx0XNE3LYru2rKVqYjkJXRGAcOJuRQ7TiHmPspOWDEGxqXt Shdtq8SUnn0JqbB8GuFDD9vj3X8/ncPYTfgUej3FogjHHHVTikYigp7uwLHizfaRUF75 VXow== X-Gm-Message-State: AOJu0YxCAcagzVrzHOGpU23bJ99QRNqKXiwWkcFrjpGqYoLv2Z3puyyn QtGloHf0h1mNZUVRAjkkmqgGs8/sFMv5ci/DRm3FVE+ONV+g++wRY9F0/6W730BxQjVK8QWM03h S X-Gm-Gg: ASbGncslmjPjW6KfPSwmx/xoQlI9Iy/jHjzbQKhgTiQlRvdURq1/HofdLJpPzvVl/A6 gsAg36VtpAb7T/Wj9K7uMVGvwLc3VvxonrIEeNLF4VJEkSOjV4jURmJSwMFDvAnVG/2WPF82PjJ pPc0j7aXfitaGQL+MwQvfLkJCV2GcLO67nHV6vGKaofpiHcWhtk1j6iFcN7Vbzn1p7l2WQvQtnA +NMdnZa8sxpZ8MMsKh6IZJKqEr6uD2XShtOWLESzdOO2ZSyeP6yzH5bzhTfX2rJptnFGTuvRPHo OajGHPjo34CFEnb2kDPuKDfKraEauH0Cuoux0kuoh9mfuOu6rVv9fzpw01rL3m7hVPTSd4oXUAc = X-Received: by 2002:a05:6a00:1481:b0:736:42a8:a742 with SMTP id d2e1a72fcca58-73ff72e237amr1363009b3a.11.1745618738400; Fri, 25 Apr 2025 15:05:38 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a49esm3796573b3a.106.2025.04.25.15.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 15:05:38 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 140/159] tcg/s390x: Add TCG_CT_CONST_N32 Date: Fri, 25 Apr 2025 14:54:34 -0700 Message-ID: <20250425215454.886111-141-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250425215454.886111-1-richard.henderson@linaro.org> References: <20250425215454.886111-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We were using S32 | U32 for add2/sub2. But the ALGFI and SLGFI insns that implement this both have uint32_t immediates. This makes the composite range balanced and enables use of -0xffffffff ... -0x80000001. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target-con-set.h | 2 +- tcg/s390x/tcg-target-con-str.h | 1 + tcg/s390x/tcg-target.c.inc | 8 ++++++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tcg/s390x/tcg-target-con-set.h b/tcg/s390x/tcg-target-con-set.h index 78f06e3e52..f5d3878070 100644 --- a/tcg/s390x/tcg-target-con-set.h +++ b/tcg/s390x/tcg-target-con-set.h @@ -44,4 +44,4 @@ C_O2_I2(o, m, 0, r) C_O2_I2(o, m, r, r) C_O2_I3(o, m, 0, 1, r) C_N1_O1_I4(r, r, 0, 1, ri, r) -C_N1_O1_I4(r, r, 0, 1, rJU, r) +C_N1_O1_I4(r, r, 0, 1, rUV, r) diff --git a/tcg/s390x/tcg-target-con-str.h b/tcg/s390x/tcg-target-con-str.h index 3e574e0662..636a38a168 100644 --- a/tcg/s390x/tcg-target-con-str.h +++ b/tcg/s390x/tcg-target-con-str.h @@ -24,4 +24,5 @@ CONST('M', TCG_CT_CONST_M1) CONST('N', TCG_CT_CONST_INV) CONST('R', TCG_CT_CONST_INVRISBG) CONST('U', TCG_CT_CONST_U32) +CONST('V', TCG_CT_CONST_N32) CONST('Z', TCG_CT_CONST_ZERO) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index e262876614..9b28083945 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -43,6 +43,7 @@ #define TCG_CT_CONST_INVRISBG (1 << 14) #define TCG_CT_CONST_CMP (1 << 15) #define TCG_CT_CONST_M1 (1 << 16) +#define TCG_CT_CONST_N32 (1 << 17) #define ALL_GENERAL_REGS MAKE_64BIT_MASK(0, 16) #define ALL_VECTOR_REGS MAKE_64BIT_MASK(32, 32) @@ -613,7 +614,10 @@ static bool tcg_target_const_match(int64_t val, int ct, if ((ct & TCG_CT_CONST_S32) && val == (int32_t)val) { return true; } - if ((ct & TCG_CT_CONST_U32) && val == (uint32_t)val) { + if ((ct & TCG_CT_CONST_U32) && uval <= UINT32_MAX) { + return true; + } + if ((ct & TCG_CT_CONST_N32) && -uval <= UINT32_MAX) { return true; } if ((ct & TCG_CT_CONST_S16) && val == (int16_t)val) { @@ -3548,7 +3552,7 @@ tcg_target_op_def(TCGOpcode op, TCGType type, unsigned flags) case INDEX_op_add2_i64: case INDEX_op_sub2_i64: - return C_N1_O1_I4(r, r, 0, 1, rJU, r); + return C_N1_O1_I4(r, r, 0, 1, rUV, r); case INDEX_op_st_vec: return C_O0_I2(v, r);