From patchwork Fri Apr 25 21:52:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 884443 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp4176877wrs; Fri, 25 Apr 2025 14:55:58 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXIOAmhWXVOojvgdkmJaB89Zxd+/TYNczZ7etriOejV9yA+TObaoYo8qwQ++f8cTryHM9+Ycw==@linaro.org X-Google-Smtp-Source: AGHT+IEg/iVsZ/+Ska8jBob2PPokAMgVasn7wHvY+UCY8920xWOuKBa6zUpnSAgauvneD9/6eT9b X-Received: by 2002:a05:622a:198c:b0:476:add4:d2c6 with SMTP id d75a77b69052e-4801e8e1e04mr77879121cf.50.1745618158031; Fri, 25 Apr 2025 14:55:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745618158; cv=none; d=google.com; s=arc-20240605; b=X5UnPWWLOs5ntWlqkpNnkjL3UijefH2vK/Y8CESJ5xmBQk0ZanGsTLDYBrF5RmeDBO gBnEw9ST7CdD2PVs3LmG2mlQQWzSA+XB6Y97xuysh1JVu38ccSOkqm6d76MErYMrpCpG z/hkJFAIfQ5m235/0t0hQ57JIwdTWqWIr7lDLroCxF7jS1r7iY9LDnOtKSeL70VZmCex rqJ1B1lgGZR6mBbWGHI8lUb/gYaEcsOCdM0gftBhEiRA1wa8SGpv4DaADA+ZHyjfi2HL fe0/tytJxU985EUfOGdqzd9jGkK8Lz+VRGBtlXFsdooUh1CoqB0lPFI6FHh5zJsGqdhd 8Hrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tEIV3z193fHWnIG5VVbHuVsP5oGvNM/X99VgDXcMh7I=; fh=kQadAhxV42GJ3cd2VUw1RyURv/zJQGvmUdF7iLEVTtc=; b=Xj21vUJbG03LaohrYYYJ9p9nORqY+f0Soe8WrTQLAAYfKyq9opVRcbd6tqlKEJyReS M2UAFDMZAXbkMT5/Y5o7hCAT8jaEQo0Bp/6wSp69zHadRtmi1GdzqvEYzXigiIpE3U5j foGwfjSkN3TtXHq3YyKMo3dm95kzFzMneOH9HESVwmLmzFKHcyZta4hf4UQeHRzoe8wK 8HBfKr97E6ui6syGG/tSU+sbGH6s1g181o6Of+pEpu8jqAMlRxKdp7ETKZK00ELia1uh yJ/m2xHdjk5gI5n1eST5Am0RWjl/kpdhYbF6oKq4JcZFug/oGl/jWmN+WxSJjZI2ymWQ eP6Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OVIef16r; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-47e9fa998ddsi48426411cf.199.2025.04.25.14.55.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Apr 2025 14:55:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OVIef16r; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8R19-0007cD-5k; Fri, 25 Apr 2025 17:55:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8R0y-0007V2-1K for qemu-devel@nongnu.org; Fri, 25 Apr 2025 17:55:20 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u8R0v-0000Yt-TU for qemu-devel@nongnu.org; Fri, 25 Apr 2025 17:55:19 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-736c3e7b390so3015239b3a.2 for ; Fri, 25 Apr 2025 14:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745618116; x=1746222916; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tEIV3z193fHWnIG5VVbHuVsP5oGvNM/X99VgDXcMh7I=; b=OVIef16rNSHON0nqablbMa97K0r0vq+d1Vs9QQHRKnDkGd/KqAz0q2gompEgpbeA1w 9pFI+3gypRXMTsJ5R1lrbBAQI1bwlbioikQa96/ND6McnCrZIsiY543Cyi3sCw/0q5v3 zihaVVjHMwgUYyfnAypdJt3h5l9EnCcTd3qSYwgp5OB/ouuijUw4WY6NrLErY/NCGReM BNec6Oh+5bpVVKrmBO+E5fQvzXBpA2HUa5PTaUapAbZIPWhJpgdCv6PS1TmB5lggCjS/ NLI1FzZTKijbJ7aJiRQSZGwzhObvC7+EwJiBX62hTlwyAu6P9gfKUHmziC64TKcSttFA irrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745618116; x=1746222916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tEIV3z193fHWnIG5VVbHuVsP5oGvNM/X99VgDXcMh7I=; b=Q0BjoB0BHQtjEyegWiP6b/Uo8Sp0zf0/70N6IvG8Rxhnnv2fO+r3YS25t2rIgb8g47 WvEFmzUXvcf7K+uqMuREoiHYpdp28LEQ/WOeajGv2PO453EaEae7nT875iXERHkJThmo nLg17e7huJurf8Z3ZrEciw/ULN2wQKW+ik+/Oo90+hHAdOirQjKpLYPpaSI5J68XHeqb 1uHRY/PmKumyqaEVFNLx4c07pyCgSAgUEqULnQoD3suM+cU4sGqw3wce/Z+k3XdcXyjU 8SgC9jIN7ZzHng8KmJQIqs0lJXylWDmlMMuUQbCs84L1zJ0P2Gosgw9DrJDU51ubg886 au6w== X-Gm-Message-State: AOJu0YzhCaBqwUHo9hfKqjcOFuPzajSBBZlKTnbwl5f00q+bP7NMv3Zh wC9SQgUXxHkaIxfGFtga4WvanC4eo7hrDXVhddmHdQu0sGDk9hnbXwYD2wzwVoqu2bl9DCN+YL9 T X-Gm-Gg: ASbGnctvx+ueoJUpuuFg8UoUUqTTMmhd+p5JJqmLDrUdnjRyZ6E5JYA3TPjM3CTyhsi eDClDJ/W/4LOhlyeQBOaTJ5vymTM0CI8ywfXrNdOEgfHIG7/J65gVYhZiob5n4/RLG5E5H97kzU KIeufJb/GzEMHfmF/gFFEAoFOMiHhwDAyzyD5uAXaJSs0PAT19b1+jbeLyxhEpmaIvYo7828llE ixI2C8HHU6AmNhnkh7RusIUCbJ3IRcA4MWPd/nIQy3mCVfQnHaHbMfWRI5ffmmbiINyDLJtqdAR h3sw2UFEv+KNrrYd0l9yzk1LG/GTj35xN83kvpdRRDFyJUr+QBs5mosDLuJe/Ta/hTvCp7MMlB8 = X-Received: by 2002:a05:6a00:1398:b0:732:5164:3cc with SMTP id d2e1a72fcca58-73fd896a1admr5997547b3a.19.1745618116628; Fri, 25 Apr 2025 14:55:16 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e259414b0sm3664392b3a.48.2025.04.25.14.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 14:55:16 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 029/159] tcg/loongarch64: Do not accept constant argument to nor Date: Fri, 25 Apr 2025 14:52:43 -0700 Message-ID: <20250425215454.886111-30-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250425215454.886111-1-richard.henderson@linaro.org> References: <20250425215454.886111-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The instruction set does not implement nor with immediate. There is no reason to pretend that we do. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/loongarch64/tcg-target.c.inc | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc index 814596608a..e74c7d8a87 100644 --- a/tcg/loongarch64/tcg-target.c.inc +++ b/tcg/loongarch64/tcg-target.c.inc @@ -1425,12 +1425,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, TCGType type, case INDEX_op_nor_i32: case INDEX_op_nor_i64: - if (c2) { - tcg_out_opc_ori(s, a0, a1, a2); - tcg_out_opc_nor(s, a0, a0, TCG_REG_ZERO); - } else { - tcg_out_opc_nor(s, a0, a1, a2); - } + tcg_out_opc_nor(s, a0, a1, a2); break; case INDEX_op_extract_i32: @@ -2314,8 +2309,7 @@ tcg_target_op_def(TCGOpcode op, TCGType type, unsigned flags) case INDEX_op_nor_i32: case INDEX_op_nor_i64: - /* LoongArch reg-imm bitops have their imms ZERO-extended */ - return C_O1_I2(r, r, rU); + return C_O1_I2(r, r, r); case INDEX_op_clz_i32: case INDEX_op_clz_i64: